Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63817/?format=api
{ "id": 63817, "url": "http://patches.dpdk.org/api/patches/63817/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-26-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191212152124.260629-26-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191212152124.260629-26-xiaolong.ye@intel.com", "date": "2019-12-12T15:21:13", "name": "[v2,25/36] net/i40e/base: change retrying logic", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "33aab284da741456ac18cad197a063420690ed25", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-26-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7813, "url": "http://patches.dpdk.org/api/series/7813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7813", "date": "2019-12-12T15:20:48", "name": "update for i40e base code", "version": 2, "mbox": "http://patches.dpdk.org/series/7813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63817/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63817/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33E32A04F5;\n\tThu, 12 Dec 2019 16:32:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E87431BFF7;\n\tThu, 12 Dec 2019 16:28:55 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id A01171BFA1\n for <dev@dpdk.org>; Thu, 12 Dec 2019 16:28:27 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2019 07:28:26 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by orsmga006.jf.intel.com with ESMTP; 12 Dec 2019 07:28:25 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"216148340\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>", "Date": "Thu, 12 Dec 2019 23:21:13 +0800", "Message-Id": "<20191212152124.260629-26-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212152124.260629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20191212152124.260629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 25/36] net/i40e/base: change retrying logic", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixed a bug where driver was breaking out of the loop and\nreporting an error without retrying first.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 17 ++++++++++-------\n 1 file changed, 10 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 4f87ec9fa..a37e70599 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -1714,19 +1714,22 @@ enum i40e_status_code i40e_aq_get_phy_capabilities(struct i40e_hw *hw,\n \t\tstatus = i40e_asq_send_command(hw, &desc, abilities,\n \t\t\t\t\t abilities_size, cmd_details);\n \n-\t\tif (status != I40E_SUCCESS)\n-\t\t\tbreak;\n-\n-\t\tif (hw->aq.asq_last_status == I40E_AQ_RC_EIO) {\n+\t\tswitch (hw->aq.asq_last_status) {\n+\t\tcase I40E_AQ_RC_EIO:\n \t\t\tstatus = I40E_ERR_UNKNOWN_PHY;\n \t\t\tbreak;\n-\t\t} else if (hw->aq.asq_last_status == I40E_AQ_RC_EAGAIN) {\n+\t\tcase I40E_AQ_RC_EAGAIN:\n \t\t\ti40e_msec_delay(1);\n \t\t\ttotal_delay++;\n \t\t\tstatus = I40E_ERR_TIMEOUT;\n+\t\t\tbreak;\n+\t\t/* also covers I40E_AQ_RC_OK */\n+\t\tdefault:\n+\t\t\tbreak;\n \t\t}\n-\t} while ((hw->aq.asq_last_status != I40E_AQ_RC_OK) &&\n-\t\t (total_delay < max_delay));\n+\n+\t} while ((hw->aq.asq_last_status == I40E_AQ_RC_EAGAIN) &&\n+\t\t(total_delay < max_delay));\n \n \tif (status != I40E_SUCCESS)\n \t\treturn status;\n", "prefixes": [ "v2", "25/36" ] }