Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63806/?format=api
{ "id": 63806, "url": "http://patches.dpdk.org/api/patches/63806/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-15-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191212152124.260629-15-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191212152124.260629-15-xiaolong.ye@intel.com", "date": "2019-12-12T15:21:02", "name": "[v2,14/36] net/i40e/base: change for missing \"link modes\"", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3b7a0a13eeefd4b0ad16cf9a40b325e5b1cb9908", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191212152124.260629-15-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7813, "url": "http://patches.dpdk.org/api/series/7813/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7813", "date": "2019-12-12T15:20:48", "name": "update for i40e base code", "version": 2, "mbox": "http://patches.dpdk.org/series/7813/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63806/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63806/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 302BEA04F5;\n\tThu, 12 Dec 2019 16:30:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AE2071BFA6;\n\tThu, 12 Dec 2019 16:28:34 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 0AE111BF7E\n for <dev@dpdk.org>; Thu, 12 Dec 2019 16:28:14 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 12 Dec 2019 07:28:14 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by orsmga006.jf.intel.com with ESMTP; 12 Dec 2019 07:28:12 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"216148195\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>", "Date": "Thu, 12 Dec 2019 23:21:02 +0800", "Message-Id": "<20191212152124.260629-15-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191212152124.260629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>\n <20191212152124.260629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 14/36] net/i40e/base: change for missing \"link\n\tmodes\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix for missing \"Supported link modes\" and \"Advertised link modes\"\ninfo in ethtool after changed speed on X722 devices with BASE-T PHY\nwith FW API version >= 1.7.\nThe same FW API version on X710 and X722 does not mean the same\nfeature set so the change was needed as mac type of the device\nshould also be checked instead of FW API version only.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/i40e_common.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex f256651d7..e0028ac4d 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -2043,8 +2043,8 @@ enum i40e_status_code i40e_aq_get_link_info(struct i40e_hw *hw,\n \t hw->aq.fw_min_ver < 40)) && hw_link_info->phy_type == 0xE)\n \t\thw_link_info->phy_type = I40E_PHY_TYPE_10GBASE_SFPP_CU;\n \n-\tif (hw->aq.api_maj_ver == I40E_FW_API_VERSION_MAJOR &&\n-\t hw->aq.api_min_ver >= 7) {\n+\tif (hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE &&\n+\t hw->mac.type != I40E_MAC_X722) {\n \t\t__le32 tmp;\n \n \t\ti40e_memcpy(&tmp, resp->link_type, sizeof(tmp),\n", "prefixes": [ "v2", "14/36" ] }