Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63762/?format=api
{ "id": 63762, "url": "http://patches.dpdk.org/api/patches/63762/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191211145004.11672-3-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191211145004.11672-3-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191211145004.11672-3-arkadiuszx.kusztal@intel.com", "date": "2019-12-11T14:50:02", "name": "[v3,2/4] common/qat: move max inflights param into qp", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "93fb889bfaa4463b682a3ac7a076cf7ae6b78adf", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191211145004.11672-3-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 7795, "url": "http://patches.dpdk.org/api/series/7795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7795", "date": "2019-12-11T14:50:00", "name": "Add dual threading in QAT PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/7795/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63762/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B14EAA04F6;\n\tWed, 11 Dec 2019 15:51:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 749F81BEC4;\n\tWed, 11 Dec 2019 15:51:25 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 6FC141BE3D\n for <dev@dpdk.org>; Wed, 11 Dec 2019 15:51:23 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 11 Dec 2019 06:51:23 -0800", "from akusztax-mobl.ger.corp.intel.com ([10.104.12.173])\n by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2019 06:51:21 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,301,1571727600\"; d=\"scan'208\";a=\"220478765\"", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com, declan.doherty@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Wed, 11 Dec 2019 15:50:02 +0100", "Message-Id": "<20191211145004.11672-3-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.19.1.windows.1", "In-Reply-To": "<20191211145004.11672-1-arkadiuszx.kusztal@intel.com>", "References": "<20191211145004.11672-1-arkadiuszx.kusztal@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/4] common/qat: move max inflights param into\n\tqp", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Fiona Trahe <fiona.trahe@intel.com>\n\nThe max_inflights parameter is moved from qat_queue to qat_qp as it's\na more appropriate location.\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/common/qat/qat_qp.c | 23 ++++++++++++-----------\n drivers/common/qat/qat_qp.h | 2 +-\n 2 files changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex 01ddce0..8e4c74a 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -239,6 +239,15 @@ int qat_qp_setup(struct qat_pci_device *qat_dev,\n \t\tgoto create_err;\n \t}\n \n+\tqp->max_inflights = ADF_MAX_INFLIGHTS(qp->tx_q.queue_size,\n+\t\t\t\tADF_BYTES_TO_MSG_SIZE(qp->tx_q.msg_size));\n+\n+\tif (qp->max_inflights < 2) {\n+\t\tQAT_LOG(ERR, \"Invalid num inflights\");\n+\t\tqat_queue_delete(&(qp->tx_q));\n+\t\tgoto create_err;\n+\t}\n+\n \tif (qat_queue_create(qat_dev, &(qp->rx_q), qat_qp_conf,\n \t\t\t\t\tADF_RING_DIR_RX) != 0) {\n \t\tQAT_LOG(ERR, \"Rx queue create failed \"\n@@ -416,15 +425,7 @@ qat_queue_create(struct qat_pci_device *qat_dev, struct qat_queue *queue,\n \t\tgoto queue_create_err;\n \t}\n \n-\tqueue->max_inflights = ADF_MAX_INFLIGHTS(queue->queue_size,\n-\t\t\t\t\tADF_BYTES_TO_MSG_SIZE(desc_size));\n \tqueue->modulo_mask = (1 << ADF_RING_SIZE_MODULO(queue->queue_size)) - 1;\n-\n-\tif (queue->max_inflights < 2) {\n-\t\tQAT_LOG(ERR, \"Invalid num inflights\");\n-\t\tret = -EINVAL;\n-\t\tgoto queue_create_err;\n-\t}\n \tqueue->head = 0;\n \tqueue->tail = 0;\n \tqueue->msg_size = desc_size;\n@@ -443,11 +444,11 @@ qat_queue_create(struct qat_pci_device *qat_dev, struct qat_queue *queue,\n \t\t\tqueue->hw_queue_number, queue_base);\n \n \tQAT_LOG(DEBUG, \"RING: Name:%s, size in CSR: %u, in bytes %u,\"\n-\t\t\" nb msgs %u, msg_size %u, max_inflights %u modulo mask %u\",\n+\t\t\" nb msgs %u, msg_size %u, modulo mask %u\",\n \t\t\tqueue->memz_name,\n \t\t\tqueue->queue_size, queue_size_bytes,\n \t\t\tqp_conf->nb_descriptors, desc_size,\n-\t\t\tqueue->max_inflights, queue->modulo_mask);\n+\t\t\tqueue->modulo_mask);\n \n \treturn 0;\n \n@@ -590,7 +591,7 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n \n \t/* Find how many can actually fit on the ring */\n \ttmp_qp->inflights16 += nb_ops;\n-\toverflow = tmp_qp->inflights16 - queue->max_inflights;\n+\toverflow = tmp_qp->inflights16 - tmp_qp->max_inflights;\n \tif (overflow > 0) {\n \t\ttmp_qp->inflights16 -= overflow;\n \t\tnb_ops_possible = nb_ops - overflow;\ndiff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h\nindex 9212ca4..5066f06 100644\n--- a/drivers/common/qat/qat_qp.h\n+++ b/drivers/common/qat/qat_qp.h\n@@ -51,7 +51,6 @@ struct qat_queue {\n \tuint32_t\ttail;\t\t\t/* Shadow copy of the tail */\n \tuint32_t\tmodulo_mask;\n \tuint32_t\tmsg_size;\n-\tuint16_t\tmax_inflights;\n \tuint32_t\tqueue_size;\n \tuint8_t\t\thw_bundle_number;\n \tuint8_t\t\thw_queue_number;\n@@ -76,6 +75,7 @@ struct qat_qp {\n \tenum qat_service_type service_type;\n \tstruct qat_pci_device *qat_dev;\n \t/**< qat device this qp is on */\n+\tuint16_t max_inflights;\n } __rte_cache_aligned;\n \n extern const struct qat_qp_hw_data qat_gen1_qps[][ADF_MAX_QPS_ON_ANY_SERVICE];\n", "prefixes": [ "v3", "2/4" ] }