Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63761/?format=api
{ "id": 63761, "url": "http://patches.dpdk.org/api/patches/63761/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191211145004.11672-2-arkadiuszx.kusztal@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191211145004.11672-2-arkadiuszx.kusztal@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191211145004.11672-2-arkadiuszx.kusztal@intel.com", "date": "2019-12-11T14:50:01", "name": "[v3,1/4] common/qat: remove tail write coalescing feature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3d0be55fd0c646fe2b8f060bbc59575e68d93ccd", "submitter": { "id": 452, "url": "http://patches.dpdk.org/api/people/452/?format=api", "name": "Arkadiusz Kusztal", "email": "arkadiuszx.kusztal@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191211145004.11672-2-arkadiuszx.kusztal@intel.com/mbox/", "series": [ { "id": 7795, "url": "http://patches.dpdk.org/api/series/7795/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7795", "date": "2019-12-11T14:50:00", "name": "Add dual threading in QAT PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/7795/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63761/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 038BAA04F6;\n\tWed, 11 Dec 2019 15:51:24 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AEF821BE82;\n\tWed, 11 Dec 2019 15:51:23 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id ECB2E1BE3D\n for <dev@dpdk.org>; Wed, 11 Dec 2019 15:51:21 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 11 Dec 2019 06:51:20 -0800", "from akusztax-mobl.ger.corp.intel.com ([10.104.12.173])\n by fmsmga001.fm.intel.com with ESMTP; 11 Dec 2019 06:51:19 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,301,1571727600\"; d=\"scan'208\";a=\"220478758\"", "From": "Arek Kusztal <arkadiuszx.kusztal@intel.com>", "To": "dev@dpdk.org", "Cc": "akhil.goyal@nxp.com, fiona.trahe@intel.com, declan.doherty@intel.com,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>", "Date": "Wed, 11 Dec 2019 15:50:01 +0100", "Message-Id": "<20191211145004.11672-2-arkadiuszx.kusztal@intel.com>", "X-Mailer": "git-send-email 2.19.1.windows.1", "In-Reply-To": "<20191211145004.11672-1-arkadiuszx.kusztal@intel.com>", "References": "<20191211145004.11672-1-arkadiuszx.kusztal@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 1/4] common/qat: remove tail write coalescing\n\tfeature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Fiona Trahe <fiona.trahe@intel.com>\n\nThe feature Coalescing Tail Writes on Enqueue is removed\nas it is not thread-safe and a dual-thread feature will be added shortly.\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\nSigned-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>\n---\n drivers/common/qat/qat_qp.c | 16 +++-------------\n drivers/common/qat/qat_qp.h | 6 ------\n 2 files changed, 3 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex 03f11f8..01ddce0 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -538,7 +538,6 @@ static inline void\n txq_write_tail(struct qat_qp *qp, struct qat_queue *q) {\n \tWRITE_CSR_RING_TAIL(qp->mmap_bar_addr, q->hw_bundle_number,\n \t\t\tq->hw_queue_number, q->tail);\n-\tq->nb_pending_requests = 0;\n \tq->csr_tail = q->tail;\n }\n \n@@ -622,25 +621,20 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n kick_tail:\n \tqueue->tail = tail;\n \ttmp_qp->stats.enqueued_count += nb_ops_sent;\n-\tqueue->nb_pending_requests += nb_ops_sent;\n-\tif (tmp_qp->inflights16 < QAT_CSR_TAIL_FORCE_WRITE_THRESH ||\n-\t\t queue->nb_pending_requests > QAT_CSR_TAIL_WRITE_THRESH) {\n-\t\ttxq_write_tail(tmp_qp, queue);\n-\t}\n+\ttxq_write_tail(tmp_qp, queue);\n \treturn nb_ops_sent;\n }\n \n uint16_t\n qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n {\n-\tstruct qat_queue *rx_queue, *tx_queue;\n+\tstruct qat_queue *rx_queue;\n \tstruct qat_qp *tmp_qp = (struct qat_qp *)qp;\n \tuint32_t head;\n \tuint32_t resp_counter = 0;\n \tuint8_t *resp_msg;\n \n \trx_queue = &(tmp_qp->rx_q);\n-\ttx_queue = &(tmp_qp->tx_q);\n \thead = rx_queue->head;\n \tresp_msg = (uint8_t *)rx_queue->base_addr + rx_queue->head;\n \n@@ -677,11 +671,7 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n \t\t\t\t\t\tQAT_CSR_HEAD_WRITE_THRESH)\n \t\t\trxq_free_desc(tmp_qp, rx_queue);\n \t}\n-\t/* also check if tail needs to be advanced */\n-\tif (tmp_qp->inflights16 <= QAT_CSR_TAIL_FORCE_WRITE_THRESH &&\n-\t\ttx_queue->tail != tx_queue->csr_tail) {\n-\t\ttxq_write_tail(tmp_qp, tx_queue);\n-\t}\n+\n \treturn resp_counter;\n }\n \ndiff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h\nindex 980c2ba..9212ca4 100644\n--- a/drivers/common/qat/qat_qp.h\n+++ b/drivers/common/qat/qat_qp.h\n@@ -11,10 +11,6 @@ struct qat_pci_device;\n \n #define QAT_CSR_HEAD_WRITE_THRESH 32U\n /* number of requests to accumulate before writing head CSR */\n-#define QAT_CSR_TAIL_WRITE_THRESH 32U\n-/* number of requests to accumulate before writing tail CSR */\n-#define QAT_CSR_TAIL_FORCE_WRITE_THRESH 256U\n-/* number of inflights below which no tail write coalescing should occur */\n \n typedef int (*build_request_t)(void *op,\n \t\tuint8_t *req, void *op_cookie,\n@@ -64,8 +60,6 @@ struct qat_queue {\n \tuint32_t\tcsr_tail;\t\t/* last written tail value */\n \tuint16_t\tnb_processed_responses;\n \t/* number of responses processed since last CSR head write */\n-\tuint16_t\tnb_pending_requests;\n-\t/* number of requests pending since last CSR tail write */\n };\n \n struct qat_qp {\n", "prefixes": [ "v3", "1/4" ] }