Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63746/?format=api
http://patches.dpdk.org/api/patches/63746/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1576057875-7677-7-git-send-email-xiaojun.liu@silicom.co.il/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1576057875-7677-7-git-send-email-xiaojun.liu@silicom.co.il>", "list_archive_url": "https://inbox.dpdk.org/dev/1576057875-7677-7-git-send-email-xiaojun.liu@silicom.co.il", "date": "2019-12-11T09:52:15", "name": "[v2,6/7] net/fm10k: add mirror and filter ctrl", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "083a07869ed82379bcdc6f93ebdd9e9ee9734785", "submitter": { "id": 1512, "url": "http://patches.dpdk.org/api/people/1512/?format=api", "name": "Xiaojun Liu", "email": "xiaojun.liu@silicom.co.il" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1576057875-7677-7-git-send-email-xiaojun.liu@silicom.co.il/mbox/", "series": [ { "id": 7788, "url": "http://patches.dpdk.org/api/series/7788/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7788", "date": "2019-12-11T09:51:58", "name": "support switch management", "version": 2, "mbox": "http://patches.dpdk.org/series/7788/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63746/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63746/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0EF05A04F1;\n\tWed, 11 Dec 2019 10:53:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A4AA11BF8C;\n\tWed, 11 Dec 2019 10:52:17 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr140123.outbound.protection.outlook.com [40.107.14.123])\n by dpdk.org (Postfix) with ESMTP id 3AB581BF85\n for <dev@dpdk.org>; Wed, 11 Dec 2019 10:52:16 +0100 (CET)", "from DB7PR04MB5196.eurprd04.prod.outlook.com (20.176.234.140) by\n DB7PR04MB4203.eurprd04.prod.outlook.com (52.135.131.12) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.2538.14; Wed, 11 Dec 2019 09:52:15 +0000", "from DB7PR04MB5196.eurprd04.prod.outlook.com\n ([fe80::cdaa:fcae:322b:59ed]) by DB7PR04MB5196.eurprd04.prod.outlook.com\n ([fe80::cdaa:fcae:322b:59ed%7]) with mapi id 15.20.2516.018; Wed, 11 Dec 2019\n 09:52:15 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=VdlOtNtQlQFF8U8fOSClIHn63l0kH5nmKleiy1Z3w8FEnAvItwzrsLRytpQf4Du3+PLodzDDKiHgxLT5D5wcgLDy/usm7/vWRpbmyzd6TVdrK8Z81jgvxBUS8HR+TT3aIP3zdU9rzWymSFrP0WtnlL0ly5iuuziu/nS0QFHubz6oMOqPsPTbL0a7BajxJHDOzc2xASB2ZUK8d+eFPBCxbfiGjs6VpdMD9vXjZsVtzO5kF/etu/5YLehRxWJpRxPsZg77hNVOZwLGfNyrZ26Lk2NwMQtPLJ19vfllRHviyuWVIgGeh8q+4p8z4RwdufQjeaylXhTLF7SNcA3lL8DFcQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1IyWw4puaWJ7ST9i0QRgjHQB6LXMJtJLeLgzcKsQN3Y=;\n b=QRH6SRvkUruoLr38ICKYnjIEedhcuHLzeNmsR/XSDhsC3p/P6Pfea19ATKNF0l8GrJGocBJIFIDuz4gyg2pnXrBv1siIG4+Xvdw70vN8X4utTJKlBaI5eAUJEeqTzmf7+XcZxWmFA0ekx50vGMxTpi5lcyTw0IKVdyZ3ubutmTAF2dpFKHyUcVp1vTdmoWqT1Ir3ToZBEImFV0lfoKktuOQpxbH4ABWOhUQpv/HQeoVZHZmAqBt+7Bkde8UmfMLl7efiOEublPJTnlKKsOsMyLmkxGpauV+IQb518XVsJjwlHUwLIluyBsKT3HN+iE4rqJXUfGnP0kX8vH+KQdSVAA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom.co.il; dmarc=pass action=none\n header.from=silicom.co.il; dkim=pass header.d=silicom.co.il; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=1IyWw4puaWJ7ST9i0QRgjHQB6LXMJtJLeLgzcKsQN3Y=;\n b=obeezYj/Tc129f3FXUnBeXoms3OJiAoXpuFsan8hfvWIsFKqQcvcZlfYVPplqwqVbXufC9YnB1MqoaCUd5DxG2SaERT/I7hk0GG8ibHMfJpYRTj6O5RoVWJGoYzdaNie8iUJif8bjy/1HrfggRDhDa/0EZ852f58Z3lyIxfeghM=", "From": "Xiaojun Liu <xiaojun.liu@silicom.co.il>", "To": "\"xiao.w.wang@intel.com\" <xiao.w.wang@intel.com>, \"qi.z.zhang@intel.com\"\n <qi.z.zhang@intel.com>, \"ngai-mint.kwan@intel.com\"\n <ngai-mint.kwan@intel.com>, \"jakub.fornal@intel.co\" <jakub.fornal@intel.co>,\n \"jacob.e.keller@intel.com\" <jacob.e.keller@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Xiaojun Liu <xiaojun.liu@silicom.co.il>", "Thread-Topic": "[PATCH v2 6/7] net/fm10k: add mirror and filter ctrl", "Thread-Index": "AQHVsAir8Oo79bKWvkmtbdc7dbEPHA==", "Date": "Wed, 11 Dec 2019 09:52:15 +0000", "Message-ID": "<1576057875-7677-7-git-send-email-xiaojun.liu@silicom.co.il>", "References": "<xiaojun.liu@silicom.co.il>\n <1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il>", "In-Reply-To": "<1576057875-7677-1-git-send-email-xiaojun.liu@silicom.co.il>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HK2PR02CA0180.apcprd02.prod.outlook.com\n (2603:1096:201:21::16) To DB7PR04MB5196.eurprd04.prod.outlook.com\n (2603:10a6:10:1a::12)", "authentication-results": "spf=none (sender IP is )\n smtp.mailfrom=xiaojun.liu@silicom.co.il;", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 1.8.3.1", "x-originating-ip": "[113.110.226.253]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "7ef02289-5eeb-42d6-1bfe-08d77e1fcd6f", "x-ms-traffictypediagnostic": "DB7PR04MB4203:", "x-ms-exchange-transport-forked": "True", "x-microsoft-antispam-prvs": "\n <DB7PR04MB4203C85B47F5CC821F2D0AF7BD5A0@DB7PR04MB4203.eurprd04.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:2276;", "x-forefront-prvs": "024847EE92", "x-forefront-antispam-report": "SFV:NSPM;\n SFS:(10019020)(346002)(366004)(136003)(39850400004)(376002)(396003)(199004)(189003)(2906002)(71200400001)(81156014)(64756008)(316002)(66556008)(6506007)(44832011)(8676002)(52116002)(81166006)(26005)(66476007)(54906003)(110136005)(66946007)(186003)(36756003)(6512007)(4326008)(86362001)(2616005)(107886003)(6486002)(66446008)(8936002)(5660300002)(478600001);\n DIR:OUT; SFP:1102; SCL:1; SRVR:DB7PR04MB4203;\n H:DB7PR04MB5196.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n PTR:InfoNoRecords; A:1; MX:1;", "received-spf": "None (protection.outlook.com: silicom.co.il does not designate\n permitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam": "BCL:0;", "x-microsoft-antispam-message-info": "\n uqb8UvxkWaBnBMnSfc6ZCpSr0pgnvHEPzz2WLttVzj5sZ6mO8YVZz2H1slNd//ntMVU8d1h08LJSKYF8ev+HoJ7D5721WXZyOTM44hXq7Gh6LKGDzxK6bMUiAtWAZsuY67xOxO6pHc9L6fLRPMHbFEGy+77igvJ7v5K3oMiaf0Ndsf7cZw0fys/OWxjAIg22MiLGe7i3Qm0MUb7Tr62yEa8yEigiltg87rUnSfKN9eawNRyDTtY8YOdBMYMbkR8sO3Voa9awFoO99YB3if/LY1YLPuEbaOhaCoBIF+ERs2kkuXs8hxSuZxE9+tX6gljohtVzqTdakNomiV2JHg45inXNmDsVXY9NO8Dcnz1Rca5FFwWzE71vGHCw25PynKhO9oocNt+O2aIpLkA/XA/cDcaaaoufB+aoWtBFmJ9RohycSKRJDk5kKh7j7rUZBW3i", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "silicom.co.il", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7ef02289-5eeb-42d6-1bfe-08d77e1fcd6f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "11 Dec 2019 09:52:15.3530 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n dDSRtfnzOTybgGFXvdDm9U/Hk1OCyFYqsaz+yFxdoLn2PlmhME6Lu27DZkzdADsUPPX9w4ltofOliHqXVCgUduV/z2aAr69w/rQXsdMAKQw=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR04MB4203", "Subject": "[dpdk-dev] [PATCH v2 6/7] net/fm10k: add mirror and filter ctrl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Modify fm10k/fm10k_ethdev.c.\nAdd fm10k_mirror_rule_set/fm10k_mirror_rule_reset\nto support mirror operation.\nAdd fm10k_dev_filter_ctrl to\nsupport flow operation.\n\nTo avoid configuration for both kernel driver\nand userspace SDK outside DPDK, we add switch\nmanagement in FM10K DPDK PMD driver.\nTo enable switch management, you need add\nCONFIG_RTE_FM10K_MANAGEMENT=y in\nconfig/common_linux when building.\n\nSigned-off-by: Xiaojun Liu <xiaojun.liu@silicom.co.il>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 76 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 76 insertions(+)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 4c81952..1c01684 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -2288,6 +2288,77 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+#ifdef ENABLE_FM10K_MANAGEMENT\n+static int\n+fm10k_mirror_rule_set(struct rte_eth_dev *dev,\n+\t\t\tstruct rte_eth_mirror_conf *mirror_conf,\n+\t\t\tuint8_t sw_id, uint8_t on)\n+{\n+\tstruct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\tPMD_INIT_LOG(DEBUG,\n+\t\t\t\"Mirror set, switch %d to port %d attach vlan %d on %d\",\n+\t\t\tsw_id, mirror_conf->dst_pool,\n+\t\t\tmirror_conf->vlan.vlan_id[0], on);\n+\n+\tif (on)\t{\n+\t\tif (fm10k_switch_mirror_set(hw,\n+\t\t\t\tmirror_conf->dst_pool,\n+\t\t\t\tmirror_conf->vlan.vlan_id[0]) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Input wrong port!!!\");\n+\t\t\treturn -1;\n+\t\t}\n+\t} else {\n+\t\tif (fm10k_switch_mirror_reset(hw) < 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Input wrong port!!!\");\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+\n+static int\n+fm10k_mirror_rule_reset(struct rte_eth_dev *dev, uint8_t sw_id)\n+{\n+\tstruct fm10k_hw *hw = FM10K_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\tPMD_INIT_LOG(DEBUG, \"Mirror reset, switch %d\", sw_id);\n+\n+\tfm10k_switch_mirror_reset(hw);\n+\n+\treturn 0;\n+}\n+\n+static int\n+fm10k_dev_filter_ctrl(struct rte_eth_dev *dev,\n+\t\t enum rte_filter_type filter_type,\n+\t\t enum rte_filter_op filter_op,\n+\t\t void *arg)\n+{\n+\tint ret = 0;\n+\n+\tif (dev == NULL)\n+\t\treturn -EINVAL;\n+\n+\tswitch (filter_type) {\n+\tcase RTE_ETH_FILTER_GENERIC:\n+\t\tif (filter_op != RTE_ETH_FILTER_GET)\n+\t\t\treturn -EINVAL;\n+\t\t*(const void **)arg = fm10k_flow_ops_get();\n+\t\tbreak;\n+\tdefault:\n+\t\tPMD_DRV_LOG(WARNING, \"Filter type (%d) not supported\",\n+\t\t\t\t\t\t\tfilter_type);\n+\t\tret = -EINVAL;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+#endif\n+\n static void\n fm10k_dev_enable_intr_pf(struct rte_eth_dev *dev)\n {\n@@ -2949,6 +3020,11 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev)\n \t.reta_query\t\t= fm10k_reta_query,\n \t.rss_hash_update\t= fm10k_rss_hash_update,\n \t.rss_hash_conf_get\t= fm10k_rss_hash_conf_get,\n+#ifdef ENABLE_FM10K_MANAGEMENT\n+\t.mirror_rule_set\t= fm10k_mirror_rule_set,\n+\t.mirror_rule_reset\t= fm10k_mirror_rule_reset,\n+\t.filter_ctrl\t\t= fm10k_dev_filter_ctrl,\n+#endif\n };\n \n static int ftag_check_handler(__rte_unused const char *key,\n", "prefixes": [ "v2", "6/7" ] }{ "id": 63746, "url": "