Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63694/?format=api
{ "id": 63694, "url": "http://patches.dpdk.org/api/patches/63694/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191209214656.27347-18-cardigliano@ntop.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191209214656.27347-18-cardigliano@ntop.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20191209214656.27347-18-cardigliano@ntop.org", "date": "2019-12-09T21:46:56", "name": "[v3,17/17] net/ionic: read fw version", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "82396bae116beee1c93d4370b7b9ac1966d14434", "submitter": { "id": 1465, "url": "http://patches.dpdk.org/api/people/1465/?format=api", "name": "Alfredo Cardigliano", "email": "cardigliano@ntop.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191209214656.27347-18-cardigliano@ntop.org/mbox/", "series": [ { "id": 7760, "url": "http://patches.dpdk.org/api/series/7760/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7760", "date": "2019-12-09T21:46:39", "name": "Introduces net/ionic PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/7760/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63694/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63694/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35964A04B3;\n\tMon, 9 Dec 2019 22:51:38 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AEE201BFD5;\n\tMon, 9 Dec 2019 22:49:05 +0100 (CET)", "from mail.ntop.org (mail-digitalocean.ntop.org [167.99.215.164])\n by dpdk.org (Postfix) with ESMTP id 72A151BEC4\n for <dev@dpdk.org>; Mon, 9 Dec 2019 22:48:36 +0100 (CET)", "from devele.ntop.org (net-93-145-196-230.cust.vodafonedsl.it\n [93.145.196.230])\n by mail.ntop.org (Postfix) with ESMTPSA id 1FE1241C32;\n Mon, 9 Dec 2019 22:48:36 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ntop.org; s=mail;\n t=1575928116; bh=ZUqwCe+RbP49i8YnGZr/3+PLf/e4SorqQLZ20UuSMUI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=cn/F06m9+dNNkc5ubU9Gfs8azH5oDVwVHkLiNem/SDzCmttmwE5BeG84S4MqkEOsQ\n pgjL4M4TAll2f+9gepTsCEiWrjlmeJZoN9PUr5rYVKh2DSO7CsrFJw91ZQu1bxd311\n sBwjiBhTNYhMDvm8/U0Kmrtt7h1xrXqDGbh/dn2I=", "From": "Alfredo Cardigliano <cardigliano@ntop.org>", "To": "Alfredo Cardigliano <cardigliano@ntop.org>,\n John McNamara <john.mcnamara@intel.com>,\n Marko Kovacevic <marko.kovacevic@intel.com>", "Cc": "dev@dpdk.org", "Date": "Mon, 9 Dec 2019 22:46:56 +0100", "Message-Id": "<20191209214656.27347-18-cardigliano@ntop.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191209214656.27347-1-cardigliano@ntop.org>", "References": "<20191209214656.27347-1-cardigliano@ntop.org>", "Subject": "[dpdk-dev] [PATCH v3 17/17] net/ionic: read fw version", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for reading the firmware version.\n\nSigned-off-by: Alfredo Cardigliano <cardigliano@ntop.org>\nReviewed-by: Shannon Nelson <snelson@pensando.io>\n---\n doc/guides/nics/features/ionic.ini | 1 +\n drivers/net/ionic/ionic.h | 1 +\n drivers/net/ionic/ionic_dev.c | 8 ++++++++\n drivers/net/ionic/ionic_ethdev.c | 20 ++++++++++++++++++++\n 4 files changed, 30 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini\nindex f4ec04c73..32e9bce55 100644\n--- a/doc/guides/nics/features/ionic.ini\n+++ b/doc/guides/nics/features/ionic.ini\n@@ -30,6 +30,7 @@ Packet type parsing = Y\n Basic stats = Y\n Extended stats = Y\n Stats per queue = Y\n+FW version = Y\n Linux UIO = Y\n Linux VFIO = Y\n x86-64 = Y\ndiff --git a/drivers/net/ionic/ionic.h b/drivers/net/ionic/ionic.h\nindex ae4f6acc7..45a7879c9 100644\n--- a/drivers/net/ionic/ionic.h\n+++ b/drivers/net/ionic/ionic.h\n@@ -60,6 +60,7 @@ struct ionic_adapter {\n \tbool intrs[IONIC_INTR_CTRL_REGS_MAX];\n \tbool is_mgmt_nic;\n \tbool link_up;\n+\tchar fw_version[IONIC_DEVINFO_FWVERS_BUFLEN];\n \tstruct rte_pci_device *pci_dev;\n \tLIST_ENTRY(ionic_adapter) pci_adapters;\n };\ndiff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c\nindex 1c5a4425b..0b63c234d 100644\n--- a/drivers/net/ionic/ionic_dev.c\n+++ b/drivers/net/ionic/ionic_dev.c\n@@ -16,6 +16,7 @@ ionic_dev_setup(struct ionic_adapter *adapter)\n \tstruct ionic_dev *idev = &adapter->idev;\n \tuint32_t sig;\n \tu_char *bar0_base;\n+\tunsigned int i;\n \n \t/* BAR0: dev_cmd and interrupts */\n \tif (num_bars < 1) {\n@@ -47,6 +48,13 @@ ionic_dev_setup(struct ionic_adapter *adapter)\n \t\treturn -EFAULT;\n \t}\n \n+\tfor (i = 0; i < IONIC_DEVINFO_FWVERS_BUFLEN; i++)\n+\t\tadapter->fw_version[i] =\n+\t\t\tioread8(&idev->dev_info->fw_version[i]);\n+\tadapter->fw_version[IONIC_DEVINFO_FWVERS_BUFLEN - 1] = '\\0';\n+\n+\tIONIC_PRINT(DEBUG, \"Firmware version: %s\", adapter->fw_version);\n+\n \t/* BAR1: doorbells */\n \tbar++;\n \tif (num_bars < 2) {\ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 7c8e70872..34b01f526 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -56,6 +56,8 @@ static int ionic_dev_xstats_get_names(struct rte_eth_dev *dev,\n static int ionic_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \tstruct rte_eth_xstat_name *xstats_names, const uint64_t *ids,\n \tunsigned int limit);\n+static int ionic_dev_fw_version_get(struct rte_eth_dev *eth_dev,\n+\tchar *fw_version, size_t fw_size);\n \n int ionic_logtype_driver;\n \n@@ -122,6 +124,7 @@ static const struct eth_dev_ops ionic_eth_dev_ops = {\n \t.xstats_reset = ionic_dev_xstats_reset,\n \t.xstats_get_names = ionic_dev_xstats_get_names,\n \t.xstats_get_names_by_id = ionic_dev_xstats_get_names_by_id,\n+\t.fw_version_get = ionic_dev_fw_version_get,\n };\n \n /*\n@@ -219,6 +222,23 @@ static const struct rte_ionic_xstats_name_off rte_ionic_xstats_strings[] = {\n #define IONIC_NB_HW_STATS (sizeof(rte_ionic_xstats_strings) / \\\n \t\tsizeof(rte_ionic_xstats_strings[0]))\n \n+static int\n+ionic_dev_fw_version_get(struct rte_eth_dev *eth_dev,\n+\t\tchar *fw_version, size_t fw_size)\n+{\n+\tstruct ionic_lif *lif = IONIC_ETH_DEV_TO_LIF(eth_dev);\n+\tstruct ionic_adapter *adapter = lif->adapter;\n+\n+\tif (fw_version == NULL || fw_size <= 0)\n+\t\treturn -EINVAL;\n+\n+\tsnprintf(fw_version, fw_size, \"%s\",\n+\t\t adapter->fw_version);\n+\tfw_version[fw_size - 1] = '\\0';\n+\n+\treturn 0;\n+}\n+\n /*\n * Set device link up, enable tx.\n */\n", "prefixes": [ "v3", "17/17" ] }