Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63606/?format=api
{ "id": 63606, "url": "http://patches.dpdk.org/api/patches/63606/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191205173128.64543-5-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191205173128.64543-5-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191205173128.64543-5-ciara.power@intel.com", "date": "2019-12-05T17:31:26", "name": "[RFC,4/6] ethdev: add callback support for process-info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6268af7a5c7b7540543a9182b0f6f1ee2d9303d8", "submitter": { "id": 978, "url": "http://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191205173128.64543-5-ciara.power@intel.com/mbox/", "series": [ { "id": 7741, "url": "http://patches.dpdk.org/api/series/7741/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7741", "date": "2019-12-05T17:31:22", "name": "replace telemetry with process_info", "version": 1, "mbox": "http://patches.dpdk.org/series/7741/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63606/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63606/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23474A04F2;\n\tThu, 5 Dec 2019 18:34:49 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DBF721BFA4;\n\tThu, 5 Dec 2019 18:34:18 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id CB27C1BF8B\n for <dev@dpdk.org>; Thu, 5 Dec 2019 18:34:13 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 05 Dec 2019 09:34:13 -0800", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga002.jf.intel.com with ESMTP; 05 Dec 2019 09:34:12 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,282,1571727600\"; d=\"scan'208\";a=\"223711848\"", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Date": "Thu, 5 Dec 2019 17:31:26 +0000", "Message-Id": "<20191205173128.64543-5-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191205173128.64543-1-ciara.power@intel.com>", "References": "<20191205173128.64543-1-ciara.power@intel.com>", "Subject": "[dpdk-dev] [RFC 4/6] ethdev: add callback support for process-info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Bruce Richardson <bruce.richardson@intel.com>\n\nThe ethdev library now registers commands with process_info, and\nimplements the callback functions. These commands allow the list of\nethdev ports and the stats for a port to be queried.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n lib/librte_ethdev/Makefile | 2 +-\n lib/librte_ethdev/rte_ethdev.c | 73 ++++++++++++++++++++++++++++++++++\n 2 files changed, 74 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile\nindex b627e4e23..f586f83de 100644\n--- a/lib/librte_ethdev/Makefile\n+++ b/lib/librte_ethdev/Makefile\n@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_net -lrte_eal -lrte_mempool -lrte_ring\n-LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter\n+LDLIBS += -lrte_mbuf -lrte_kvargs -lrte_meter -lrte_process_info\n \n EXPORT_MAP := rte_ethdev_version.map\n \ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 6e9cb243e..b0b5ceec5 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -38,6 +38,7 @@\n #include <rte_kvargs.h>\n #include <rte_class.h>\n #include <rte_ether.h>\n+#include <rte_process_info.h>\n \n #include \"rte_ethdev.h\"\n #include \"rte_ethdev_driver.h\"\n@@ -5190,9 +5191,81 @@ rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da)\n \treturn result;\n }\n \n+static int\n+handle_port_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tint used = 0;\n+\tint port_id;\n+\n+\tused = strlcpy(buffer, \"[\", buf_len);\n+\tRTE_ETH_FOREACH_DEV(port_id)\n+\t\tused += snprintf(buffer + used, buf_len - used, \"%d,\", port_id);\n+\tbuffer[used - 1] = ']';\n+\treturn used;\n+}\n+\n+static int\n+handle_port_stats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tchar *buffer, int buf_len)\n+{\n+\tstruct rte_eth_xstat *eth_xstats;\n+\tstruct rte_eth_xstat_name *xstat_names;\n+\tint port_id, num_xstats;\n+\tint i, ret;\n+\tint used = 0;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tused = strlcpy(buffer, \"{\", buf_len);\n+\n+\tnum_xstats = rte_eth_xstats_get(port_id, NULL, 0);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for both names and stats */\n+\teth_xstats = malloc((sizeof(struct rte_eth_xstat) +\n+\t\t\tsizeof(struct rte_eth_xstat_name)) * num_xstats);\n+\tif (eth_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)ð_xstats[num_xstats];\n+\n+\tret = rte_eth_xstats_get_names(port_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_eth_xstats_get(port_id, eth_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tfor (i = 0; i < num_xstats; i++) {\n+\t\tret = snprintf(buffer + used, buf_len - used, \"\\\"%s\\\":%\"PRIu64\",\",\n+\t\t\t\txstat_names[i].name, eth_xstats[i].value);\n+\t\tif (ret + used >= buf_len)\n+\t\t\tbreak;\n+\t\tused += ret;\n+\t}\n+\n+\tbuffer[used - 1] = '}';\n+\treturn used;\n+}\n+\n RTE_INIT(ethdev_init_log)\n {\n \trte_eth_dev_logtype = rte_log_register(\"lib.ethdev\");\n \tif (rte_eth_dev_logtype >= 0)\n \t\trte_log_set_level(rte_eth_dev_logtype, RTE_LOG_INFO);\n+\trte_process_info_register(\"/ethdev:list\", handle_port_list);\n+\trte_process_info_register(\"/ethdev:stats\", handle_port_stats);\n }\n", "prefixes": [ "RFC", "4/6" ] }