Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63587/?format=api
{ "id": 63587, "url": "http://patches.dpdk.org/api/patches/63587/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191205123847.39579-6-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191205123847.39579-6-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191205123847.39579-6-qi.z.zhang@intel.com", "date": "2019-12-05T12:38:40", "name": "[05/12] net/ice/base: flexbytes should match on header data", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1112f9c1f5a7035c542c8ef3264f3d4aa2fb1408", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191205123847.39579-6-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 7737, "url": "http://patches.dpdk.org/api/series/7737/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7737", "date": "2019-12-05T12:38:35", "name": "base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/7737/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63587/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63587/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35B9AA04F2;\n\tThu, 5 Dec 2019 13:36:36 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 962481BFA4;\n\tThu, 5 Dec 2019 13:35:57 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by dpdk.org (Postfix) with ESMTP id 4F30A1BF8F\n for <dev@dpdk.org>; Thu, 5 Dec 2019 13:35:49 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 05 Dec 2019 04:35:49 -0800", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga008.fm.intel.com with ESMTP; 05 Dec 2019 04:35:47 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,281,1571727600\"; d=\"scan'208\";a=\"209122741\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "xiaolong.ye@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Henry Tieman <henry.w.tieman@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Thu, 5 Dec 2019 20:38:40 +0800", "Message-Id": "<20191205123847.39579-6-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20191205123847.39579-1-qi.z.zhang@intel.com>", "References": "<20191205123847.39579-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 05/12] net/ice/base: flexbytes should match on\n\theader data", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the extraction sequence generated by flow director flexbytes to\nuse package mac protocol. Without this change data in packet headers\ncannot be used for flexbyte matching. The old extraction for flex bytes\nstarted at the beginning of the payload which is after the header.\n\nSigned-off-by: Henry Tieman <henry.w.tieman@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_flow.c | 17 ++++-------------\n drivers/net/ice/base/ice_flow.h | 2 +-\n 2 files changed, 5 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c\nindex 391df1b54..eaa7a3b96 100644\n--- a/drivers/net/ice/base/ice_flow.c\n+++ b/drivers/net/ice/base/ice_flow.c\n@@ -868,20 +868,11 @@ ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \n \t\traw = ¶ms->prof->segs[seg].raws[i];\n \n-\t\t/* Only support matching raw fields in the payload */\n-\t\tif (raw->off < hdrs_sz)\n-\t\t\treturn ICE_ERR_PARAM;\n-\n-\t\t/* Convert the segment-relative offset into payload-relative\n-\t\t * offset.\n-\t\t */\n-\t\toff = raw->off - hdrs_sz;\n-\n \t\t/* Storing extraction information */\n-\t\traw->info.xtrct.prot_id = ICE_PROT_PAY;\n-\t\traw->info.xtrct.off = (off / ICE_FLOW_FV_EXTRACT_SZ) *\n+\t\traw->info.xtrct.prot_id = ICE_PROT_MAC_OF_OR_S;\n+\t\traw->info.xtrct.off = (raw->off / ICE_FLOW_FV_EXTRACT_SZ) *\n \t\t\tICE_FLOW_FV_EXTRACT_SZ;\n-\t\traw->info.xtrct.disp = (off % ICE_FLOW_FV_EXTRACT_SZ) *\n+\t\traw->info.xtrct.disp = (raw->off % ICE_FLOW_FV_EXTRACT_SZ) *\n \t\t\tBITS_PER_BYTE;\n \t\traw->info.xtrct.idx = params->es_cnt;\n \n@@ -909,7 +900,7 @@ ice_flow_xtract_raws(struct ice_hw *hw, struct ice_flow_prof_params *params,\n \t\t\telse\n \t\t\t\tidx = params->es_cnt;\n \n-\t\t\tparams->es[idx].prot_id = ICE_PROT_PAY;\n+\t\t\tparams->es[idx].prot_id = raw->info.xtrct.prot_id;\n \t\t\tparams->es[idx].off = off;\n \t\t\tparams->es_cnt++;\n \t\t\toff += ICE_FLOW_FV_EXTRACT_SZ;\ndiff --git a/drivers/net/ice/base/ice_flow.h b/drivers/net/ice/base/ice_flow.h\nindex 4686274af..d7b10ccc3 100644\n--- a/drivers/net/ice/base/ice_flow.h\n+++ b/drivers/net/ice/base/ice_flow.h\n@@ -282,8 +282,8 @@ struct ice_flow_fld_info {\n };\n \n struct ice_flow_seg_fld_raw {\n-\tint off;\t/* Offset from the start of the segment */\n \tstruct ice_flow_fld_info info;\n+\tu16 off;\t/* Offset from the start of the segment */\n };\n \n struct ice_flow_seg_info {\n", "prefixes": [ "05/12" ] }