Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63580/?format=api
{ "id": 63580, "url": "http://patches.dpdk.org/api/patches/63580/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1575546206-2478-4-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1575546206-2478-4-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1575546206-2478-4-git-send-email-anoobj@marvell.com", "date": "2019-12-05T11:43:25", "name": "[3/4] crypto/octeontx2: add ECDSA support", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dd159405353f77f0f14d33089ba2d8932d36802e", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1575546206-2478-4-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 7736, "url": "http://patches.dpdk.org/api/series/7736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7736", "date": "2019-12-05T11:43:22", "name": "add ECDSA support", "version": 1, "mbox": "http://patches.dpdk.org/series/7736/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63580/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63580/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC29AA04F2;\n\tThu, 5 Dec 2019 12:45:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 393471BF9B;\n\tThu, 5 Dec 2019 12:44:56 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 196F61BF8B\n for <dev@dpdk.org>; Thu, 5 Dec 2019 12:44:54 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xB5BfGwO020214; Thu, 5 Dec 2019 03:44:53 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 2wpybwgd6b-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 05 Dec 2019 03:44:53 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Dec\n 2019 03:44:51 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Thu, 5 Dec 2019 03:44:51 -0800", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 4B4883F703F;\n Thu, 5 Dec 2019 03:44:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=tTCL+w6o8oxZFyMeam9EZBBaccw2UDNIMl2yXoGTOgE=;\n b=A+PJX5WWM7uX/mZyRk9OG6p7B9+TNlGabqOfQDpo9TOSE8upTbgdaoGv9hDpeX9uBfbh\n lHBezrbV7VTtnBMJoS3cu9wkFAusNQom/kemlXR8D8Vw4ZkVnLBv53qdlzhQcIU+6+pC\n SAw+MV6P/rgaqZAZEXGmHuX0GbrJ/GGARPne4gXssWkSDUBb6F0fuM5AhQUXqb4c8+Gr\n ObBZhOHqiqxy6nq9bzGcD+YXWljozat/RCWLTPsYpzJRsMEsqO1CpvBJaqQf+6ICXGYO\n gchHpiWpwOd/LsqvIu6SLf/YTGEbkaWvGyUQldyOv4EPYkagwa0y09cVLC1c5rMWOMKD 6g==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Sunila Sahu <ssahu@marvell.com>, Fiona Trahe <fiona.trahe@intel.com>,\n \"Arek Kusztal\" <arkadiuszx.kusztal@intel.com>, Jerin Jacob\n <jerinj@marvell.com>, Narayana Prasad <pathreya@marvell.com>, Shally Verma\n <shallyv@marvell.com>,\n Ankur Dwivedi <adwivedi@marvell.com>, <dev@dpdk.org>,\n Anoob Joseph <anoobj@marvell.com>, Balakrishna Bhamidipati\n <bbhamidipati@marvell.com>", "Date": "Thu, 5 Dec 2019 17:13:25 +0530", "Message-ID": "<1575546206-2478-4-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1575546206-2478-1-git-send-email-anoobj@marvell.com>", "References": "<1575546206-2478-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-05_03:2019-12-04,2019-12-05 signatures=0", "Subject": "[dpdk-dev] [PATCH 3/4] crypto/octeontx2: add ECDSA support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Sunila Sahu <ssahu@marvell.com>\n\nAdding support for ECDSA operations in crypto_octeontx2 PMD.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Balakrishna Bhamidipati <bbhamidipati@marvell.com>\nSigned-off-by: Sunila Sahu <ssahu@marvell.com>\n---\n doc/guides/cryptodevs/features/octeontx2.ini | 8 +++--\n .../crypto/octeontx2/otx2_cryptodev_capabilities.c | 11 ++++++\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 39 ++++++++++++++++++++--\n 3 files changed, 54 insertions(+), 4 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/features/octeontx2.ini b/doc/guides/cryptodevs/features/octeontx2.ini\nindex 7d07053..dd6369b 100644\n--- a/doc/guides/cryptodevs/features/octeontx2.ini\n+++ b/doc/guides/cryptodevs/features/octeontx2.ini\n@@ -67,5 +67,9 @@ AES GCM (256) = Y\n ; Supported Asymmetric algorithms of the 'octeontx2' crypto driver.\n ;\n [Asymmetric]\n-RSA = Y\n-Modular Exponentiation = Y\n+RSA = Y\n+DSA =\n+Modular Exponentiation = Y\n+Modular Inversion =\n+Diffie-hellman =\n+ECDSA = Y\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c b/drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c\nindex b9e3fe3..f2079e2 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c\n@@ -628,6 +628,17 @@ rte_cryptodev_capabilities otx2_cpt_capabilities[] = {\n \t\t\t}\n \t\t}, }\n \t},\n+\t{\t/* ECDSA */\n+\t\t.op = RTE_CRYPTO_OP_TYPE_ASYMMETRIC,\n+\t\t{.asym = {\n+\t\t\t.xform_capa = {\n+\t\t\t\t.xform_type = RTE_CRYPTO_ASYM_XFORM_ECDSA,\n+\t\t\t\t.op_types = ((1 << RTE_CRYPTO_ASYM_OP_SIGN) |\n+\t\t\t\t\t(1 << RTE_CRYPTO_ASYM_OP_VERIFY)),\n+\t\t\t\t}\n+\t\t\t},\n+\t\t}\n+\t},\n \t/* End of asymmetric capabilities */\n \tRTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()\n };\ndiff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex 65101b0..17c755d 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -22,6 +22,8 @@\n \n #define METABUF_POOL_CACHE_SIZE\t512\n \n+static uint64_t otx2_fpm_iova[CPT_EC_ID_PMAX];\n+\n /* Forward declarations */\n \n static int\n@@ -440,6 +442,11 @@ otx2_cpt_enqueue_asym(struct otx2_cpt_qp *qp,\n \t\tif (unlikely(ret))\n \t\t\tgoto req_fail;\n \t\tbreak;\n+\tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n+\t\tret = cpt_enqueue_ecdsa_op(op, ¶ms, sess, otx2_fpm_iova);\n+\t\tif (unlikely(ret))\n+\t\t\tgoto req_fail;\n+\t\tbreak;\n \tdefault:\n \t\top->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n \t\tret = -EINVAL;\n@@ -641,6 +648,23 @@ otx2_cpt_asym_rsa_op(struct rte_crypto_op *cop, struct cpt_request_info *req,\n \t}\n }\n \n+static __rte_always_inline void\n+otx2_cpt_asym_dequeue_ecdsa_op(struct rte_crypto_ecdsa_op_param *ecdsa,\n+\t\t\t struct cpt_request_info *req,\n+\t\t\t struct cpt_asym_ec_ctx *ec)\n+{\n+\tint prime_len = ec_grp[ec->curveid].prime.length;\n+\n+\tif (ecdsa->op_type == RTE_CRYPTO_ASYM_OP_VERIFY)\n+\t\treturn;\n+\n+\t/* Separate out sign r and s components */\n+\tmemcpy(ecdsa->r.data, req->rptr, prime_len);\n+\tmemcpy(ecdsa->s.data, req->rptr + ROUNDUP8(prime_len), prime_len);\n+\tecdsa->r.length = prime_len;\n+\tecdsa->s.length = prime_len;\n+}\n+\n static void\n otx2_cpt_asym_post_process(struct rte_crypto_op *cop,\n \t\t\t struct cpt_request_info *req)\n@@ -660,6 +684,9 @@ otx2_cpt_asym_post_process(struct rte_crypto_op *cop,\n \t\tmemcpy(op->modex.result.data, req->rptr,\n \t\t op->modex.result.length);\n \t\tbreak;\n+\tcase RTE_CRYPTO_ASYM_XFORM_ECDSA:\n+\t\totx2_cpt_asym_dequeue_ecdsa_op(&op->ecdsa, req, &sess->ec_ctx);\n+\t\tbreak;\n \tdefault:\n \t\tCPT_LOG_DP_DEBUG(\"Invalid crypto xform type\");\n \t\tcop->status = RTE_CRYPTO_OP_STATUS_INVALID_ARGS;\n@@ -824,6 +851,13 @@ otx2_cpt_dev_config(struct rte_cryptodev *dev,\n \n \tdev->feature_flags &= ~conf->ff_disable;\n \n+\tif (dev->feature_flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO) {\n+\t\t/* Initialize shared FPM table */\n+\t\tret = cpt_fpm_init(otx2_fpm_iova);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\t}\n+\n \t/* Unregister error interrupts */\n \tif (vf->err_intr_registered)\n \t\totx2_cpt_err_intr_unregister(dev);\n@@ -881,9 +915,10 @@ otx2_cpt_dev_start(struct rte_cryptodev *dev)\n static void\n otx2_cpt_dev_stop(struct rte_cryptodev *dev)\n {\n-\tRTE_SET_USED(dev);\n-\n \tCPT_PMD_INIT_FUNC_TRACE();\n+\n+\tif (dev->feature_flags & RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO)\n+\t\tcpt_fpm_clear();\n }\n \n static int\n", "prefixes": [ "3/4" ] }