Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63578/?format=api
{ "id": 63578, "url": "http://patches.dpdk.org/api/patches/63578/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1575546206-2478-2-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1575546206-2478-2-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1575546206-2478-2-git-send-email-anoobj@marvell.com", "date": "2019-12-05T11:43:23", "name": "[1/4] lib/crypto: add support for ECDSA", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0ad352e1f8ae0cbf3d6d3f7158ab08cd892684a9", "submitter": { "id": 1205, "url": "http://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1575546206-2478-2-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 7736, "url": "http://patches.dpdk.org/api/series/7736/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7736", "date": "2019-12-05T11:43:22", "name": "add ECDSA support", "version": 1, "mbox": "http://patches.dpdk.org/series/7736/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63578/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63578/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 002CDA04F2;\n\tThu, 5 Dec 2019 12:44:46 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20C981BF89;\n\tThu, 5 Dec 2019 12:44:43 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 18F211BF88\n for <dev@dpdk.org>; Thu, 5 Dec 2019 12:44:42 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xB5Bg0MQ020922; Thu, 5 Dec 2019 03:44:41 -0800", "from sc-exch01.marvell.com ([199.233.58.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 2wpybwgd51-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 05 Dec 2019 03:44:41 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 5 Dec\n 2019 03:44:39 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Thu, 5 Dec 2019 03:44:39 -0800", "from ajoseph83.caveonetworks.com.com (unknown [10.29.45.60])\n by maili.marvell.com (Postfix) with ESMTP id 05A5D3F703F;\n Thu, 5 Dec 2019 03:44:34 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=Z4SOkpa8d8dEcsVNBBThwG12U/wZUwVUV+N3+htWwYM=;\n b=B7WWsawCtNps+iq+XyL/+cKO6wQV8ove4Y5surbXIai5PkxkOcq8+t8y8ciz0pTMLrEK\n xdLYakUrj9Nax5b845CfDKXHVRICgdCnykDLGrAWWR4vKRf+uhUO0Qlu4YTNStAcbJnm\n 4XZzVzOfXqw2kmxuJgOjIRqrYkWrydpOOuHESSqXPPaOSsOb7nebOLZpvSeKdZjpdqxa\n 3mOsVw/guinQtCQJDMCHZ6TU9+d51S3uTrxT8aHFGBSo6I02j12BMgVuXwX0XkwSHOdp\n 5gY6uGqZlmhwfH41gvNmoc9oavDhu1XQPWX2+fJdaMWYDt3qNwfghlSYpbl+3NC7SoPc qA==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>, Declan Doherty\n <declan.doherty@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>", "CC": "Ayuj Verma <ayverma@marvell.com>, Fiona Trahe <fiona.trahe@intel.com>,\n Arek Kusztal <arkadiuszx.kusztal@intel.com>, Jerin Jacob\n <jerinj@marvell.com>, Narayana Prasad <pathreya@marvell.com>, Shally Verma\n <shallyv@marvell.com>, Ankur Dwivedi <adwivedi@marvell.com>, Sunila Sahu\n <ssahu@marvell.com>, <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>", "Date": "Thu, 5 Dec 2019 17:13:23 +0530", "Message-ID": "<1575546206-2478-2-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1575546206-2478-1-git-send-email-anoobj@marvell.com>", "References": "<1575546206-2478-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-12-05_03:2019-12-04,2019-12-05 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/4] lib/crypto: add support for ECDSA", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ayuj Verma <ayverma@marvell.com>\n\nElliptic curve xform and ECDSA op params are added.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Ayuj Verma <ayverma@marvell.com>\nSigned-off-by: Sunila Sahu <ssahu@marvell.com>\n---\n doc/guides/cryptodevs/features/default.ini | 11 ++--\n lib/librte_cryptodev/rte_crypto_asym.h | 83 ++++++++++++++++++++++++++++++\n lib/librte_cryptodev/rte_cryptodev.c | 1 +\n 3 files changed, 90 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryptodevs/features/default.ini\nindex b7f9a0a..2f6c785 100644\n--- a/doc/guides/cryptodevs/features/default.ini\n+++ b/doc/guides/cryptodevs/features/default.ini\n@@ -103,8 +103,9 @@ AES CCM (256) =\n ; Supported Asymmetric algorithms of a default crypto driver.\n ;\n [Asymmetric]\n-RSA =\n-DSA =\n-Modular Exponentiation =\n-Modular Inversion =\n-Diffie-hellman =\n\\ No newline at end of file\n+RSA =\n+DSA =\n+Modular Exponentiation =\n+Modular Inversion =\n+Diffie-hellman =\n+ECDSA =\ndiff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h\nindex 0d34ce8..dd5e6e3 100644\n--- a/lib/librte_cryptodev/rte_crypto_asym.h\n+++ b/lib/librte_cryptodev/rte_crypto_asym.h\n@@ -81,6 +81,10 @@ enum rte_crypto_asym_xform_type {\n \t/**< Modular Exponentiation\n \t * Perform Modular Exponentiation b^e mod n\n \t */\n+\tRTE_CRYPTO_ASYM_XFORM_ECDSA,\n+\t/**< Elliptic Curve Digital Signature Algorithm\n+\t * Perform Signature Generation and Verification.\n+\t */\n \tRTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END\n \t/**< End of list */\n };\n@@ -319,6 +323,46 @@ struct rte_crypto_dsa_xform {\n };\n \n /**\n+ * TLS named curves\n+ * https://www.iana.org/assignments/tls-parameters/\n+ * tls-parameters.xhtml#tls-parameters-8\n+ * secp192r1 = 19,\n+ * secp224r1 = 21,\n+ * secp256r1 = 23,\n+ * secp384r1 = 24,\n+ * secp521r1 = 25,\n+ */\n+enum rte_crypto_ec_group {\n+\tRTE_CRYPTO_EC_GROUP_UNKNOWN = 0,\n+\tRTE_CRYPTO_EC_GROUP_NISTP192 = 19,\n+\tRTE_CRYPTO_EC_GROUP_NISTP224 = 21,\n+\tRTE_CRYPTO_EC_GROUP_NISTP256 = 23,\n+\tRTE_CRYPTO_EC_GROUP_NISTP384 = 24,\n+\tRTE_CRYPTO_EC_GROUP_NISTP521 = 25,\n+};\n+\n+/**\n+ * Structure for elliptic curve point\n+ */\n+struct rte_crypto_ec_point {\n+\trte_crypto_param x;\n+\t/**< X coordinate */\n+\trte_crypto_param y;\n+\t/**< Y coordinate */\n+};\n+\n+/**\n+ * Asymmetric elliptic curve transform data\n+ *\n+ * Structure describing all EC based xform params\n+ *\n+ */\n+struct rte_crypto_ec_xform {\n+\tenum rte_crypto_ec_group curve_id;\n+\t/**< Pre-defined ec groups */\n+};\n+\n+/**\n * Operations params for modular operations:\n * exponentiation and multiplicative inverse\n *\n@@ -372,6 +416,11 @@ struct rte_crypto_asym_xform {\n \n \t\tstruct rte_crypto_dsa_xform dsa;\n \t\t/**< DSA xform parameters */\n+\n+\t\tstruct rte_crypto_ec_xform ec;\n+\t\t/**< EC xform parameters, used by elliptic curve based\n+\t\t * operations.\n+\t\t */\n \t};\n };\n \n@@ -516,6 +565,39 @@ struct rte_crypto_dsa_op_param {\n };\n \n /**\n+ * ECDSA operation params\n+ */\n+struct rte_crypto_ecdsa_op_param {\n+\tenum rte_crypto_asym_op_type op_type;\n+\t/**< Signature generation or verification */\n+\n+\trte_crypto_param pkey;\n+\t/**< Private key of the signer for signature generation */\n+\n+\tstruct rte_crypto_ec_point q;\n+\t/**< Public key of the signer for verification */\n+\n+\trte_crypto_param message;\n+\t/**< Input message to be signed or verified */\n+\n+\trte_crypto_param k;\n+\t/**< The ECDSA per-message secret number, which is an integer\n+\t * in the interval (1, n-1)\n+\t */\n+\n+\trte_crypto_param r;\n+\t/**< r component of elliptic curve signature\n+\t * output : for signature generation\n+\t * input : for signature verification\n+\t */\n+\trte_crypto_param s;\n+\t/**< s component of elliptic curve signature\n+\t * output : for signature generation\n+\t * input : for signature verification\n+\t */\n+};\n+\n+/**\n * Asymmetric Cryptographic Operation.\n *\n * Structure describing asymmetric crypto operation params.\n@@ -537,6 +619,7 @@ struct rte_crypto_asym_op {\n \t\tstruct rte_crypto_mod_op_param modinv;\n \t\tstruct rte_crypto_dh_op_param dh;\n \t\tstruct rte_crypto_dsa_op_param dsa;\n+\t\tstruct rte_crypto_ecdsa_op_param ecdsa;\n \t};\n };\n \ndiff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c\nindex 89aa2ed..0d6babb 100644\n--- a/lib/librte_cryptodev/rte_cryptodev.c\n+++ b/lib/librte_cryptodev/rte_cryptodev.c\n@@ -173,6 +173,7 @@ const char *rte_crypto_asym_xform_strings[] = {\n \t[RTE_CRYPTO_ASYM_XFORM_MODINV]\t= \"modinv\",\n \t[RTE_CRYPTO_ASYM_XFORM_DH]\t= \"dh\",\n \t[RTE_CRYPTO_ASYM_XFORM_DSA]\t= \"dsa\",\n+\t[RTE_CRYPTO_ASYM_XFORM_ECDSA]\t= \"ecdsa\",\n };\n \n /**\n", "prefixes": [ "1/4" ] }