Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63542/?format=api
{ "id": 63542, "url": "http://patches.dpdk.org/api/patches/63542/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191203165928.74261-3-guinanx.sun@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191203165928.74261-3-guinanx.sun@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191203165928.74261-3-guinanx.sun@intel.com", "date": "2019-12-03T16:59:28", "name": "[2/2] net/ixgbe: set fixed flag for exact link speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dda32c9ea9510f5ed61c92a90f42c52ec375b3d0", "submitter": { "id": 1476, "url": "http://patches.dpdk.org/api/people/1476/?format=api", "name": "Guinan Sun", "email": "guinanx.sun@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191203165928.74261-3-guinanx.sun@intel.com/mbox/", "series": [ { "id": 7717, "url": "http://patches.dpdk.org/api/series/7717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7717", "date": "2019-12-03T16:59:26", "name": "drivers/net: set fixed flag for exact link speed", "version": 1, "mbox": "http://patches.dpdk.org/series/7717/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63542/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27007A04B5;\n\tTue, 3 Dec 2019 10:19:12 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09B632B8D;\n\tTue, 3 Dec 2019 10:19:12 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 74F11235\n for <dev@dpdk.org>; Tue, 3 Dec 2019 10:19:10 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 03 Dec 2019 01:19:09 -0800", "from intel.sh.intel.com ([10.239.255.32])\n by fmsmga001.fm.intel.com with ESMTP; 03 Dec 2019 01:19:07 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,272,1571727600\"; d=\"scan'208\";a=\"218590329\"", "From": "Guinan Sun <guinanx.sun@intel.com>", "To": "dev@dpdk.org", "Cc": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Beilei Xing <beilei.xing@intel.com>, Guinan Sun <guinanx.sun@intel.com>", "Date": "Tue, 3 Dec 2019 16:59:28 +0000", "Message-Id": "<20191203165928.74261-3-guinanx.sun@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191203165928.74261-1-guinanx.sun@intel.com>", "References": "<20191203165928.74261-1-guinanx.sun@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=y", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/ixgbe: set fixed flag for exact link\n\tspeed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Setting exact link speed makes sense if auto-negotiation is\ndisabled. Fixed flag is required to disable auto-negotiation.\n\nSigned-off-by: Guinan Sun <guinanx.sun@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 2c6fd0f13..e1ab1dcab 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2558,17 +2558,6 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\t/* IXGBE devices don't support:\n-\t* - half duplex (checked afterwards for valid speeds)\n-\t* - fixed speed: TODO implement\n-\t*/\n-\tif (dev->data->dev_conf.link_speeds & ETH_LINK_SPEED_FIXED) {\n-\t\tPMD_INIT_LOG(ERR,\n-\t\t\"Invalid link_speeds for port %u, fix speed not supported\",\n-\t\t\t\tdev->data->port_id);\n-\t\treturn -EINVAL;\n-\t}\n-\n \t/* Stop the link setup handler before resetting the HW. */\n \trte_eal_alarm_cancel(ixgbe_dev_setup_link_alarm_handler, dev);\n \n@@ -2724,7 +2713,11 @@ ixgbe_dev_start(struct rte_eth_dev *dev)\n \t}\n \n \tlink_speeds = &dev->data->dev_conf.link_speeds;\n-\tif (*link_speeds & ~allowed_speeds) {\n+\n+\t/* Ignore autoneg flag bit and check the validity of \n+\t * link_speed \n+\t */\n+\tif (((*link_speeds) >> 1) & ~(allowed_speeds >> 1)) {\n \t\tPMD_INIT_LOG(ERR, \"Invalid link setting\");\n \t\tgoto error;\n \t}\n@@ -4133,7 +4126,8 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tlink.link_status = ETH_LINK_DOWN;\n \tlink.link_speed = ETH_SPEED_NUM_NONE;\n \tlink.link_duplex = ETH_LINK_HALF_DUPLEX;\n-\tlink.link_autoneg = ETH_LINK_AUTONEG;\n+\tlink.link_autoneg = !(dev->data->dev_conf.link_speeds &\n+\t\t\tETH_LINK_SPEED_FIXED);\n \n \thw->mac.get_link_status = true;\n \n", "prefixes": [ "2/2" ] }