Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63534/?format=api
{ "id": 63534, "url": "http://patches.dpdk.org/api/patches/63534/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191203070318.39620-12-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191203070318.39620-12-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191203070318.39620-12-qi.z.zhang@intel.com", "date": "2019-12-03T07:03:12", "name": "[11/17] net/iavf/base: fix command buffer memory free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fd84514c3a781c9476734f9b307caaa8ae56e5d1", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191203070318.39620-12-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 7716, "url": "http://patches.dpdk.org/api/series/7716/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7716", "date": "2019-12-03T07:03:01", "name": "iavf base code update", "version": 1, "mbox": "http://patches.dpdk.org/series/7716/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63534/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63534/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34C08A04B5;\n\tTue, 3 Dec 2019 08:02:22 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7DBF71BFAE;\n\tTue, 3 Dec 2019 08:00:42 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id 105261BC25;\n Tue, 3 Dec 2019 08:00:32 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 02 Dec 2019 23:00:32 -0800", "from dpdk51.sh.intel.com ([10.67.110.245])\n by fmsmga005.fm.intel.com with ESMTP; 02 Dec 2019 23:00:31 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,272,1571727600\"; d=\"scan'208\";a=\"410729757\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "xiaolong.ye@intel.com", "Cc": "haiyue.wang@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n stable@dpdk.org, Maharajan Pandi Kumar <pandi.maharajan@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Tue, 3 Dec 2019 15:03:12 +0800", "Message-Id": "<20191203070318.39620-12-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20191203070318.39620-1-qi.z.zhang@intel.com>", "References": "<20191203070318.39620-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 11/17] net/iavf/base: fix command buffer memory\n\tfree", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Allocated resources were not freed in the event of failure in\niavf_init_asq function. This patch gracefully handles all failures.\n\nFixes: e5b2a9e957e7 (\"net/avf/base: add base code for avf PMD\")\nCc: stable@dpdk.org\n\nSigned-off-by: Maharajan Pandi Kumar <pandi.maharajan@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/iavf/base/iavf_adminq.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c\nindex ef352ac4c..298e77277 100644\n--- a/drivers/net/iavf/base/iavf_adminq.c\n+++ b/drivers/net/iavf/base/iavf_adminq.c\n@@ -82,6 +82,7 @@ enum iavf_status iavf_alloc_adminq_arq_ring(struct iavf_hw *hw)\n **/\n void iavf_free_adminq_asq(struct iavf_hw *hw)\n {\n+\tiavf_free_virt_mem(hw, &hw->aq.asq.cmd_buf);\n \tiavf_free_dma_mem(hw, &hw->aq.asq.desc_buf);\n }\n \n@@ -353,7 +354,7 @@ enum iavf_status iavf_init_asq(struct iavf_hw *hw)\n \t/* initialize base registers */\n \tret_code = iavf_config_asq_regs(hw);\n \tif (ret_code != IAVF_SUCCESS)\n-\t\tgoto init_adminq_free_rings;\n+\t\tgoto init_config_regs;\n \n \t/* success! */\n \thw->aq.asq.count = hw->aq.num_asq_entries;\n@@ -361,6 +362,10 @@ enum iavf_status iavf_init_asq(struct iavf_hw *hw)\n \n init_adminq_free_rings:\n \tiavf_free_adminq_asq(hw);\n+\treturn ret_code;\n+\n+init_config_regs:\n+\tiavf_free_asq_bufs(hw);\n \n init_adminq_exit:\n \treturn ret_code;\n", "prefixes": [ "11/17" ] }