Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63505/?format=api
{ "id": 63505, "url": "http://patches.dpdk.org/api/patches/63505/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191202154201.10721-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191202154201.10721-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191202154201.10721-1-david.marchand@redhat.com", "date": "2019-12-02T15:42:01", "name": "[2/4] eal: do not cache lcore detection state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2a33fadd19c656cdbb491d03de05c9a9a46b7cc6", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191202154201.10721-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 7707, "url": "http://patches.dpdk.org/api/series/7707/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7707", "date": "2019-12-02T15:35:55", "name": "Extend --lcores to run on cores > RTE_MAX_LCORE", "version": 1, "mbox": "http://patches.dpdk.org/series/7707/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63505/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64794A04B5;\n\tMon, 2 Dec 2019 16:42:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 025451BDFD;\n\tMon, 2 Dec 2019 16:42:11 +0100 (CET)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id DEC091BDFD\n for <dev@dpdk.org>; Mon, 2 Dec 2019 16:42:09 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-305-VCzHXVXpMEGFXzs7-hk_dA-1; Mon, 02 Dec 2019 10:42:08 -0500", "from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com\n [10.5.11.14])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 703531099BAF\n for <dev@dpdk.org>; Mon, 2 Dec 2019 15:42:07 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-205-88.brq.redhat.com [10.40.205.88])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 4ACDE5DA2C;\n Mon, 2 Dec 2019 15:42:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1575301329;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=RIHeK1j4oXPi6ZvVIBfd7V7RyeHhAv+KgjUpHAcFENA=;\n b=gQHZ/iB5Rb9aF4l+6CV+nOqudQnRgfHqvKG1bpLxUf/VDSUn5Do2OuMrQiRDNLqMv/rO1v\n AbVdP24IzIRhZ/sagd+sh0SFktkK6uX0MJDbRz+fYZ8YJ4ssIus+eLHX8viWExhfBGkJyd\n 9n64E3sN8bcd2VnY9J0iBZoEZ7OKY4c=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "aconole@redhat.com", "Date": "Mon, 2 Dec 2019 16:42:01 +0100", "Message-Id": "<20191202154201.10721-1-david.marchand@redhat.com>", "In-Reply-To": "<20191202153559.9709-1-david.marchand@redhat.com>", "References": "<20191202153559.9709-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.14", "X-MC-Unique": "VCzHXVXpMEGFXzs7-hk_dA-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 2/4] eal: do not cache lcore detection state", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We use this state in control path only for services cores and -c/-l\noptions.\nThe value is not updated when using --lcores.\n\nUse the internal helper where needed.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/eal_common_lcore.c | 4 +---\n lib/librte_eal/common/eal_common_options.c | 10 +++++-----\n lib/librte_eal/common/eal_private.h | 1 -\n 3 files changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c\nindex 39efadef1a..1d16fb2156 100644\n--- a/lib/librte_eal/common/eal_common_lcore.c\n+++ b/lib/librte_eal/common/eal_common_lcore.c\n@@ -139,9 +139,7 @@ rte_eal_cpu_init(void)\n \t\tsocket_id = eal_cpu_socket_id(lcore_id);\n \t\tlcore_to_socket_id[lcore_id] = socket_id;\n \n-\t\t/* in 1:1 mapping, record related cpu detected state */\n-\t\tlcore_config[lcore_id].detected = eal_cpu_detected(lcore_id);\n-\t\tif (lcore_config[lcore_id].detected == 0) {\n+\t\tif (eal_cpu_detected(lcore_id) == 0) {\n \t\t\tconfig->lcore_role[lcore_id] = ROLE_OFF;\n \t\t\tlcore_config[lcore_id].core_index = -1;\n \t\t\tcontinue;\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex a7f9c5f9bd..68f7d1cd73 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -373,7 +373,7 @@ eal_parse_service_coremask(const char *coremask)\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \n-\t\t\t\tif (!lcore_config[idx].detected) {\n+\t\t\t\tif (eal_cpu_detected(idx) == 0) {\n \t\t\t\t\tRTE_LOG(ERR, EAL,\n \t\t\t\t\t\t\"lcore %u unavailable\\n\", idx);\n \t\t\t\t\treturn -1;\n@@ -429,7 +429,7 @@ update_lcore_config(int *cores)\n \n \tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n \t\tif (cores[i] != -1) {\n-\t\t\tif (!lcore_config[i].detected) {\n+\t\t\tif (eal_cpu_detected(i) == 0) {\n \t\t\t\tRTE_LOG(ERR, EAL, \"lcore %u unavailable\\n\", i);\n \t\t\t\tret = -1;\n \t\t\t\tcontinue;\n@@ -785,7 +785,7 @@ convert_to_cpuset(rte_cpuset_t *cpusetp,\n \t\tif (!set[idx])\n \t\t\tcontinue;\n \n-\t\tif (!lcore_config[idx].detected) {\n+\t\tif (eal_cpu_detected(idx) == 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"core %u \"\n \t\t\t\t\"unavailable\\n\", idx);\n \t\t\treturn -1;\n@@ -1138,7 +1138,7 @@ available_cores(void)\n \n \t/* find the first available cpu */\n \tfor (idx = 0; idx < RTE_MAX_LCORE; idx++) {\n-\t\tif (!lcore_config[idx].detected)\n+\t\tif (eal_cpu_detected(idx) == 0)\n \t\t\tcontinue;\n \t\tbreak;\n \t}\n@@ -1152,7 +1152,7 @@ available_cores(void)\n \tsequence = 0;\n \n \tfor (idx++ ; idx < RTE_MAX_LCORE; idx++) {\n-\t\tif (!lcore_config[idx].detected)\n+\t\tif (eal_cpu_detected(idx) == 0)\n \t\t\tcontinue;\n \n \t\tif (idx == previous + 1) {\ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 8a9d493f0c..ddcfbe2e44 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -29,7 +29,6 @@ struct lcore_config {\n \tunsigned int core_id; /**< core number on socket for this lcore */\n \tint core_index; /**< relative index, starting from 0 */\n \tuint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */\n-\tuint8_t detected; /**< true if lcore was detected */\n \n \trte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */\n };\n", "prefixes": [ "2/4" ] }