Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63481/?format=api
{ "id": 63481, "url": "http://patches.dpdk.org/api/patches/63481/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191202074935.97629-57-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191202074935.97629-57-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191202074935.97629-57-xiaolong.ye@intel.com", "date": "2019-12-02T07:49:22", "name": "[56/69] net/i40e/base: add CRC stripping capability", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e2704e98b79ee67cf218433617eb2818cee6aea0", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191202074935.97629-57-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 7701, "url": "http://patches.dpdk.org/api/series/7701/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7701", "date": "2019-12-02T07:48:26", "name": "update for i40e base code", "version": 1, "mbox": "http://patches.dpdk.org/series/7701/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63481/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/63481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C47FA04B5;\n\tMon, 2 Dec 2019 09:06:31 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 707E41C11A;\n\tMon, 2 Dec 2019 08:59:18 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by dpdk.org (Postfix) with ESMTP id 333891C0C8\n for <dev@dpdk.org>; Mon, 2 Dec 2019 08:59:08 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 01 Dec 2019 23:59:07 -0800", "from dpdk_yexl_af_xdp.sh.intel.com ([10.67.119.186])\n by fmsmga008.fm.intel.com with ESMTP; 01 Dec 2019 23:59:06 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,268,1571727600\"; d=\"scan'208\";a=\"207993690\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>", "Cc": "dev@dpdk.org, Xiaolong Ye <xiaolong.ye@intel.com>,\n Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 2 Dec 2019 15:49:22 +0800", "Message-Id": "<20191202074935.97629-57-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191202074935.97629-1-xiaolong.ye@intel.com>", "References": "<20191202074935.97629-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH 56/69] net/i40e/base: add CRC stripping capability", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some VFs may want to disable CRC stripping on incoming packets\nso create an offload for that. The VF already sends information\nabout configuring it's RX queues so use that structure to\nindicate that the CRC stripping should be enabled or not.\n\nThis change is to support DCR 2685 \"Enable/disable CRC\nstripping for DPDK VFs\"\n\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nReviewed-by: Keller Jacob E <jacob.e.keller@intel.com>\nReviewed-by: Kirsher Jeffrey T <jeffrey.t.kirsher@intel.com>\nReviewed-by: Yang Lihong <lihong.yang@intel.com>\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/base/virtchnl.h | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/virtchnl.h b/drivers/net/i40e/base/virtchnl.h\nindex f659fbcab..0ea03d06b 100644\n--- a/drivers/net/i40e/base/virtchnl.h\n+++ b/drivers/net/i40e/base/virtchnl.h\n@@ -238,6 +238,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, virtchnl_vsi_resource);\n #define VIRTCHNL_VF_OFFLOAD_RSS_REG\t\t0x00000010\n #define VIRTCHNL_VF_OFFLOAD_WB_ON_ITR\t\t0x00000020\n #define VIRTCHNL_VF_OFFLOAD_REQ_QUEUES\t\t0x00000040\n+#define VIRTCHNL_VF_OFFLOAD_CRC\t\t\t0x00000080\n #define VIRTCHNL_VF_OFFLOAD_VLAN\t\t0x00010000\n #define VIRTCHNL_VF_OFFLOAD_RX_POLLING\t\t0x00020000\n #define VIRTCHNL_VF_OFFLOAD_RSS_PCTYPE_V2\t0x00040000\n@@ -289,7 +290,13 @@ VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_txq_info);\n /* VIRTCHNL_OP_CONFIG_RX_QUEUE\n * VF sends this message to set up parameters for one RX queue.\n * External data buffer contains one instance of virtchnl_rxq_info.\n- * PF configures requested queue and returns a status code.\n+ * PF configures requested queue and returns a status code. The\n+ * crc_disable flag disables CRC stripping on the VF. Setting\n+ * the crc_disable flag to 1 will disable CRC stripping for each\n+ * queue in the VF where the flag is set. The VIRTCHNL_VF_OFFLOAD_CRC\n+ * offload must have been set prior to sending this info or the PF\n+ * will ignore the request. This flag should be set the same for\n+ * all of the queues for a VF.\n */\n \n /* Rx queue config info */\n@@ -301,7 +308,8 @@ struct virtchnl_rxq_info {\n \tu16 splithdr_enabled; /* deprecated with AVF 1.0 */\n \tu32 databuffer_size;\n \tu32 max_pkt_size;\n-\tu32 pad1;\n+\tu8 crc_disable;\n+\tu8 pad1[3];\n \tu64 dma_ring_addr;\n \tenum virtchnl_rx_hsplit rx_split_pos; /* deprecated with AVF 1.0 */\n \tu32 pad2;\n", "prefixes": [ "56/69" ] }