Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63423/?format=api
{ "id": 63423, "url": "http://patches.dpdk.org/api/patches/63423/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191202041809.18370-2-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191202041809.18370-2-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191202041809.18370-2-kalesh-anakkur.purayil@broadcom.com", "date": "2019-12-02T04:18:07", "name": "[1/3] net/bnxt: rework code to select chip type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "543bf417e7f0af31231d85a8b76ab4818943a36d", "submitter": { "id": 1479, "url": "http://patches.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191202041809.18370-2-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 7698, "url": "http://patches.dpdk.org/api/series/7698/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7698", "date": "2019-12-02T04:18:06", "name": "updates for bnxt PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/7698/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63423/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00429A04B5;\n\tMon, 2 Dec 2019 05:06:57 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A6E04CA6;\n\tMon, 2 Dec 2019 05:06:50 +0100 (CET)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id F31CF1F28\n for <dev@dpdk.org>; Mon, 2 Dec 2019 05:06:47 +0100 (CET)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id 1967E28F85B;\n Sun, 1 Dec 2019 20:06:47 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 1967E28F85B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1575259607;\n bh=9yt/Sd1J4UmSIeep3wG1A/QXof/yV2E0Q3pjCnOu7Ag=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=AXR3tP+l9LuCVfHcLOxeJlKaSV5iS/9pLLY5FsoRGwDp0NkItWCuRBunUWh+p1s1F\n F1UaR17Tzv+hrehRHdGvS5ZuJFdatNxn9Y3CPmO6pBkgsZ1+5Boh/KpSLZ6rdfd2cI\n Foim9c5JA/560lKFVuTd1Og+s4KfER9YAxlyZRZo=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tajit.khaparde@broadcom.com", "Date": "Mon, 2 Dec 2019 09:48:07 +0530", "Message-Id": "<20191202041809.18370-2-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20191202041809.18370-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20191202041809.18370-1-kalesh-anakkur.purayil@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 1/3] net/bnxt: rework code to select chip type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nUse switch-case statement to replace if-else statement.\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 73 ++++++++++++++++++++++++------------------\n 1 file changed, 42 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 41848f3..081bb46 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4028,49 +4028,60 @@ static void bnxt_cancel_fw_health_check(struct bnxt *bp)\n \tbp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;\n }\n \n-static bool bnxt_vf_pciid(uint16_t id)\n+static bool bnxt_vf_pciid(uint16_t device_id)\n {\n-\tif (id == BROADCOM_DEV_ID_57304_VF ||\n-\t id == BROADCOM_DEV_ID_57406_VF ||\n-\t id == BROADCOM_DEV_ID_5731X_VF ||\n-\t id == BROADCOM_DEV_ID_5741X_VF ||\n-\t id == BROADCOM_DEV_ID_57414_VF ||\n-\t id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||\n-\t id == BROADCOM_DEV_ID_STRATUS_NIC_VF2 ||\n-\t id == BROADCOM_DEV_ID_58802_VF ||\n-\t id == BROADCOM_DEV_ID_57500_VF1 ||\n-\t id == BROADCOM_DEV_ID_57500_VF2)\n+\tswitch (device_id) {\n+\tcase BROADCOM_DEV_ID_57304_VF:\n+\tcase BROADCOM_DEV_ID_57406_VF:\n+\tcase BROADCOM_DEV_ID_5731X_VF:\n+\tcase BROADCOM_DEV_ID_5741X_VF:\n+\tcase BROADCOM_DEV_ID_57414_VF:\n+\tcase BROADCOM_DEV_ID_STRATUS_NIC_VF1:\n+\tcase BROADCOM_DEV_ID_STRATUS_NIC_VF2:\n+\tcase BROADCOM_DEV_ID_58802_VF:\n+\tcase BROADCOM_DEV_ID_57500_VF1:\n+\tcase BROADCOM_DEV_ID_57500_VF2:\n+\t\t/* FALLTHROUGH */\n \t\treturn true;\n-\treturn false;\n+\tdefault:\n+\t\treturn false;\n+\t}\n }\n \n-static bool bnxt_thor_device(uint16_t id)\n+static bool bnxt_thor_device(uint16_t device_id)\n {\n-\tif (id == BROADCOM_DEV_ID_57508 ||\n-\t id == BROADCOM_DEV_ID_57504 ||\n-\t id == BROADCOM_DEV_ID_57502 ||\n-\t id == BROADCOM_DEV_ID_57508_MF1 ||\n-\t id == BROADCOM_DEV_ID_57504_MF1 ||\n-\t id == BROADCOM_DEV_ID_57502_MF1 ||\n-\t id == BROADCOM_DEV_ID_57508_MF2 ||\n-\t id == BROADCOM_DEV_ID_57504_MF2 ||\n-\t id == BROADCOM_DEV_ID_57502_MF2 ||\n-\t id == BROADCOM_DEV_ID_57500_VF1 ||\n-\t id == BROADCOM_DEV_ID_57500_VF2)\n+\tswitch (device_id) {\n+\tcase BROADCOM_DEV_ID_57508:\n+\tcase BROADCOM_DEV_ID_57504:\n+\tcase BROADCOM_DEV_ID_57502:\n+\tcase BROADCOM_DEV_ID_57508_MF1:\n+\tcase BROADCOM_DEV_ID_57504_MF1:\n+\tcase BROADCOM_DEV_ID_57502_MF1:\n+\tcase BROADCOM_DEV_ID_57508_MF2:\n+\tcase BROADCOM_DEV_ID_57504_MF2:\n+\tcase BROADCOM_DEV_ID_57502_MF2:\n+\tcase BROADCOM_DEV_ID_57500_VF1:\n+\tcase BROADCOM_DEV_ID_57500_VF2:\n+\t\t/* FALLTHROUGH */\n \t\treturn true;\n-\n-\treturn false;\n+\tdefault:\n+\t\treturn false;\n+\t}\n }\n \n bool bnxt_stratus_device(struct bnxt *bp)\n {\n-\tuint16_t id = bp->pdev->id.device_id;\n+\tuint16_t device_id = bp->pdev->id.device_id;\n \n-\tif (id == BROADCOM_DEV_ID_STRATUS_NIC ||\n-\t id == BROADCOM_DEV_ID_STRATUS_NIC_VF1 ||\n-\t id == BROADCOM_DEV_ID_STRATUS_NIC_VF2)\n+\tswitch (device_id) {\n+\tcase BROADCOM_DEV_ID_STRATUS_NIC:\n+\tcase BROADCOM_DEV_ID_STRATUS_NIC_VF1:\n+\tcase BROADCOM_DEV_ID_STRATUS_NIC_VF2:\n+\t\t/* FALLTHROUGH */\n \t\treturn true;\n-\treturn false;\n+\tdefault:\n+\t\treturn false;\n+\t}\n }\n \n static int bnxt_init_board(struct rte_eth_dev *eth_dev)\n", "prefixes": [ "1/3" ] }