Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6342,
    "url": "http://patches.dpdk.org/api/patches/6342/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2015-07-13T09:02:29",
    "name": "[dpdk-dev] mk: fix shared lib build with stable abi",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "551d9fb44fad4ce371020b6eca9c20d36283a089",
    "submitter": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/6342/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/6342/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EAE345A44;\n\tMon, 13 Jul 2015 11:03:57 +0200 (CEST)",
            "from mail-wg0-f53.google.com (mail-wg0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id D229C5934\n\tfor <dev@dpdk.org>; Mon, 13 Jul 2015 11:03:55 +0200 (CEST)",
            "by wgjx7 with SMTP id x7so290448502wgj.2\n\tfor <dev@dpdk.org>; Mon, 13 Jul 2015 02:03:55 -0700 (PDT)",
            "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by smtp.gmail.com with ESMTPSA id\n\tda5sm13406045wib.6.2015.07.13.02.03.54\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 13 Jul 2015 02:03:54 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=s5Z8FJCdSjnnxShLwywHDFU9/JVMqCCF+9dB2Iiu/X8=;\n\tb=aoiQ7hisUQEcTrGismYhxJTX+KNNgudsF7pyU0Cnewe9UI5jFV81Dkb0B/DXIl6YtZ\n\tnGOQ2YbO63WdNVdNxswY9+9oL6m4Pd5JBX2ZIsPXFiRUeoCv/T+sLltOVb6JGYmrKrVK\n\tBtv6YAFwYXNeLBAwSAFHJ2epPbFukziaIWYoHEyR5kTw9abkLrpaVjtnk8Tg1ALRYGlh\n\tV4Kjl8dGjGkB1zExZQ5AbxsxYNTTMaH9P7cPemJVfDX8HLwHCWln70D1DTKUbrZ/m0nE\n\tG28wpKNv5JQWpsE9154S8CKZkys08vHgwMH83h+2yc7YSTCg5zGrab4f90BkmZUO9HPO\n\t9YXA==",
        "X-Gm-Message-State": "ALoCoQl3Ny5feG6SvJw91qkwQMLtZRMzqWX3kFhF3Pa51bSEtJH+ir+otA4F74JgeRPfCWdBfrwJ",
        "X-Received": "by 10.180.88.196 with SMTP id bi4mr21365671wib.70.1436778235669; \n\tMon, 13 Jul 2015 02:03:55 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "John McNamara <john.mcnamara@intel.com>",
        "Date": "Mon, 13 Jul 2015 11:02:29 +0200",
        "Message-Id": "<1436778149-18811-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.4.2",
        "In-Reply-To": "<1531097.HZDUsMDq83@xps13>",
        "References": "<1531097.HZDUsMDq83@xps13>",
        "Cc": "dev@dpdk.org",
        "Subject": "[dpdk-dev] [PATCH] mk: fix shared lib build with stable abi",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When next ABI is enabled, the shared lib extension is .so.x.1.\nThat's why a double basename was introduced.\nBut the \"ifeq NEXT_ABI\" was forgotten, removing the .so\nextension when NEXT_ABI is disabled.\nIt was preventing the linker from finding the .so libraries.\n\nFixes: 506f51cc0da7 (\"mk: enable next abi preview\")\n\nReported-by: John McNamara <john.mcnamara@intel.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.lib.mk | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk\nindex f15de9b..9ff5cce 100644\n--- a/mk/rte.lib.mk\n+++ b/mk/rte.lib.mk\n@@ -173,7 +173,11 @@ $(RTE_OUTPUT)/lib/$(LIB): $(LIB)\n \t@[ -d $(RTE_OUTPUT)/lib ] || mkdir -p $(RTE_OUTPUT)/lib\n \t$(Q)cp -f $(LIB) $(RTE_OUTPUT)/lib\n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)\n+ifeq ($(CONFIG_RTE_NEXT_ABI),y)\n \t$(Q)ln -s -f $< $(basename $(basename $@))\n+else\n+\t$(Q)ln -s -f $< $(basename $@)\n+endif\n endif\n \n #\n",
    "prefixes": [
        "dpdk-dev"
    ]
}