Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63238/?format=api
{ "id": 63238, "url": "http://patches.dpdk.org/api/patches/63238/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-4-xavier.huwei@tom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191122120624.4963-4-xavier.huwei@tom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191122120624.4963-4-xavier.huwei@tom.com", "date": "2019-11-22T12:06:21", "name": "[3/6] net/hns3: fix the failure sending packets less than 60 bytes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "45e119a1fdf5cdd5fd8705a273a6ca268e4be231", "submitter": { "id": 1459, "url": "http://patches.dpdk.org/api/people/1459/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@tom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-4-xavier.huwei@tom.com/mbox/", "series": [ { "id": 7586, "url": "http://patches.dpdk.org/api/series/7586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7586", "date": "2019-11-22T12:06:18", "name": "Fixes for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/7586/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63238/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B33BA04C3;\n\tFri, 22 Nov 2019 15:16:49 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9F7505B3E;\n\tFri, 22 Nov 2019 15:16:02 +0100 (CET)", "from smtp.tom.com (smtprz14.163.net [106.3.154.247])\n by dpdk.org (Postfix) with ESMTP id 4A48C2C08\n for <dev@dpdk.org>; Fri, 22 Nov 2019 13:17:44 +0100 (CET)", "from my-app01.tom.com (my-app01.tom.com [127.0.0.1])\n by freemail01.tom.com (Postfix) with ESMTP id 042181C81A49\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1])\n by my-app01 (TOM SMTP Server) with SMTP ID -604769835\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from antispam1.tom.com (unknown [172.25.16.55])\n by freemail01.tom.com (Postfix) with ESMTP id 005841C81A1F\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:37 +0800 (CST)", "from antispam1.tom.com (antispam1.tom.com [127.0.0.1])\n by antispam1.tom.com (Postfix) with ESMTP id 0467B1001873\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:09 +0800 (CST)", "from antispam1.tom.com ([127.0.0.1])\n by antispam1.tom.com (antispam1.tom.com [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id aBIi5DL8IbvQ for <dev@dpdk.org>;\n Fri, 22 Nov 2019 20:06:08 +0800 (CST)", "from localhost.localdomain (unknown [203.160.91.226])\n by antispam1.tom.com (Postfix) with ESMTPA id C436710017BC;\n Fri, 22 Nov 2019 20:06:07 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807;\n t=1574424398; bh=7W4WK+qM7clPkaCnQs3bArPuBbKunpoExc59NEdMfBg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=epGjeJzaCaAzGtvr2xauAVDOaqz5cza7kp5L5wz3EMDEOebzuOD0zRBl2vv87VEo8\n q3iKYS4TOPMub441la+2YeRNjxKcjYlMcNu9ujm3DxlfW5Jh37mA9l4DduP3UgGICY\n 3SSlRsTtI2u5PDtiAdh6BMDAgQepN6EKLYO+v6jI=", "X-Virus-Scanned": "Debian amavisd-new at antispam1.tom.com", "From": "\"Wei Hu (Xavier)\" <xavier.huwei@tom.com>", "To": "dev@dpdk.org,\n\tstable@dpdk.org", "Cc": "xavier_huwei@163.com,\n\txavier.huwei@tom.com,\n\thuwei87@hisilicon.com", "Date": "Fri, 22 Nov 2019 20:06:21 +0800", "Message-Id": "<20191122120624.4963-4-xavier.huwei@tom.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191122120624.4963-1-xavier.huwei@tom.com>", "References": "<20191122120624.4963-1-xavier.huwei@tom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 22 Nov 2019 15:15:52 +0100", "Subject": "[dpdk-dev] [PATCH 3/6] net/hns3: fix the failure sending packets\n\tless than 60 bytes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier_huwei@163.com>\n\nEthernet minimum packet length is 64 bytes. If upper application\nsends packets with less than 60 bytes in length(no CRC), driver\nadds padding processing to avoid failure.\n\nFixes: bba636698316 (\"net/hns3: support Rx/Tx and related operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier_huwei@163.com>\n---\n drivers/net/hns3/hns3_ethdev.h | 1 +\n drivers/net/hns3/hns3_rxtx.c | 24 ++++++++++++++++++++----\n 2 files changed, 21 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 9710e45fb..e9a3fe410 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -43,6 +43,7 @@\n #define HNS3_MAX_MTU\t(HNS3_MAX_FRAME_LEN - HNS3_ETH_OVERHEAD)\n #define HNS3_DEFAULT_MTU\t\t1500UL\n #define HNS3_DEFAULT_FRAME_LEN\t\t(HNS3_DEFAULT_MTU + HNS3_ETH_OVERHEAD)\n+#define HNS3_MIN_PKT_SIZE\t\t60\n \n #define HNS3_4_TCS\t\t\t4\n #define HNS3_8_TCS\t\t\t8\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 1de238b4c..34cb7faf9 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -1598,13 +1598,29 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t}\n \n \t\t/*\n-\t\t * If the length of the packet is too long or zero, the packet\n-\t\t * will be ignored.\n+\t\t * If packet length is greater than HNS3_MAX_FRAME_LEN\n+\t\t * driver support, the packet will be ignored.\n \t\t */\n-\t\tif (unlikely(tx_pkt->pkt_len > HNS3_MAX_FRAME_LEN ||\n-\t\t\t tx_pkt->pkt_len == 0))\n+\t\tif (unlikely(rte_pktmbuf_pkt_len(tx_pkt) > HNS3_MAX_FRAME_LEN))\n \t\t\tbreak;\n \n+\t\t/*\n+\t\t * If packet length is less than minimum packet size, driver\n+\t\t * need to pad it.\n+\t\t */\n+\t\tif (unlikely(rte_pktmbuf_pkt_len(tx_pkt) < HNS3_MIN_PKT_SIZE)) {\n+\t\t\tuint16_t add_len;\n+\t\t\tchar *appended;\n+\n+\t\t\tadd_len = HNS3_MIN_PKT_SIZE -\n+\t\t\t\t\t rte_pktmbuf_pkt_len(tx_pkt);\n+\t\t\tappended = rte_pktmbuf_append(tx_pkt, add_len);\n+\t\t\tif (appended == NULL)\n+\t\t\t\tbreak;\n+\n+\t\t\tmemset(appended, 0, add_len);\n+\t\t}\n+\n \t\tm_seg = tx_pkt;\n \t\tif (unlikely(nb_buf > HNS3_MAX_TX_BD_PER_PKT)) {\n \t\t\tif (hns3_reassemble_tx_pkts(txq, tx_pkt, &new_pkt))\n", "prefixes": [ "3/6" ] }