Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63234/?format=api
{ "id": 63234, "url": "http://patches.dpdk.org/api/patches/63234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-3-xavier.huwei@tom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191122120624.4963-3-xavier.huwei@tom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191122120624.4963-3-xavier.huwei@tom.com", "date": "2019-11-22T12:06:20", "name": "[2/6] net/hns3: fix VF configuration table entries restore failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c04ebf6db458fbe9ac7a408fa079f127cbbb0e5d", "submitter": { "id": 1459, "url": "http://patches.dpdk.org/api/people/1459/?format=api", "name": "Wei Hu (Xavier)", "email": "xavier.huwei@tom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191122120624.4963-3-xavier.huwei@tom.com/mbox/", "series": [ { "id": 7586, "url": "http://patches.dpdk.org/api/series/7586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7586", "date": "2019-11-22T12:06:18", "name": "Fixes for hns3 PMD driver", "version": 1, "mbox": "http://patches.dpdk.org/series/7586/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63234/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7BAC8A04C3;\n\tFri, 22 Nov 2019 15:16:10 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0B7F22BBB;\n\tFri, 22 Nov 2019 15:15:56 +0100 (CET)", "from smtp.tom.com (smtprz14.163.net [106.3.154.247])\n by dpdk.org (Postfix) with ESMTP id 751F82C30\n for <dev@dpdk.org>; Fri, 22 Nov 2019 13:06:35 +0100 (CET)", "from my-app01.tom.com (my-app01.tom.com [127.0.0.1])\n by freemail01.tom.com (Postfix) with ESMTP id 1C5D11C81A77\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from my-app01.tom.com (HELO smtp.tom.com) ([127.0.0.1])\n by my-app01 (TOM SMTP Server) with SMTP ID 97149650\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from antispam1.tom.com (unknown [172.25.16.55])\n by freemail01.tom.com (Postfix) with ESMTP id 112F41C81A5C\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:38 +0800 (CST)", "from antispam1.tom.com (antispam1.tom.com [127.0.0.1])\n by antispam1.tom.com (Postfix) with ESMTP id 0771D1001891\n for <dev@dpdk.org>; Fri, 22 Nov 2019 20:06:09 +0800 (CST)", "from antispam1.tom.com ([127.0.0.1])\n by antispam1.tom.com (antispam1.tom.com [127.0.0.1]) (amavisd-new,\n port 10024)\n with ESMTP id SrTQlVLqqZzK for <dev@dpdk.org>;\n Fri, 22 Nov 2019 20:06:07 +0800 (CST)", "from localhost.localdomain (unknown [203.160.91.226])\n by antispam1.tom.com (Postfix) with ESMTPA id 530BC1001124;\n Fri, 22 Nov 2019 20:06:07 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=201807;\n t=1574424398; bh=gVi1+1bGincgaANiQdx/VF/31GeCmaMYNcw9BxVOZg0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=SSVx8qjlVAjT3U2nSRmMzV8UZITKN+pW+ci4RMxvaSn5R9w1fhirCw3XVQ/Q1wGvy\n 4iaIRMlqQvSFYj+GlfOAPaAWDqSuryFHwmgVP3mVAf3dVgrZBnAyi9t20uo0hiWWqE\n OLBaRxzuEec/zIkLpFZBzGLXj9BjDuAtPtKTKi9Q=", "X-Virus-Scanned": "Debian amavisd-new at antispam1.tom.com", "From": "\"Wei Hu (Xavier)\" <xavier.huwei@tom.com>", "To": "dev@dpdk.org,\n\tstable@dpdk.org", "Cc": "xavier_huwei@163.com,\n\txavier.huwei@tom.com,\n\thuwei87@hisilicon.com", "Date": "Fri, 22 Nov 2019 20:06:20 +0800", "Message-Id": "<20191122120624.4963-3-xavier.huwei@tom.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191122120624.4963-1-xavier.huwei@tom.com>", "References": "<20191122120624.4963-1-xavier.huwei@tom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Fri, 22 Nov 2019 15:15:52 +0100", "Subject": "[dpdk-dev] [PATCH 2/6] net/hns3: fix VF configuration table entries\n\trestore failure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: \"Wei Hu (Xavier)\" <xavier_huwei@163.com>\n\nWhen the application using VF device exits abnormally, for example,\nwhen it is killed by 'kill -9', kernel PF netdev driver also stores\nthe corresponding configuration table entries of VF device.\n\nThis patch fixes it by adding message of deleting VF configuration\ntable entry corresponds to the revision of kernel hns3 netdev\ndriver, the new message is added to notify the kernel PF netdev\ndriver to clean up the VF configuration initialization during VF\ninitialization.\n\nThis revision is compatible with the old version of kernel hns3\nnetdev driver. The old version of kernel pf netdev driver will\nignore this message.\n\nFixes: a5475d61fa34 (\"net/hns3: support VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Wei Hu (Xavier) <xavier_huwei@163.com>\n---\n drivers/net/hns3/hns3_ethdev_vf.c | 14 ++++++++++++++\n drivers/net/hns3/hns3_mbx.h | 6 ++++++\n 2 files changed, 20 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 403674969..2274ac35e 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1096,6 +1096,14 @@ hns3vf_init_hardware(struct hns3_adapter *hns)\n \treturn ret;\n }\n \n+static int\n+hns3vf_clear_vport_list(struct hns3_hw *hw)\n+{\n+\treturn hns3_send_mbx_msg(hw, HNS3_MBX_HANDLE_VF_TBL,\n+\t\t\t\t HNS3_MBX_VPORT_LIST_CLEAR, NULL, 0, false,\n+\t\t\t\t NULL, 0);\n+}\n+\n static int\n hns3vf_init_vf(struct rte_eth_dev *eth_dev)\n {\n@@ -1147,6 +1155,12 @@ hns3vf_init_vf(struct rte_eth_dev *eth_dev)\n \n \trte_eth_random_addr(hw->mac.mac_addr); /* Generate a random mac addr */\n \n+\tret = hns3vf_clear_vport_list(hw);\n+\tif (ret) {\n+\t\tPMD_INIT_LOG(ERR, \"Failed to clear tbl list: %d\", ret);\n+\t\tgoto err_get_config;\n+\t}\n+\n \tret = hns3vf_init_hardware(hns);\n \tif (ret)\n \t\tgoto err_get_config;\ndiff --git a/drivers/net/hns3/hns3_mbx.h b/drivers/net/hns3/hns3_mbx.h\nindex ee6e82314..01eddb845 100644\n--- a/drivers/net/hns3/hns3_mbx.h\n+++ b/drivers/net/hns3/hns3_mbx.h\n@@ -39,6 +39,8 @@ enum HNS3_MBX_OPCODE {\n \tHNS3_MBX_SET_ALIVE, /* (VF -> PF) set alive state */\n \tHNS3_MBX_SET_MTU, /* (VF -> PF) set mtu */\n \tHNS3_MBX_GET_QID_IN_PF, /* (VF -> PF) get queue id in pf */\n+\n+\tHNS3_MBX_HANDLE_VF_TBL = 38, /* (VF -> PF) store/clear hw cfg tbl */\n };\n \n /* below are per-VF mac-vlan subcodes */\n@@ -58,6 +60,10 @@ enum hns3_mbx_vlan_cfg_subcode {\n \tHNS3_MBX_VLAN_RX_OFF_CFG, /* set rx side vlan offload */\n };\n \n+enum hns3_mbx_tbl_cfg_subcode {\n+\tHNS3_MBX_VPORT_LIST_CLEAR = 0,\n+};\n+\n #define HNS3_MBX_MAX_MSG_SIZE\t16\n #define HNS3_MBX_MAX_RESP_DATA_SIZE\t8\n #define HNS3_MBX_RING_MAP_BASIC_MSG_NUM\t3\n", "prefixes": [ "2/6" ] }