Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63212/?format=api
{ "id": 63212, "url": "http://patches.dpdk.org/api/patches/63212/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191121192240.12326-2-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191121192240.12326-2-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191121192240.12326-2-pbhagavatula@marvell.com", "date": "2019-11-21T19:22:39", "name": "[2/2] app/test-evnetdev: fix unchecked return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8802ecde31dc49550a9b752a497700a074d4948b", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191121192240.12326-2-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 7574, "url": "http://patches.dpdk.org/api/series/7574/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7574", "date": "2019-11-21T19:22:38", "name": "[1/2] app/test-eventdev: fix possible divide by zero", "version": 1, "mbox": "http://patches.dpdk.org/series/7574/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63212/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD3C2A04C1;\n\tThu, 21 Nov 2019 20:22:58 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 149DB2BE2;\n\tThu, 21 Nov 2019 20:22:50 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C3AD8237;\n Thu, 21 Nov 2019 20:22:47 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xALJKbmP019966; Thu, 21 Nov 2019 11:22:47 -0800", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 2wc842fbhv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Thu, 21 Nov 2019 11:22:46 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 21 Nov\n 2019 11:22:45 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Thu, 21 Nov 2019 11:22:45 -0800", "from BG-LT7430.marvell.com (unknown [10.28.17.72])\n by maili.marvell.com (Postfix) with ESMTP id 5E9703F703F;\n Thu, 21 Nov 2019 11:22:44 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=rV+AZaONdAAdYJgIMmHixWVSC69wyKihsOzzJVnpiog=;\n b=lY2tD6LvGFcW1ZU3ezjDt9ZsBhzEmMdPXLeU27MoKjUIrWpPwspf8sQ14r+AD1Xw11zL\n UbuIQxDbUOusBjPTZa2yYzDTEC14MQnScFjsG3QbT3mseYq9FOw4asaGsnsA8xYEA41K\n 8K23WHAP8IsB9cWyJgFTut0jG25ooL3FYP1Xir0rQLFRne1BfaFTzYrkVFWZ4Z5fINEp\n yebxrSB+esAm3Vbgpof4XTq3xq8i37laWHkm9ovHkOqnGK4+ndnUOVb4C4lO2+eM0DGb\n pewNop7OJaq4CLqW4mXinUi8m9bY7G9RbPSx+YprD6YaifGjPer05Wxrqzbo7DAMo9lr Lg==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>,\n <stable@dpdk.org>", "Date": "Fri, 22 Nov 2019 00:52:39 +0530", "Message-ID": "<20191121192240.12326-2-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191121192240.12326-1-pbhagavatula@marvell.com>", "References": "<20191121192240.12326-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-11-21_05:2019-11-21,2019-11-21 signatures=0", "Subject": "[dpdk-dev] [PATCH 2/2] app/test-evnetdev: fix unchecked return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nFix unchecked return values reported by coverity.\n\nCoverity Issue: 336861\nCoverity Issue: 349906\nFixes: 032a965a8f1d (\"app/eventdev: support Tx adapter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n app/test-eventdev/test_pipeline_common.c | 17 ++++++++++++++---\n 1 file changed, 14 insertions(+), 3 deletions(-)\n\n--\n2.17.1", "diff": "diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c\nindex 160461fb2..fa91bf229 100644\n--- a/app/test-eventdev/test_pipeline_common.c\n+++ b/app/test-eventdev/test_pipeline_common.c\n@@ -196,7 +196,12 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)\n \t\tstruct rte_eth_conf local_port_conf = port_conf;\n \t\tuint32_t caps = 0;\n\n-\t\trte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);\n+\t\tret = rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);\n+\t\tif (ret != 0) {\n+\t\t\tevt_err(\"failed to get event tx adapter[%d] caps\", i);\n+\t\t\treturn ret;\n+\t\t}\n+\n \t\tif (!(caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT))\n \t\t\tt->internal_port = 0;\n\n@@ -424,7 +429,7 @@ int\n pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)\n {\n \tstruct test_pipeline *t = evt_test_priv(test);\n-\tint i;\n+\tint i, ret;\n\n \tif (!opt->mbuf_sz)\n \t\topt->mbuf_sz = RTE_MBUF_DEFAULT_BUF_SIZE;\n@@ -437,7 +442,13 @@ pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)\n \t\tuint16_t data_size = 0;\n\n \t\tmemset(&dev_info, 0, sizeof(dev_info));\n-\t\trte_eth_dev_info_get(i, &dev_info);\n+\t\tret = rte_eth_dev_info_get(i, &dev_info);\n+\t\tif (ret != 0) {\n+\t\t\tevt_err(\"Error during getting device (port %u) info: %s\\n\",\n+\t\t\t\ti, strerror(-ret));\n+\t\t\treturn ret;\n+\t\t}\n+\n \t\tif (dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&\n \t\t\t\tdev_info.rx_desc_lim.nb_mtu_seg_max != 0) {\n \t\t\tdata_size = opt->max_pkt_sz /\n", "prefixes": [ "2/2" ] }