Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63186/?format=api
{ "id": 63186, "url": "http://patches.dpdk.org/api/patches/63186/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191121112015.53711-3-yahui.cao@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191121112015.53711-3-yahui.cao@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191121112015.53711-3-yahui.cao@intel.com", "date": "2019-11-21T11:20:15", "name": "[v3,2/2] net/ice: add missing FDIR support for GTPU without extension header", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8dc6b455ef00398bb63abfc27c55edb4a05c39df", "submitter": { "id": 1176, "url": "http://patches.dpdk.org/api/people/1176/?format=api", "name": "Cao, Yahui", "email": "yahui.cao@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191121112015.53711-3-yahui.cao@intel.com/mbox/", "series": [ { "id": 7556, "url": "http://patches.dpdk.org/api/series/7556/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7556", "date": "2019-11-21T11:20:13", "name": "fix FDIR support for GTPU", "version": 3, "mbox": "http://patches.dpdk.org/series/7556/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63186/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1116DA04C2;\n\tThu, 21 Nov 2019 04:37:01 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A67A32BF5;\n\tThu, 21 Nov 2019 04:36:50 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by dpdk.org (Postfix) with ESMTP id DA0C22BB1\n for <dev@dpdk.org>; Thu, 21 Nov 2019 04:36:47 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 20 Nov 2019 19:36:47 -0800", "from dpdk-yahui-skylake.sh.intel.com ([10.67.119.16])\n by orsmga005.jf.intel.com with ESMTP; 20 Nov 2019 19:36:45 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,224,1571727600\"; d=\"scan'208\";a=\"381594142\"", "From": "Yahui Cao <yahui.cao@intel.com>", "To": "Qiming Yang <qiming.yang@intel.com>,\n\tWenzhuo Lu <wenzhuo.lu@intel.com>", "Cc": "dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Yahui Cao <yahui.cao@intel.com>, Xiaolong Ye <xiaolong.ye@intel.com>,\n Ying A Wang <ying.a.wang@intel.com>, Simei Su <simei.su@intel.com>,\n Chenmin Sun <chenmin.sun@intel.com>", "Date": "Thu, 21 Nov 2019 19:20:15 +0800", "Message-Id": "<20191121112015.53711-3-yahui.cao@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191121112015.53711-1-yahui.cao@intel.com>", "References": "<20191120150549.54533-1-yahui.cao@intel.com>\n <20191121112015.53711-1-yahui.cao@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/ice: add missing FDIR support for\n\tGTPU without extension header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add FDIR support for normal GTP-U packet, which doesn't contain GTP_PSC\nextension header.\n\nFixes: efc16c621415 (\"net/ice: support flow director GTPU tunnel\")\nCc: yahui.cao@intel.com\n\nSigned-off-by: Yahui Cao <yahui.cao@intel.com>\n---\n drivers/net/ice/ice_fdir_filter.c | 9 +++++++--\n drivers/net/ice/ice_generic_flow.c | 8 ++++++++\n drivers/net/ice/ice_generic_flow.h | 1 +\n 3 files changed, 16 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex dc7a97acb..7214380ea 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -67,6 +67,9 @@\n \tICE_FDIR_INSET_VXLAN_IPV4 | \\\n \tICE_INSET_TUN_SCTP_SRC_PORT | ICE_INSET_TUN_SCTP_DST_PORT)\n \n+#define ICE_FDIR_INSET_GTPU_IPV4 (\\\n+\tICE_INSET_GTPU_TEID)\n+\n #define ICE_FDIR_INSET_GTPU_EH_IPV4 (\\\n \tICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)\n \n@@ -122,6 +125,7 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {\n \t\t\t\t ICE_FDIR_INSET_VXLAN_IPV4_TCP, ICE_INSET_NONE},\n \t{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,\n \t\t\t\t ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},\n+\t{pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},\n \t{pattern_eth_ipv4_gtpu_eh_ipv4,\n \t\t\t\t ICE_FDIR_INSET_GTPU_EH_IPV4, ICE_INSET_NONE},\n };\n@@ -838,6 +842,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum ice_fltr_ptype flow,\n \tcase ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_ICMP:\n \tcase ICE_FLTR_PTYPE_NONF_IPV4_GTPU_IPV4_OTHER:\n \t\tICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |\n+\t\t\t\t ICE_FLOW_SEG_HDR_GTPU_IP |\n \t\t\t\t ICE_FLOW_SEG_HDR_IPV4);\n \t\tbreak;\n \tdefault:\n@@ -1734,6 +1739,8 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \n \t\t\t\tfilter->input.gtpu_data.teid = gtp_spec->teid;\n \t\t\t}\n+\n+\t\t\ttunnel_type = ICE_FDIR_TUNNEL_TYPE_GTPU;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ITEM_TYPE_GTP_PSC:\n \t\t\tgtp_psc_spec = item->spec;\n@@ -1746,8 +1753,6 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\t\tfilter->input.gtpu_data.qfi =\n \t\t\t\t\tgtp_psc_spec->qfi;\n \t\t\t}\n-\n-\t\t\ttunnel_type = ICE_FDIR_TUNNEL_TYPE_GTPU;\n \t\t\tbreak;\n \t\tdefault:\n \t\t\trte_flow_error_set(error, EINVAL,\ndiff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c\nindex a235337ba..4f29dbaa0 100644\n--- a/drivers/net/ice/ice_generic_flow.c\n+++ b/drivers/net/ice/ice_generic_flow.c\n@@ -1034,6 +1034,14 @@ enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_icmp6[] = {\n };\n \n /* GTPU */\n+enum rte_flow_item_type pattern_eth_ipv4_gtpu_ipv4[] = {\n+\tRTE_FLOW_ITEM_TYPE_ETH,\n+\tRTE_FLOW_ITEM_TYPE_IPV4,\n+\tRTE_FLOW_ITEM_TYPE_UDP,\n+\tRTE_FLOW_ITEM_TYPE_GTPU,\n+\tRTE_FLOW_ITEM_TYPE_IPV4,\n+\tRTE_FLOW_ITEM_TYPE_END,\n+};\n enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4[] = {\n \tRTE_FLOW_ITEM_TYPE_ETH,\n \tRTE_FLOW_ITEM_TYPE_IPV4,\ndiff --git a/drivers/net/ice/ice_generic_flow.h b/drivers/net/ice/ice_generic_flow.h\nindex a598ceabc..ac085b47f 100644\n--- a/drivers/net/ice/ice_generic_flow.h\n+++ b/drivers/net/ice/ice_generic_flow.h\n@@ -336,6 +336,7 @@ extern enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_sctp[];\n extern enum rte_flow_item_type pattern_eth_ipv6_nvgre_eth_ipv6_icmp6[];\n \n /* GTPU */\n+extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_ipv4[];\n extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4[];\n extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4_udp[];\n extern enum rte_flow_item_type pattern_eth_ipv4_gtpu_eh_ipv4_tcp[];\n", "prefixes": [ "v3", "2/2" ] }