Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63170/?format=api
{ "id": 63170, "url": "http://patches.dpdk.org/api/patches/63170/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/5d0d895ddba0023ec58e21f229f30f0c11745234.1574270323.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5d0d895ddba0023ec58e21f229f30f0c11745234.1574270323.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5d0d895ddba0023ec58e21f229f30f0c11745234.1574270323.git.anatoly.burakov@intel.com", "date": "2019-11-20T17:23:33", "name": "[v8,06/12] timer: remove deprecated code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b64e9bcce779a09a4fc44cd9162ee5f81a536665", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/5d0d895ddba0023ec58e21f229f30f0c11745234.1574270323.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 7549, "url": "http://patches.dpdk.org/api/series/7549/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7549", "date": "2019-11-20T17:23:27", "name": "Implement the new ABI policy and add helper scripts", "version": 8, "mbox": "http://patches.dpdk.org/series/7549/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63170/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE07DA04C1;\n\tWed, 20 Nov 2019 18:24:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 483061B9A9;\n\tWed, 20 Nov 2019 18:24:25 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by dpdk.org (Postfix) with ESMTP id 848991B943\n for <dev@dpdk.org>; Wed, 20 Nov 2019 18:24:21 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 20 Nov 2019 09:24:21 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n by orsmga008.jf.intel.com with ESMTP; 20 Nov 2019 09:24:18 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,222,1571727600\"; d=\"scan'208\";a=\"200794129\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Marcin Baran <marcinx.baran@intel.com>,\n Robert Sanford <rsanford@akamai.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, john.mcnamara@intel.com,\n ray.kinsella@intel.com, bruce.richardson@intel.com, thomas@monjalon.net,\n david.marchand@redhat.com", "Date": "Wed, 20 Nov 2019 17:23:33 +0000", "Message-Id": "\n <5d0d895ddba0023ec58e21f229f30f0c11745234.1574270323.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1574270323.git.anatoly.burakov@intel.com>", "<cover.1574270323.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1574270323.git.anatoly.burakov@intel.com>", "<cover.1573230233.git.anatoly.burakov@intel.com>\n <cover.1574270323.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v8 06/12] timer: remove deprecated code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Baran <marcinx.baran@intel.com>\n\nRemove code for old ABI versions ahead of ABI version bump.\n\nSigned-off-by: Marcin Baran <marcinx.baran@intel.com>\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>\n---\n lib/librte_timer/rte_timer.c | 100 +++----------------------\n lib/librte_timer/rte_timer.h | 15 ----\n lib/librte_timer/rte_timer_version.map | 5 --\n 3 files changed, 10 insertions(+), 110 deletions(-)", "diff": "diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c\nindex 381a9f43f8..ca88454ff6 100644\n--- a/lib/librte_timer/rte_timer.c\n+++ b/lib/librte_timer/rte_timer.c\n@@ -68,9 +68,6 @@ static struct rte_timer_data *rte_timer_data_arr;\n static const uint32_t default_data_id;\n static uint32_t rte_timer_subsystem_initialized;\n \n-/* For maintaining older interfaces for a period */\n-static struct rte_timer_data default_timer_data;\n-\n /* when debug is enabled, store some statistics */\n #ifdef RTE_LIBRTE_TIMER_DEBUG\n #define __TIMER_STAT_ADD(priv_timer, name, n) do {\t\t\t\\\n@@ -131,30 +128,14 @@ rte_timer_data_dealloc(uint32_t id)\n \treturn 0;\n }\n \n-void __vsym\n-rte_timer_subsystem_init_v20(void)\n-{\n-\tunsigned lcore_id;\n-\tstruct priv_timer *priv_timer = default_timer_data.priv_timer;\n-\n-\t/* since priv_timer is static, it's zeroed by default, so only init some\n-\t * fields.\n-\t */\n-\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id ++) {\n-\t\trte_spinlock_init(&priv_timer[lcore_id].list_lock);\n-\t\tpriv_timer[lcore_id].prev_lcore = lcore_id;\n-\t}\n-}\n-VERSION_SYMBOL(rte_timer_subsystem_init, _v20, 2.0);\n-\n /* Init the timer library. Allocate an array of timer data structs in shared\n * memory, and allocate the zeroth entry for use with original timer\n * APIs. Since the intersection of the sets of lcore ids in primary and\n * secondary processes should be empty, the zeroth entry can be shared by\n * multiple processes.\n */\n-int __vsym\n-rte_timer_subsystem_init_v1905(void)\n+int\n+rte_timer_subsystem_init(void)\n {\n \tconst struct rte_memzone *mz;\n \tstruct rte_timer_data *data;\n@@ -209,9 +190,6 @@ rte_timer_subsystem_init_v1905(void)\n \n \treturn 0;\n }\n-MAP_STATIC_SYMBOL(int rte_timer_subsystem_init(void),\n-\t\t rte_timer_subsystem_init_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_subsystem_init, _v1905, 19.05);\n \n void\n rte_timer_subsystem_finalize(void)\n@@ -551,43 +529,14 @@ __rte_timer_reset(struct rte_timer *tim, uint64_t expire,\n }\n \n /* Reset and start the timer associated with the timer handle tim */\n-int __vsym\n-rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n-\t\t enum rte_timer_type type, unsigned int tim_lcore,\n-\t\t rte_timer_cb_t fct, void *arg)\n-{\n-\tuint64_t cur_time = rte_get_timer_cycles();\n-\tuint64_t period;\n-\n-\tif (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&\n-\t\t\t!(rte_lcore_is_enabled(tim_lcore) ||\n-\t\t\t rte_lcore_has_role(tim_lcore, ROLE_SERVICE))))\n-\t\treturn -1;\n-\n-\tif (type == PERIODICAL)\n-\t\tperiod = ticks;\n-\telse\n-\t\tperiod = 0;\n-\n-\treturn __rte_timer_reset(tim, cur_time + ticks, period, tim_lcore,\n-\t\t\t fct, arg, 0, &default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_reset, _v20, 2.0);\n-\n-int __vsym\n-rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n+int\n+rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned int tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg)\n {\n \treturn rte_timer_alt_reset(default_data_id, tim, ticks, type,\n \t\t\t\t tim_lcore, fct, arg);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n-\t\t\t\t enum rte_timer_type type,\n-\t\t\t\t unsigned int tim_lcore,\n-\t\t\t\t rte_timer_cb_t fct, void *arg),\n-\t\t rte_timer_reset_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_reset, _v1905, 19.05);\n \n int\n rte_timer_alt_reset(uint32_t timer_data_id, struct rte_timer *tim,\n@@ -657,21 +606,11 @@ __rte_timer_stop(struct rte_timer *tim, int local_is_locked,\n }\n \n /* Stop the timer associated with the timer handle tim */\n-int __vsym\n-rte_timer_stop_v20(struct rte_timer *tim)\n-{\n-\treturn __rte_timer_stop(tim, 0, &default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_stop, _v20, 2.0);\n-\n-int __vsym\n-rte_timer_stop_v1905(struct rte_timer *tim)\n+int\n+rte_timer_stop(struct rte_timer *tim)\n {\n \treturn rte_timer_alt_stop(default_data_id, tim);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_stop(struct rte_timer *tim),\n-\t\t rte_timer_stop_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_stop, _v1905, 19.05);\n \n int\n rte_timer_alt_stop(uint32_t timer_data_id, struct rte_timer *tim)\n@@ -817,15 +756,8 @@ __rte_timer_manage(struct rte_timer_data *timer_data)\n \tpriv_timer[lcore_id].running_tim = NULL;\n }\n \n-void __vsym\n-rte_timer_manage_v20(void)\n-{\n-\t__rte_timer_manage(&default_timer_data);\n-}\n-VERSION_SYMBOL(rte_timer_manage, _v20, 2.0);\n-\n-int __vsym\n-rte_timer_manage_v1905(void)\n+int\n+rte_timer_manage(void)\n {\n \tstruct rte_timer_data *timer_data;\n \n@@ -835,8 +767,6 @@ rte_timer_manage_v1905(void)\n \n \treturn 0;\n }\n-MAP_STATIC_SYMBOL(int rte_timer_manage(void), rte_timer_manage_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_manage, _v1905, 19.05);\n \n int\n rte_timer_alt_manage(uint32_t timer_data_id,\n@@ -1074,21 +1004,11 @@ __rte_timer_dump_stats(struct rte_timer_data *timer_data __rte_unused, FILE *f)\n #endif\n }\n \n-void __vsym\n-rte_timer_dump_stats_v20(FILE *f)\n-{\n-\t__rte_timer_dump_stats(&default_timer_data, f);\n-}\n-VERSION_SYMBOL(rte_timer_dump_stats, _v20, 2.0);\n-\n-int __vsym\n-rte_timer_dump_stats_v1905(FILE *f)\n+int\n+rte_timer_dump_stats(FILE *f)\n {\n \treturn rte_timer_alt_dump_stats(default_data_id, f);\n }\n-MAP_STATIC_SYMBOL(int rte_timer_dump_stats(FILE *f),\n-\t\t rte_timer_dump_stats_v1905);\n-BIND_DEFAULT_SYMBOL(rte_timer_dump_stats, _v1905, 19.05);\n \n int\n rte_timer_alt_dump_stats(uint32_t timer_data_id __rte_unused, FILE *f)\ndiff --git a/lib/librte_timer/rte_timer.h b/lib/librte_timer/rte_timer.h\nindex 05d287d8f2..9dc5fc3092 100644\n--- a/lib/librte_timer/rte_timer.h\n+++ b/lib/librte_timer/rte_timer.h\n@@ -181,8 +181,6 @@ int rte_timer_data_dealloc(uint32_t id);\n * subsystem\n */\n int rte_timer_subsystem_init(void);\n-int rte_timer_subsystem_init_v1905(void);\n-void rte_timer_subsystem_init_v20(void);\n \n /**\n * @warning\n@@ -250,13 +248,6 @@ void rte_timer_init(struct rte_timer *tim);\n int rte_timer_reset(struct rte_timer *tim, uint64_t ticks,\n \t\t enum rte_timer_type type, unsigned tim_lcore,\n \t\t rte_timer_cb_t fct, void *arg);\n-int rte_timer_reset_v1905(struct rte_timer *tim, uint64_t ticks,\n-\t\t\t enum rte_timer_type type, unsigned int tim_lcore,\n-\t\t\t rte_timer_cb_t fct, void *arg);\n-int rte_timer_reset_v20(struct rte_timer *tim, uint64_t ticks,\n-\t\t\tenum rte_timer_type type, unsigned int tim_lcore,\n-\t\t\trte_timer_cb_t fct, void *arg);\n-\n \n /**\n * Loop until rte_timer_reset() succeeds.\n@@ -313,8 +304,6 @@ rte_timer_reset_sync(struct rte_timer *tim, uint64_t ticks,\n * - (-1): The timer is in the RUNNING or CONFIG state.\n */\n int rte_timer_stop(struct rte_timer *tim);\n-int rte_timer_stop_v1905(struct rte_timer *tim);\n-int rte_timer_stop_v20(struct rte_timer *tim);\n \n /**\n * Loop until rte_timer_stop() succeeds.\n@@ -358,8 +347,6 @@ int rte_timer_pending(struct rte_timer *tim);\n * - -EINVAL: timer subsystem not yet initialized\n */\n int rte_timer_manage(void);\n-int rte_timer_manage_v1905(void);\n-void rte_timer_manage_v20(void);\n \n /**\n * Dump statistics about timers.\n@@ -371,8 +358,6 @@ void rte_timer_manage_v20(void);\n * - -EINVAL: timer subsystem not yet initialized\n */\n int rte_timer_dump_stats(FILE *f);\n-int rte_timer_dump_stats_v1905(FILE *f);\n-void rte_timer_dump_stats_v20(FILE *f);\n \n /**\n * @warning\ndiff --git a/lib/librte_timer/rte_timer_version.map b/lib/librte_timer/rte_timer_version.map\nindex 72f75c8181..92c69b2e29 100644\n--- a/lib/librte_timer/rte_timer_version.map\n+++ b/lib/librte_timer/rte_timer_version.map\n@@ -1,15 +1,10 @@\n DPDK_2.0 {\n \tglobal:\n \n-\trte_timer_dump_stats;\n \trte_timer_init;\n-\trte_timer_manage;\n \trte_timer_pending;\n-\trte_timer_reset;\n \trte_timer_reset_sync;\n-\trte_timer_stop;\n \trte_timer_stop_sync;\n-\trte_timer_subsystem_init;\n \n \tlocal: *;\n };\n", "prefixes": [ "v8", "06/12" ] }