Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63159/?format=api
{ "id": 63159, "url": "http://patches.dpdk.org/api/patches/63159/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1574244727-6003-6-git-send-email-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1574244727-6003-6-git-send-email-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1574244727-6003-6-git-send-email-joyce.kong@arm.com", "date": "2019-11-20T10:12:06", "name": "[v4,5/6] net/qede: use common rte bit operation APIs instead", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e055d8239111173dcebd2648faa037327560ba9f", "submitter": { "id": 970, "url": "http://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1574244727-6003-6-git-send-email-joyce.kong@arm.com/mbox/", "series": [ { "id": 7544, "url": "http://patches.dpdk.org/api/series/7544/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7544", "date": "2019-11-20T10:12:01", "name": "implement common rte bit operation APIs in PMDs", "version": 4, "mbox": "http://patches.dpdk.org/series/7544/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63159/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63159/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9BD01A04C1;\n\tWed, 20 Nov 2019 11:13:13 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C7BDC1BDAC;\n\tWed, 20 Nov 2019 11:12:48 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by dpdk.org (Postfix) with ESMTP id EB5F51BE96\n for <dev@dpdk.org>; Wed, 20 Nov 2019 11:12:46 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 631A1101E;\n Wed, 20 Nov 2019 02:12:46 -0800 (PST)", "from net-arm-thunderx2-01.test.ast.arm.com\n (net-arm-thunderx2-01.shanghai.arm.com [10.169.40.40])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 216AD3F52E;\n Wed, 20 Nov 2019 02:12:41 -0800 (PST)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com, thomas@monjalon.net, jerinj@marvell.com,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n david.marchand@redhat.com, honnappa.nagarahalli@arm.com, gavin.hu@arm.com,\n ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com,\n xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com,\n zhouguoyang@huawei.com", "Date": "Wed, 20 Nov 2019 18:12:06 +0800", "Message-Id": "<1574244727-6003-6-git-send-email-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": [ "<1574244727-6003-1-git-send-email-joyce.kong@arm.com>", "<1571125801-45773-1-git-send-email-joyce.kong@arm.com>" ], "References": [ "<1574244727-6003-1-git-send-email-joyce.kong@arm.com>", "<1571125801-45773-1-git-send-email-joyce.kong@arm.com>" ], "Subject": "[dpdk-dev] [PATCH v4 5/6] net/qede: use common rte bit operation\n\tAPIs instead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove its own bit operation APIs and use the common one,\nthis can reduce the code duplication largely.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\n drivers/net/qede/base/bcm_osal.c | 20 --------------------\n drivers/net/qede/base/bcm_osal.h | 10 ++++------\n 2 files changed, 4 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/qede/base/bcm_osal.c b/drivers/net/qede/base/bcm_osal.c\nindex 48d016e..19457d7 100644\n--- a/drivers/net/qede/base/bcm_osal.c\n+++ b/drivers/net/qede/base/bcm_osal.c\n@@ -46,26 +46,6 @@ u32 qede_osal_log2(u32 val)\n \treturn log;\n }\n \n-inline void qede_set_bit(u32 nr, unsigned long *addr)\n-{\n-\t__sync_fetch_and_or(addr, (1UL << nr));\n-}\n-\n-inline void qede_clr_bit(u32 nr, unsigned long *addr)\n-{\n-\t__sync_fetch_and_and(addr, ~(1UL << nr));\n-}\n-\n-inline bool qede_test_bit(u32 nr, unsigned long *addr)\n-{\n-\tbool res;\n-\n-\trte_mb();\n-\tres = ((*addr) & (1UL << nr)) != 0;\n-\trte_mb();\n-\treturn res;\n-}\n-\n static inline u32 qede_ffb(unsigned long word)\n {\n \tunsigned long first_bit;\ndiff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h\nindex 0f09557..e7a7392 100644\n--- a/drivers/net/qede/base/bcm_osal.h\n+++ b/drivers/net/qede/base/bcm_osal.h\n@@ -8,6 +8,7 @@\n #define __BCM_OSAL_H\n \n #include <rte_byteorder.h>\n+#include <rte_bitops.h>\n #include <rte_spinlock.h>\n #include <rte_malloc.h>\n #include <rte_atomic.h>\n@@ -311,17 +312,14 @@ typedef struct osal_list_t {\n #define OSAL_BITS_PER_UL_MASK\t\t(OSAL_BITS_PER_UL - 1)\n \n /* Bitops */\n-void qede_set_bit(u32, unsigned long *);\n #define OSAL_SET_BIT(bit, bitmap) \\\n-\tqede_set_bit(bit, bitmap)\n+\trte_set_bit64(bit, bitmap)\n \n-void qede_clr_bit(u32, unsigned long *);\n #define OSAL_CLEAR_BIT(bit, bitmap) \\\n-\tqede_clr_bit(bit, bitmap)\n+\trte_clear_bit64(bit, bitmap)\n \n-bool qede_test_bit(u32, unsigned long *);\n #define OSAL_TEST_BIT(bit, bitmap) \\\n-\tqede_test_bit(bit, bitmap)\n+\trte_get_bit64(bit, bitmap)\n \n u32 qede_find_first_bit(unsigned long *, u32);\n #define OSAL_FIND_FIRST_BIT(bitmap, length) \\\n", "prefixes": [ "v4", "5/6" ] }