Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63135/?format=api
{ "id": 63135, "url": "http://patches.dpdk.org/api/patches/63135/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191120042907.1030-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191120042907.1030-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191120042907.1030-2-ajit.khaparde@broadcom.com", "date": "2019-11-20T04:29:07", "name": "[2/2] net/bnxt: fix check for null spec and mask", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6c4c56897cca1a44f077c2600e869affa9b7ef25", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191120042907.1030-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 7534, "url": "http://patches.dpdk.org/api/series/7534/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7534", "date": "2019-11-20T04:29:07", "name": "[1/2] doc: update bnxt feature list", "version": 1, "mbox": "http://patches.dpdk.org/series/7534/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63135/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF122A04C1;\n\tWed, 20 Nov 2019 05:29:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 12A572C6D;\n\tWed, 20 Nov 2019 05:29:30 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id A081B2C36\n for <dev@dpdk.org>; Wed, 20 Nov 2019 05:29:28 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 40D0730C137;\n Tue, 19 Nov 2019 20:25:55 -0800 (PST)", "from localhost.localdomain (unknown [10.230.29.49])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 843F614008C;\n Tue, 19 Nov 2019 20:29:24 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 40D0730C137", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1574223955;\n bh=SzFISJPLAcONQvTC9d0E1vjrCoQxcV/rOlk8F2qsnTE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=sTqi0zp7z30tbWE+Wcz2llJqkjE14ZgsmHyzaLmB1a8vZMPtI3MigPrqveyJU4rFv\n AgOxdGEwsFybOnuoRTTF+BU1KCz0YrLjWt/Igw0pEuHnNqNfvuYyYFP5PWugRqt27Y\n onvGcgRLh5sh/DaE2NTORKN9W1IBa/CtzjNrk6Gg=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 19 Nov 2019 20:29:07 -0800", "Message-Id": "<20191120042907.1030-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20191120042907.1030-1-ajit.khaparde@broadcom.com>", "References": "<20191120042907.1030-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/bnxt: fix check for null spec and mask", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "bnxt_validate_and_parse_flow_type already has protocol specific NULL\nchecks for rte_flow_item spec and mask and take actions accordingly.\nA check at the top of the loop is redundant and is preventing the\nprotocol specific checks from being executed.\n\nFixes: b7e01f386059 (\"net/bnxt: handle cleanup if flow creation fails\")\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 5af571448..76e9584da 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -177,14 +177,6 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,\n \t\t\treturn -rte_errno;\n \t\t}\n \n-\t\tif (!item->spec || !item->mask) {\n-\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t item,\n-\t\t\t\t\t \"spec/mask is NULL\");\n-\t\t\treturn -rte_errno;\n-\t\t}\n-\n \t\tswitch (item->type) {\n \t\tcase RTE_FLOW_ITEM_TYPE_ANY:\n \t\t\tinner =\n", "prefixes": [ "2/2" ] }