Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/63121/?format=api
{ "id": 63121, "url": "http://patches.dpdk.org/api/patches/63121/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191119185638.78740-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191119185638.78740-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191119185638.78740-2-ajit.khaparde@broadcom.com", "date": "2019-11-19T18:56:36", "name": "[1/3] net/bnxt: fix to ignore resource qcaps error with older FW", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b2f3d59f68e2b546b6c918d7d2a2778fa083192e", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191119185638.78740-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 7527, "url": "http://patches.dpdk.org/api/series/7527/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7527", "date": "2019-11-19T18:56:38", "name": "bnxt patches", "version": 1, "mbox": "http://patches.dpdk.org/series/7527/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/63121/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/63121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD3FFA0353;\n\tTue, 19 Nov 2019 19:57:11 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9F9A42BF5;\n\tTue, 19 Nov 2019 19:57:00 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 7D822CF3;\n Tue, 19 Nov 2019 19:56:51 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id E4BF130C0D5;\n Tue, 19 Nov 2019 10:53:18 -0800 (PST)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n [10.69.74.102])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 30B0114008B;\n Tue, 19 Nov 2019 10:56:47 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com E4BF130C0D5", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1574189598;\n bh=qjDte1q5CPtH6KjAI3HqzOYoW+ajYuUF+62K/jzzgP0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=NNkbfchm4mwJIf4+fG/2AWSrdyXvVLGupfKyCAv1RNUGIeelUnlBxO4iSMHmQVx4K\n dP2ud7wOKfl9Skc59wdwE9NVHm8aVff/Ov+hx+PzcuxkqxniJJUm7dgemRjN2Nrz3w\n /s0DYrgFg+IDcLET2LxjYmVVHETyVGJ6ChRkLlSk=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Tue, 19 Nov 2019 10:56:36 -0800", "Message-Id": "<20191119185638.78740-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20191119185638.78740-1-ajit.khaparde@broadcom.com>", "References": "<20191119185638.78740-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/bnxt: fix to ignore resource qcaps error\n\twith older FW", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On some old versions of FW, bnxt_hwrm_func_resc_qcaps can return an\nerror. This is because the command was not implemented completely\nin FW till the subsequent version. Ignore the error and continue with\nthe driver initialization.\n\nFixes: edafb57ba4a1 (\"net/bnxt: fix VF resource allocation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 2cba007ea..1d3732eee 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -692,7 +692,12 @@ int bnxt_hwrm_func_qcaps(struct bnxt *bp)\n \t\t\tbp->flags |= BNXT_FLAG_NEW_RM;\n \t}\n \n-\treturn rc;\n+\t/* On older FW,\n+\t * bnxt_hwrm_func_resc_qcaps can fail and cause init failure.\n+\t * But the error can be ignored. Return success.\n+\t */\n+\n+\treturn 0;\n }\n \n /* VNIC cap covers capability of all VNICs. So no need to pass vnic_id */\n@@ -901,7 +906,7 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp)\n \n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \n-\tHWRM_CHECK_RESULT();\n+\tHWRM_CHECK_RESULT_SILENT();\n \n \tif (BNXT_VF(bp)) {\n \t\tbp->max_rsscos_ctx = rte_le_to_cpu_16(resp->max_rsscos_ctx);\n", "prefixes": [ "1/3" ] }