Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62972/?format=api
{ "id": 62972, "url": "http://patches.dpdk.org/api/patches/62972/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191113214346.33749-2-yasufum.o@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191113214346.33749-2-yasufum.o@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191113214346.33749-2-yasufum.o@gmail.com", "date": "2019-11-13T21:43:46", "name": "[v7,1/1] fbarray: fix duplicated fbarray file in secondary", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "28eb989ea4a3f3840e3119128a6790e1b7c62b39", "submitter": { "id": 1356, "url": "http://patches.dpdk.org/api/people/1356/?format=api", "name": "Yasufumi Ogawa", "email": "yasufum.o@gmail.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191113214346.33749-2-yasufum.o@gmail.com/mbox/", "series": [ { "id": 7449, "url": "http://patches.dpdk.org/api/series/7449/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7449", "date": "2019-11-13T21:43:45", "name": "fbarray: fix duplicated fbarray file in secondary", "version": 7, "mbox": "http://patches.dpdk.org/series/7449/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62972/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/62972/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 709BEA04C4;\n\tWed, 13 Nov 2019 22:44:07 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AECE02BC8;\n\tWed, 13 Nov 2019 22:44:01 +0100 (CET)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id B54ED2B99;\n Wed, 13 Nov 2019 22:43:59 +0100 (CET)", "by mail-pf1-f193.google.com with SMTP id r4so2548829pfl.7;\n Wed, 13 Nov 2019 13:43:59 -0800 (PST)", "from localhost.localdomain ([192.47.164.146])\n by smtp.gmail.com with ESMTPSA id r68sm3789538pfr.78.2019.11.13.13.43.56\n (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 13 Nov 2019 13:43:57 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=tyWhwIk+UcERkbBX++hSVNBBi4lK10YrKeojT1jKCpE=;\n b=Z8VrfQSGXAeXq/sbPH7kQH/XMJjJ8foqJ4rrCNIfFxA1OqbxzNLUT1sUJNhr7MqF0k\n FXiE4YLy3bH5ZjS36qJAHeGyaaX+9T2RuYj/sS/4Yl1kCL6irizQiGl6ZgDK9Qg6+xNO\n 4DWGPkHSDyZ6Rgm3lqxMN0ywLLDsHqtflTQKuTlTTU3jRrmVjg0R/YWMtzdBuyWNURMl\n X5JMsrao1QraeaPVACAC2WguB0mH5ya1ArAmyfWs+HdVwy/QCpmbCPAu8oWbYjFOSnYS\n A0BVh04mmAarw03LaQCPOIqziMwFHueUGtVh6YHOq4oblje/9zhMP36eHdaD/p+H+KmU\n Ld5w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=tyWhwIk+UcERkbBX++hSVNBBi4lK10YrKeojT1jKCpE=;\n b=kdBJcVQBGnYcXkG8C7NxwpwGNvamqkMw1baVXYK74wboeR4D+wZ9Jh88c5I2CyI8gq\n CZblkHzLb1XpRlyN+Yi1p57IkVS2Y8yF1WjVhtDH8CJpTxg88YUu9PGv03fHfoxxEwdk\n QkBVO0bJXqzCyUxU3KUzt9/z9jqsPFIakdxR+B1UOZFMxpIM57V2t9mKO2p66DUSC2qM\n 4vr3pXUNGxNzJQZrGz741YDOFg+a6KUPVmZQnF/RkM98s2xSREuhoAvIkXAnjrMRW1uG\n eMb42fJYxvyIep4tFbtjroaEzWFgrynYxS0BF2GEpyU42uyKBTEQFqxbBbq6RtTy1fxw\n bFLg==", "X-Gm-Message-State": "APjAAAWDHHlbIaRSIST5ugyCtSfUP26cd3wHuLJFo+0+EcJTEF6o0DpD\n ven1EQCUz1b8qYxJgIqv1GM=", "X-Google-Smtp-Source": "\n APXvYqwrjzrCdHSi9OPZwsG7h16GKJyk5U5XJa6g3quzeX6bvDYbR/Y/BYgMn4QkepGAZhMingUqUQ==", "X-Received": "by 2002:a17:90a:5d0e:: with SMTP id\n s14mr7566659pji.55.1573681438437;\n Wed, 13 Nov 2019 13:43:58 -0800 (PST)", "From": "yasufum.o@gmail.com", "To": "anatoly.burakov@intel.com, david.marchand@redhat.com,\n konstantin.ananyev@intel.com", "Cc": "dev@dpdk.org, stable@dpdk.org, yasufum.o@gmail.com,\n Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>", "Date": "Thu, 14 Nov 2019 06:43:46 +0900", "Message-Id": "<20191113214346.33749-2-yasufum.o@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191113214346.33749-1-yasufum.o@gmail.com>", "References": "<20190724082031.45546-1-yasufum.o@gmail.com>\n <20191113214346.33749-1-yasufum.o@gmail.com>", "Subject": "[dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in\n\tsecondary", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>\n\nIn secondary_msl_create_walk(), it creates a file for fbarrays with its\nPID for reserving unique name among secondary processes. However, it\ndoes not work if several secondaries run as app containers because each\nof containerized secondary has PID 1, and failed to reserve unique name\nother than first one. To reserve unique name in each of containers, use\nhostname in addition to PID.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>\n---\n lib/librte_eal/linux/eal/eal_memalloc.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c\nindex af6d0d023..11de6d4d6 100644\n--- a/lib/librte_eal/linux/eal/eal_memalloc.c\n+++ b/lib/librte_eal/linux/eal/eal_memalloc.c\n@@ -1365,6 +1365,12 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl,\n \tstruct rte_memseg_list *primary_msl, *local_msl;\n \tchar name[PATH_MAX];\n \tint msl_idx, ret;\n+\tchar hostname[HOST_NAME_MAX+1] = { 0 };\n+\t/* filename of secondary's fbarray is defined such as\n+\t * \"fbarray_memseg-1048576k-0-0_PID_HOSTNAME\" and length of PID\n+\t * can be 7 digits maximumly.\n+\t */\n+\tint fbarray_sec_name_len = 32 + 7 + 1 + HOST_NAME_MAX + 1;\n \n \tif (msl->external)\n \t\treturn 0;\n@@ -1373,9 +1379,13 @@ secondary_msl_create_walk(const struct rte_memseg_list *msl,\n \tprimary_msl = &mcfg->memsegs[msl_idx];\n \tlocal_msl = &local_memsegs[msl_idx];\n \n-\t/* create distinct fbarrays for each secondary */\n-\tsnprintf(name, RTE_FBARRAY_NAME_LEN, \"%s_%i\",\n-\t\tprimary_msl->memseg_arr.name, getpid());\n+\t/* Create distinct fbarrays for each secondary by using PID and\n+\t * hostname. The reason why using hostname is because PID could be\n+\t * duplicated among secondaries if it is launched in a container.\n+\t */\n+\tgethostname(hostname, sizeof(hostname));\n+\tsnprintf(name, fbarray_sec_name_len, \"%s_%d_%s\",\n+\t\t\tprimary_msl->memseg_arr.name, (int)getpid(), hostname);\n \n \tret = rte_fbarray_init(&local_msl->memseg_arr, name,\n \t\tprimary_msl->memseg_arr.len,\n", "prefixes": [ "v7", "1/1" ] }