Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62965/?format=api
{ "id": 62965, "url": "http://patches.dpdk.org/api/patches/62965/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191113150700.2517-7-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191113150700.2517-7-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191113150700.2517-7-ajit.khaparde@broadcom.com", "date": "2019-11-13T15:07:00", "name": "[v2,6/6] net/bnxt: fix potential NULL pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "12aec3c55a4762d0c7dae436f75d2ef783b4b9ec", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191113150700.2517-7-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 7445, "url": "http://patches.dpdk.org/api/series/7445/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7445", "date": "2019-11-13T15:06:54", "name": "bnxt patchset with bug fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/7445/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62965/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AC6F8A04C3;\n\tWed, 13 Nov 2019 16:08:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4B9D14CA6;\n\tWed, 13 Nov 2019 16:07:26 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id A624C271\n for <dev@dpdk.org>; Wed, 13 Nov 2019 16:07:13 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8761830C01C;\n Wed, 13 Nov 2019 07:03:57 -0800 (PST)", "from localhost.localdomain (unknown [10.230.26.250])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 0DCAE140069;\n Wed, 13 Nov 2019 07:07:08 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8761830C01C", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1573657437;\n bh=Q/RV4kso7DEQ6CcjXZLhzDW/kyKn9SUxx8MYJPKIIrI=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=oC7aDyIH2UoWwFpp+VOIvrIe/fA2pcgv/HZek7S6Nbg4af+rGJlkbZkOqGKBqwcpn\n 0NNz1g4ArU8gOy9Aky80VL9JfFUFXqM4pnYuqeBXhm+EiXVUzDXFtFTZzxX+AKJbx4\n scHeHeNI8jHxidLJv+a5NTWnmQ83ojGRVKzolv8A=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 13 Nov 2019 07:07:00 -0800", "Message-Id": "<20191113150700.2517-7-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20191113150700.2517-1-ajit.khaparde@broadcom.com>", "References": "<20191113082945.21277-1-somnath.kotur@broadcom.com>\n <20191113150700.2517-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 6/6] net/bnxt: fix potential NULL pointer\n\tdereference", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Null-checking \"rxq\" suggests that it may be null, but it has already\nbeen dereferenced on all paths leading to the check.\nRefactored the code to address this issue.\n\nCoverity issue: 350594\nFixes: fc4bfea59696 (\"net/bnxt: fix Rx queue start/stop for Thor based NICs\")\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxq.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex 7fd079da3..94f105d34 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -515,13 +515,18 @@ int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t}\n \n \trxq = bp->rx_queues[rx_queue_id];\n-\tvnic = rxq->vnic;\n-\n-\tif (!rxq || !vnic) {\n+\tif (!rxq) {\n \t\tPMD_DRV_LOG(ERR, \"Invalid Rx queue %d\\n\", rx_queue_id);\n \t\treturn -EINVAL;\n \t}\n \n+\tvnic = rxq->vnic;\n+\tif (!vnic) {\n+\t\tPMD_DRV_LOG(ERR, \"VNIC not initialized for RxQ %d\\n\",\n+\t\t\t rx_queue_id);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n \trxq->rx_started = false;\n \tPMD_DRV_LOG(DEBUG, \"Rx queue stopped\\n\");\n", "prefixes": [ "v2", "6/6" ] }