Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62961/?format=api
{ "id": 62961, "url": "http://patches.dpdk.org/api/patches/62961/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191113150700.2517-5-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191113150700.2517-5-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191113150700.2517-5-ajit.khaparde@broadcom.com", "date": "2019-11-13T15:06:58", "name": "[v2,4/6] net/bnxt: fix a potential segfault in xstats get", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "761ddde91251a96821e50c74b841f786e56c0cc7", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191113150700.2517-5-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 7445, "url": "http://patches.dpdk.org/api/series/7445/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7445", "date": "2019-11-13T15:06:54", "name": "bnxt patchset with bug fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/7445/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62961/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4EC6A04C3;\n\tWed, 13 Nov 2019 16:07:30 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF6882C16;\n\tWed, 13 Nov 2019 16:07:18 +0100 (CET)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 8E5E7B62;\n Wed, 13 Nov 2019 16:07:12 +0100 (CET)", "from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net\n [10.75.242.48])\n by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id AAA1830C038;\n Wed, 13 Nov 2019 07:03:56 -0800 (PST)", "from localhost.localdomain (unknown [10.230.26.250])\n by mail-irv-17.broadcom.com (Postfix) with ESMTP id 249A1140069;\n Wed, 13 Nov 2019 07:07:07 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com AAA1830C038", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1573657436;\n bh=fP5RUZXQRoTRhxrM2t+gF0Y/nMbFKuWYj6yL8yQkiNo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=vG/eRKCRXpYgZlsGoEOxQJSuaxW42SwL4PE/6Lai3UOTCi+m+qcMnvpsnR1BkMwmi\n gjqN9Mer92Ql55d0KZLQ0pP+3/zE4jKhqUAaVBTWIv4nqHmnKP6flMnRUuUbi9roEA\n 7BzPO/LwyHjHiD2FkDIiooE3bErFUhNOwCUXjEsk=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, stable@dpdk.org,\n Andy Gospodarek <gospo@broadcom.com>", "Date": "Wed, 13 Nov 2019 07:06:58 -0800", "Message-Id": "<20191113150700.2517-5-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.0 (Apple Git-122.2)", "In-Reply-To": "<20191113150700.2517-1-ajit.khaparde@broadcom.com>", "References": "<20191113082945.21277-1-somnath.kotur@broadcom.com>\n <20191113150700.2517-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/6] net/bnxt: fix a potential segfault in\n\txstats get", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We would hit a segfault in bnxt_dev_xstats_get_op() if xstats\nargument is NULL, Check if the argument is NULL and return appropriately.\n\nFixes: bfb9c2260be2 (\"net/bnxt: support xstats get/reset\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Andy Gospodarek <gospo@broadcom.com>\n---\n drivers/net/bnxt/bnxt_stats.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex 40b496ac0..14d355fd0 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -468,6 +468,9 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,\n \tif (rc)\n \t\treturn rc;\n \n+\tif (xstats == NULL)\n+\t\treturn 0;\n+\n \tmemset(xstats, 0, sizeof(*xstats));\n \n \tbnxt_hwrm_port_qstats(bp);\n", "prefixes": [ "v2", "4/6" ] }