Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62956/?format=api
{ "id": 62956, "url": "http://patches.dpdk.org/api/patches/62956/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1573643008-8216-1-git-send-email-wangzk320@163.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1573643008-8216-1-git-send-email-wangzk320@163.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1573643008-8216-1-git-send-email-wangzk320@163.com", "date": "2019-11-13T11:03:28", "name": "[v2] vhost: fix vring message handling broken in some case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4686a50302143617455be9fab206a2a6b3139363", "submitter": { "id": 1494, "url": "http://patches.dpdk.org/api/people/1494/?format=api", "name": "王志克", "email": "wangzk320@163.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1573643008-8216-1-git-send-email-wangzk320@163.com/mbox/", "series": [ { "id": 7442, "url": "http://patches.dpdk.org/api/series/7442/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7442", "date": "2019-11-13T11:03:28", "name": "[v2] vhost: fix vring message handling broken in some case", "version": 2, "mbox": "http://patches.dpdk.org/series/7442/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62956/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49106A04C1;\n\tWed, 13 Nov 2019 12:03:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 323D21BF12;\n\tWed, 13 Nov 2019 12:03:39 +0100 (CET)", "from m12-16.163.com (m12-16.163.com [220.181.12.16])\n by dpdk.org (Postfix) with ESMTP id 65D541BEFD;\n Wed, 13 Nov 2019 12:03:36 +0100 (CET)", "from localhost.localdomain (unknown [106.38.115.15])\n by smtp12 (Coremail) with SMTP id EMCowAD3ah8C48tdPxd8AQ--.9374S2;\n Wed, 13 Nov 2019 19:03:33 +0800 (CST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com;\n s=s110527; h=From:Subject:Date:Message-Id; bh=xHmyj+6cSuMv/yCcwl\n a1TSaN7Ak+pCR7PrgyQxgeCFA=; b=NOr5grnk8WZDa1+D4mhbocd9Zi2b3WaFh9\n dlZT/U5mRrLogE1NVj3EC6BISRDgC49BSY40KKMjefwZ5yqi2OHzNBcDT/DA2g3g\n 8pQnRd8ebk7499r2AXTvlNlI85HYOXruqJNIrE1+A//wMmslVErMA6EbbWmhrOcW\n oy8reqfEM=", "From": "Zhike Wang <wangzk320@163.com>", "To": "dev@dpdk.org,\n\tstable@dpdk.org,\n\tsecurity@dpdk.org", "Cc": "wangzhike@jd.com,\n\tZhike Wang <wangzk320@163.com>", "Date": "Wed, 13 Nov 2019 19:03:28 +0800", "Message-Id": "<1573643008-8216-1-git-send-email-wangzk320@163.com>", "X-Mailer": "git-send-email 1.8.3.1", "X-CM-TRANSID": "EMCowAD3ah8C48tdPxd8AQ--.9374S2", "X-Coremail-Antispam": "1Uf129KBjvJXoW7ZF4xWF1xKr1rWr1UXw1DJrb_yoW8tFWxpF\n 9xJ3W2yrWxKr4UC3s7ZFn3G34I9w1vkF1xWrZaga13ZF40gwn8Za9ayr4UWF13AFZ8AFyj\n ya1jqF98GryUua7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07U5kusUUUUU=", "X-Originating-IP": "[106.38.115.15]", "X-CM-SenderInfo": "pzdqw6bntsiqqrwthudrp/1tbipQVsulUMVkGNHgAAsr", "Subject": "[dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in\n\tsome case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0,\nso validate_msg_fds() will return error. In this case,\nthe negotiation of vring message between vhost user front end and\nback end would fail, and as a result, vhost user link could NOT be up.\n\nHow to reproduce:\n1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk.\n2.Notice that inside ovs there are endless logs regarding failure to\nhandle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up.\n\nFixes: bf47225 (\"vhost: fix possible denial of service by leaking FDs\")\nSigned-off-by: Zhike Wang <wangzk320@163.com>\n---\n lib/librte_vhost/vhost_user.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 90ecee1..0cfb8b7 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1563,8 +1563,10 @@\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_vring_file file;\n \tstruct vhost_virtqueue *vq;\n+\tint expected_fds;\n \n-\tif (validate_msg_fds(msg, 1) != 0)\n+\texpected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;\n+\tif (validate_msg_fds(msg, expected_fds) != 0)\n \t\treturn RTE_VHOST_MSG_RESULT_ERR;\n \n \tfile.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;\n@@ -1588,7 +1590,10 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,\n \t\t\tstruct VhostUserMsg *msg,\n \t\t\tint main_fd __rte_unused)\n {\n-\tif (validate_msg_fds(msg, 1) != 0)\n+\tint expected_fds;\n+\n+\texpected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;\n+\tif (validate_msg_fds(msg, expected_fds) != 0)\n \t\treturn RTE_VHOST_MSG_RESULT_ERR;\n \n \tif (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))\n@@ -1790,8 +1795,10 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_vring_file file;\n \tstruct vhost_virtqueue *vq;\n+\tint expected_fds;\n \n-\tif (validate_msg_fds(msg, 1) != 0)\n+\texpected_fds = (msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1;\n+\tif (validate_msg_fds(msg, expected_fds) != 0)\n \t\treturn RTE_VHOST_MSG_RESULT_ERR;\n \n \tfile.index = msg->payload.u64 & VHOST_USER_VRING_IDX_MASK;\n", "prefixes": [ "v2" ] }