Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62950/?format=api
{ "id": 62950, "url": "http://patches.dpdk.org/api/patches/62950/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191113082945.21277-4-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191113082945.21277-4-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191113082945.21277-4-somnath.kotur@broadcom.com", "date": "2019-11-13T08:29:42", "name": "[3/6] net/bnxt: fix flow creation with non-consecutive group ids", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ffb556e1cdb5c68ba01b1b9bb48665e2bcd446c0", "submitter": { "id": 908, "url": "http://patches.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191113082945.21277-4-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 7439, "url": "http://patches.dpdk.org/api/series/7439/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7439", "date": "2019-11-13T08:29:40", "name": "bnxt patchset with bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/7439/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62950/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62950/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C173A0353;\n\tWed, 13 Nov 2019 09:38:21 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7B881BF19;\n\tWed, 13 Nov 2019 09:38:06 +0100 (CET)", "from relay.smtp.broadcom.com (unknown [192.19.211.62])\n by dpdk.org (Postfix) with ESMTP id A212B1BEF0\n for <dev@dpdk.org>; Wed, 13 Nov 2019 09:37:56 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55])\n by relay.smtp.broadcom.com (Postfix) with ESMTP id C837A28D9EE;\n Wed, 13 Nov 2019 00:37:55 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com C837A28D9EE", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1573634275;\n bh=YtOwHS8R9w57XOOFXrl52EWXltEP9ELI7EfVra8iw3k=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=vs9710EHsQb9jykUgavlq6HCiKdbn5B/g7gwRUxSkySvD8xkNQCVp7Lmae3e7wjac\n 0DtNO88QYVRW7txvrtxwzPWWQ8U1y2g/Ww8Awb1lux2nAgz/nnP6eNiqxHbBUbHtyd\n RKIQChKpifx4k94nnU9DlWMJc/YNIy661mWddjik=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com", "Date": "Wed, 13 Nov 2019 13:59:42 +0530", "Message-Id": "<20191113082945.21277-4-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.10.1.613.g2cc2e70", "In-Reply-To": "<20191113082945.21277-1-somnath.kotur@broadcom.com>", "References": "<20191113082945.21277-1-somnath.kotur@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 3/6] net/bnxt: fix flow creation with\n\tnon-consecutive group ids", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rahul Gupta <rahul.gupta@broadcom.com>\n\nIn non-RSS mode, vnics map 1:1 with Rx queues during init. This can\ncreate problems if non-consecutive group IDs are given as part of\nsubsequent flow create cmds as they can end up pointing to Rx queues\n(mapped during init) that are different than the intended destination\nqueue as specified in the flow create cmd.\nTo fix this, now that we have the ability to dynamically create\nvnics, do not create any additional vnics other than the default vnic\nduring init. Allocate them only during flow/filter creation time.\n\nWhen RSS is disabled we need to use the COS queue count queried\nfrom firmware.\n\nFixes: 36024b2e7fe5 (\"net/bnxt: allow dynamic creation of VNIC\")\n\nSigned-off-by: Rahul Gupta <rahul.gupta@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_flow.c | 4 +---\n drivers/net/bnxt/bnxt_rxq.c | 5 ++++-\n 2 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c\nindex 8f386cdf1..5af571448 100644\n--- a/drivers/net/bnxt/bnxt_flow.c\n+++ b/drivers/net/bnxt/bnxt_flow.c\n@@ -1093,9 +1093,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,\n \t\t vnic->fw_vnic_id != INVALID_HW_RING_ID)\n \t\t\tgoto use_vnic;\n \n-\t\tif (!rxq ||\n-\t\t bp->vnic_info[0].fw_grp_ids[act_q->index] !=\n-\t\t INVALID_HW_RING_ID) {\n+\t\tif (!rxq) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t \"Queue invalid or used with other VNIC\\n\");\n \t\t\trte_flow_error_set(error,\ndiff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c\nindex fa11bec4e..7fd079da3 100644\n--- a/drivers/net/bnxt/bnxt_rxq.c\n+++ b/drivers/net/bnxt/bnxt_rxq.c\n@@ -35,7 +35,7 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \tint start_grp_id, end_grp_id = 1, rc = 0;\n \tstruct bnxt_vnic_info *vnic;\n \tstruct bnxt_filter_info *filter;\n-\tenum rte_eth_nb_pools pools = bp->rx_cp_nr_rings, max_pools = 0;\n+\tenum rte_eth_nb_pools pools = 1, max_pools = 0;\n \tstruct bnxt_rx_queue *rxq;\n \n \tbp->nr_vnics = 0;\n@@ -100,7 +100,10 @@ int bnxt_mq_rx_configure(struct bnxt *bp)\n \t\t\trc = -EINVAL;\n \t\t\tgoto err_out;\n \t\t}\n+\t} else if (!dev_conf->rxmode.mq_mode) {\n+\t\tpools = bp->rx_cosq_cnt ? bp->rx_cosq_cnt : pools;\n \t}\n+\n \tnb_q_per_grp = bp->rx_cp_nr_rings / pools;\n \tbp->rx_num_qs_per_vnic = nb_q_per_grp;\n \tPMD_DRV_LOG(DEBUG, \"pools = %u nb_q_per_grp = %u\\n\",\n", "prefixes": [ "3/6" ] }