Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 62888,
    "url": "http://patches.dpdk.org/api/patches/62888/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com",
    "date": "2019-11-12T14:19:20",
    "name": "net/mlx5: fix verbs flow counter query",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6eba290e347525017fe9189ce3e79aec80a53b88",
    "submitter": {
        "id": 1082,
        "url": "http://patches.dpdk.org/api/people/1082/?format=api",
        "name": "Dekel Peled",
        "email": "dekelp@mellanox.com"
    },
    "delegate": {
        "id": 3268,
        "url": "http://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com/mbox/",
    "series": [
        {
            "id": 7414,
            "url": "http://patches.dpdk.org/api/series/7414/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7414",
            "date": "2019-11-12T14:19:20",
            "name": "net/mlx5: fix verbs flow counter query",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/7414/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/62888/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/62888/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D7211A04C1;\n\tTue, 12 Nov 2019 15:19:41 +0100 (CET)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CD22B2AB;\n\tTue, 12 Nov 2019 15:19:40 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 0308D91\n for <dev@dpdk.org>; Tue, 12 Nov 2019 15:19:39 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 12 Nov 2019 16:19:38 +0200",
            "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xACEJcst032337;\n Tue, 12 Nov 2019 16:19:38 +0200"
        ],
        "From": "Dekel Peled <dekelp@mellanox.com>",
        "To": "matan@mellanox.com, shahafs@mellanox.com, viacheslavo@mellanox.com",
        "Cc": "orika@mellanox.com, dev@dpdk.org",
        "Date": "Tue, 12 Nov 2019 16:19:20 +0200",
        "Message-Id": "\n <639b4cebe1b4f8efb2f2e2150eee708575f523d1.1573568296.git.dekelp@mellanox.com>",
        "X-Mailer": "git-send-email 1.7.1",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix verbs flow counter query",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Function flow_verbs_counter_query() was recently modified.\nThe new 'if' condition uses a pointer to flow counter-set.\nThis pointer is valid only if flow contains a count action.\n\nThis patch adds check to verify the pointer is valid.\n\nFixes: d85c7b5ea59f (\"net/mlx5: split hairpin flows\")\nCc: orika@mellanox.com\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_verbs.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c\nindex ea85fa1..c787c98 100644\n--- a/drivers/net/mlx5/mlx5_flow_verbs.c\n+++ b/drivers/net/mlx5/mlx5_flow_verbs.c\n@@ -191,7 +191,7 @@\n {\n #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42) || \\\n \tdefined(HAVE_IBV_DEVICE_COUNTERS_SET_V45)\n-\tif (flow->counter->cs) {\n+\tif (flow->counter && flow->counter->cs) {\n \t\tstruct rte_flow_query_count *qc = data;\n \t\tuint64_t counters[2] = {0, 0};\n #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42)\n",
    "prefixes": []
}