Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62851/?format=api
{ "id": 62851, "url": "http://patches.dpdk.org/api/patches/62851/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/c54b7fb34a4086463f45b47881458c149a677a51.1573494112.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<c54b7fb34a4086463f45b47881458c149a677a51.1573494112.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/c54b7fb34a4086463f45b47881458c149a677a51.1573494112.git.dekelp@mellanox.com", "date": "2019-11-11T17:47:34", "name": "[v7,2/3] net/mlx5: use API to set max LRO packet size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74dce76e9df6b76184d4cfc36b499bdffb6a86b8", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/c54b7fb34a4086463f45b47881458c149a677a51.1573494112.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 7392, "url": "http://patches.dpdk.org/api/series/7392/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7392", "date": "2019-11-11T17:47:33", "name": "support API to set max LRO packet size", "version": 7, "mbox": "http://patches.dpdk.org/series/7392/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62851/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C9ABA04AB;\n\tMon, 11 Nov 2019 18:48:10 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BBB8A2B84;\n\tMon, 11 Nov 2019 18:47:58 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id C5BBD237\n for <dev@dpdk.org>; Mon, 11 Nov 2019 18:47:51 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 11 Nov 2019 19:47:50 +0200", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.128.130.87])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xABHlm0X024859;\n Mon, 11 Nov 2019 19:47:50 +0200" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "john.mcnamara@intel.com, marko.kovacevic@intel.com, nhorman@tuxdriver.com,\n ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com,\n anatoly.burakov@intel.com, xuanziyang2@huawei.com,\n cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com,\n wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, matan@mellanox.com,\n shahafs@mellanox.com, viacheslavo@mellanox.com, rmody@marvell.com,\n shshaikh@marvell.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n zhihong.wang@intel.com, yongwang@vmware.com, thomas@monjalon.net,\n ferruh.yigit@intel.com, arybchenko@solarflare.com,\n jingjing.wu@intel.com, bernard.iremonger@intel.com", "Cc": "dev@dpdk.org", "Date": "Mon, 11 Nov 2019 19:47:34 +0200", "Message-Id": "\n <c54b7fb34a4086463f45b47881458c149a677a51.1573494112.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1573494112.git.dekelp@mellanox.com>", "References": "<20191108230753.32221-1-thomas@monjalon.net>\n <cover.1573494112.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v7 2/3] net/mlx5: use API to set max LRO packet\n\tsize", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch implements use of the API for LRO aggregated packet\nmax size.\nRx queue create is updated to use the relevant configuration.\nDocumentation is updated accordingly.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n doc/guides/nics/mlx5.rst | 2 ++\n drivers/net/mlx5/mlx5.h | 3 +++\n drivers/net/mlx5/mlx5_ethdev.c | 1 +\n drivers/net/mlx5/mlx5_rxq.c | 5 +++--\n 4 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 5fd313c..fd5a326 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -207,6 +207,8 @@ Limitations\n - KEEP_CRC offload cannot be supported with LRO.\n - The first mbuf length, without head-room, must be big enough to include the\n TCP header (122B).\n+ - Rx queue with LRO offload enabled, receiving a non-LRO packet, can forward\n+ it with size limited to max LRO size, not to max RX packet length.\n \n Statistics\n ----------\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 511463a..0c3a90e 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -218,6 +218,9 @@ struct mlx5_hca_attr {\n #define MLX5_LRO_SUPPORTED(dev) \\\n \t(((struct mlx5_priv *)((dev)->data->dev_private))->config.lro.supported)\n \n+/* Maximal size of aggregated LRO packet. */\n+#define MLX5_MAX_LRO_SIZE (UINT8_MAX * 256u)\n+\n /* LRO configurations structure. */\n struct mlx5_lro_config {\n \tuint32_t supported:1; /* Whether LRO is supported. */\ndiff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 2b7c867..3adc824 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -606,6 +606,7 @@ struct ethtool_link_settings {\n \t/* FIXME: we should ask the device for these values. */\n \tinfo->min_rx_bufsize = 32;\n \tinfo->max_rx_pktlen = 65536;\n+\tinfo->max_lro_pkt_size = MLX5_MAX_LRO_SIZE;\n \t/*\n \t * Since we need one CQ per QP, the limit is the minimum number\n \t * between the two values.\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 24d0eaa..c725e14 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1701,7 +1701,6 @@ struct mlx5_rxq_obj *\n \treturn 0;\n }\n \n-#define MLX5_MAX_LRO_SIZE (UINT8_MAX * 256u)\n #define MLX5_MAX_TCP_HDR_OFFSET ((unsigned int)(sizeof(struct rte_ether_hdr) + \\\n \t\t\t\t\tsizeof(struct rte_vlan_hdr) * 2 + \\\n \t\t\t\t\tsizeof(struct rte_ipv6_hdr)))\n@@ -1773,7 +1772,9 @@ struct mlx5_rxq_ctrl *\n \t\t\t dev->data->dev_conf.rxmode.offloads;\n \tunsigned int lro_on_queue = !!(offloads & DEV_RX_OFFLOAD_TCP_LRO);\n \tconst int mprq_en = mlx5_check_mprq_support(dev) > 0;\n-\tunsigned int max_rx_pkt_len = dev->data->dev_conf.rxmode.max_rx_pkt_len;\n+\tunsigned int max_rx_pkt_len = lro_on_queue ?\n+\t\t\tdev->data->dev_conf.rxmode.max_lro_pkt_size :\n+\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len;\n \tunsigned int non_scatter_min_mbuf_size = max_rx_pkt_len +\n \t\t\t\t\t\t\tRTE_PKTMBUF_HEADROOM;\n \tunsigned int max_lro_size = 0;\n", "prefixes": [ "v7", "2/3" ] }