Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62835/?format=api
{ "id": 62835, "url": "http://patches.dpdk.org/api/patches/62835/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191111131914.16559-3-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191111131914.16559-3-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191111131914.16559-3-pbhagavatula@marvell.com", "date": "2019-11-11T13:19:06", "name": "[v17,02/10] ethdev: add mbuf RSS update as an offload", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "52e3999b7d25904f6d9333a5a9cbc05c86664ce2", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191111131914.16559-3-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 7386, "url": "http://patches.dpdk.org/api/series/7386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7386", "date": "2019-11-11T13:19:04", "name": "ethdev: add new Rx offload flags", "version": 17, "mbox": "http://patches.dpdk.org/series/7386/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62835/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62835/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4DF0FA04B9;\n\tMon, 11 Nov 2019 14:19:42 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C06A22B99;\n\tMon, 11 Nov 2019 14:19:29 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 07C532B96\n for <dev@dpdk.org>; Mon, 11 Nov 2019 14:19:28 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xABDHUOs026235; Mon, 11 Nov 2019 05:19:28 -0800", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 2w5wurp8x4-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 11 Nov 2019 05:19:28 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 11 Nov\n 2019 05:19:26 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Mon, 11 Nov 2019 05:19:26 -0800", "from BG-LT7430.marvell.com (unknown [10.28.17.38])\n by maili.marvell.com (Postfix) with ESMTP id D42983F703F;\n Mon, 11 Nov 2019 05:19:23 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=aBQMwiNWm2oSkYtq+dpFNamIsINkHqMqmfCdvAue0dE=;\n b=xwl3nL38JLuZygTWTmDXXT7xhxuNdL/heRTDkuywTVYfN9R4NbfeL5HNnjNnn4pRLTq0\n XM5thnoNUF5F8cns3On+qoT4oMfLJT23ke5dqEOpdIbceKEIV48s4g/zK5IItFxR4aVP\n dlMKGIukwhd1vqpIhlDTF59f0soNJAnVYlDvY3aLizjltH/G12GkRo1mP9dCxeHthXEh\n PWHS32g/ByAlswIHwJjf1A4eaQFP7Z1AdulVI/dJjGeIZdCQ9yseizlA0daCUOGBGos8\n YGp/WNUe+9F/8UVBDzo+e4ggCw/xIaq+ffCYwrvGOXprdufvne2qW2x5DIy7+0U4SGj3 ow==", "From": "<pbhagavatula@marvell.com>", "To": "<ferruh.yigit@intel.com>, <arybchenko@solarflare.com>,\n <jerinj@marvell.com>, <thomas@monjalon.net>, John McNamara\n <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>", "Date": "Mon, 11 Nov 2019 18:49:06 +0530", "Message-ID": "<20191111131914.16559-3-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191111131914.16559-1-pbhagavatula@marvell.com>", "References": "<20191106191803.15098-1-pbhagavatula@marvell.com>\n <20191111131914.16559-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-11-11_04:2019-11-11,2019-11-11 signatures=0", "Subject": "[dpdk-dev] [PATCH v17 02/10] ethdev: add mbuf RSS update as an\n\toffload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to\nenable/disable PMDs write to `rte_mbuf::hash::rss`.\nPMDs notify the validity of `rte_mbuf::hash:rss` to the applcation\nby enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features.rst | 2 ++\n doc/guides/rel_notes/release_19_11.rst | 7 +++++++\n lib/librte_ethdev/rte_ethdev.c | 12 ++++++++++++\n lib/librte_ethdev/rte_ethdev.h | 1 +\n 4 files changed, 22 insertions(+)", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst\nindex f33e8e6d4..b200e72b1 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -274,6 +274,7 @@ Supports RSS hashing on RX.\n \n * **[uses] user config**: ``dev_conf.rxmode.mq_mode`` = ``ETH_MQ_RX_RSS_FLAG``.\n * **[uses] user config**: ``dev_conf.rx_adv_conf.rss_conf``.\n+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_RSS_HASH``.\n * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.\n * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``.\n \n@@ -286,6 +287,7 @@ Inner RSS\n Supports RX RSS hashing on Inner headers.\n \n * **[uses] rte_flow_action_rss**: ``level``.\n+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_RSS_HASH``.\n * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_RSS_HASH``, ``mbuf.rss``.\n \n \ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex f10acc288..fa2b8c3ba 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -101,6 +101,13 @@ New Features\n * This scheme will allow PMDs to avoid lookup to internal ptype table on Rx\n and thereby improve Rx performance if application wishes do so.\n \n+* **Added Rx offload flag to enable or disable RSS update**\n+\n+ * Added new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to\n+ enable/disable PMDs write to `rte_mbuf::hash::rss`.\n+ * PMDs notify the validity of `rte_mbuf::hash:rss` to the application\n+ by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.\n+\n * **Updated the enic driver.**\n \n * Added support for Geneve with options offload.\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex d5c4865ba..153d50e9a 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -129,6 +129,7 @@ static const struct {\n \tRTE_RX_OFFLOAD_BIT2STR(KEEP_CRC),\n \tRTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),\n \tRTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),\n+\tRTE_RX_OFFLOAD_BIT2STR(RSS_HASH),\n };\n \n #undef RTE_RX_OFFLOAD_BIT2STR\n@@ -1305,6 +1306,17 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\tgoto rollback;\n \t}\n \n+\t/* Check if Rx RSS distribution is disabled but RSS hash is enabled. */\n+\tif (((dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) == 0) &&\n+\t (dev_conf->rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Ethdev port_id=%u config invalid Rx mq_mode without RSS but %s offload is requested\",\n+\t\t\tport_id,\n+\t\t\trte_eth_dev_rx_offload_name(DEV_RX_OFFLOAD_RSS_HASH));\n+\t\tret = -EINVAL;\n+\t\tgoto rollback;\n+\t}\n+\n \t/*\n \t * Setup new number of RX/TX queues and reconfigure device.\n \t */\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex a7872819d..9b1a8e945 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1088,6 +1088,7 @@ struct rte_eth_conf {\n #define DEV_RX_OFFLOAD_KEEP_CRC\t\t0x00010000\n #define DEV_RX_OFFLOAD_SCTP_CKSUM\t0x00020000\n #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000\n+#define DEV_RX_OFFLOAD_RSS_HASH\t\t0x00080000\n \n #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\n", "prefixes": [ "v17", "02/10" ] }