Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62832/?format=api
http://patches.dpdk.org/api/patches/62832/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191111121648.2482-1-skori@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191111121648.2482-1-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191111121648.2482-1-skori@marvell.com", "date": "2019-11-11T12:16:48", "name": "[v5,1/1] net/octeontx2: add Rx/Tx burst mode get callbacks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8827cbad6b717cac78150d1d6a5d3a64cfd1dab8", "submitter": { "id": 1318, "url": "http://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191111121648.2482-1-skori@marvell.com/mbox/", "series": [ { "id": 7385, "url": "http://patches.dpdk.org/api/series/7385/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7385", "date": "2019-11-11T12:16:48", "name": "[v5,1/1] net/octeontx2: add Rx/Tx burst mode get callbacks", "version": 5, "mbox": "http://patches.dpdk.org/series/7385/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62832/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62832/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A6748A04B8;\n\tMon, 11 Nov 2019 13:17:05 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69CCEDE3;\n\tMon, 11 Nov 2019 13:17:04 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1CF19B62\n for <dev@dpdk.org>; Mon, 11 Nov 2019 13:17:02 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n xABCFNnA017089; Mon, 11 Nov 2019 04:17:02 -0800", "from sc-exch04.marvell.com ([199.233.58.184])\n by mx0a-0016f401.pphosted.com with ESMTP id 2w5upuxp7t-9\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 11 Nov 2019 04:17:02 -0800", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com\n (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 11 Nov\n 2019 04:16:53 -0800", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Mon, 11 Nov 2019 04:16:53 -0800", "from localhost.localdomain (unknown [10.28.34.200])\n by maili.marvell.com (Postfix) with ESMTP id 5F8FC3F703F;\n Mon, 11 Nov 2019 04:16:51 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0818; bh=wLZV8wpurDmc3+/qaaEFsbd+3PSt7ZZAsjIgZV7HbYo=;\n b=S6CLEX3tNhBNnic6+mV/GUli1KHtOshdJnGZJcBgEmgHZNrp7JVCP16jAx+YnxHqfVFc\n fLX2pelCK3AG6Ydr+ZGmZ5N9sCOEjKaSvPHR3xf6TgppP/xbtz54+eS0axAERX6rjhJ5\n cU67+cu1w1aLAuhbt+WPTI4FSfJycXsifDM90XHjCH21OoRA+m7vmVIh+psjG1MevOt4\n R231SdvFD/MdXuKvRuTbwHezkbrmwJkjeidSH7aknzAj2zpqJeHyeWm8GMLWoKknvEPf\n AFOFuebSDwYG3g2MSf/bXx0Uz3dNpt7tBaU3QBUZZNr/9YO/VmgSrugMfNmuTcbhflaW FQ==", "From": "Sunil Kumar Kori <skori@marvell.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram\n <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, \"John\n McNamara\" <john.mcnamara@intel.com>, Marko Kovacevic\n <marko.kovacevic@intel.com>", "CC": "<dev@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>", "Date": "Mon, 11 Nov 2019 17:46:48 +0530", "Message-ID": "<20191111121648.2482-1-skori@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191111081615.21113-1-skori@marvell.com>", "References": "<20191111081615.21113-1-skori@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,18.0.572\n definitions=2019-11-11_03:2019-11-11,2019-11-11 signatures=0", "Subject": "[dpdk-dev] [PATCH v5 1/1] net/octeontx2: add Rx/Tx burst mode get\n\tcallbacks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Retrieve burst mode information according to the selected Rx/Tx mode and\noffloads.\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\nv5:\n - Removed redundent code using flag to string mapping.\nv4:\n - Review comments incorporated.\nv3:\n - Rebased the patch over patches.dpdk.org/patch/62368/\nv2:\n - Rebased the patch on latest commit.\n - Update feature matrix for the support.\n\n doc/guides/nics/features/octeontx2.ini | 1 +\n drivers/net/octeontx2/otx2_ethdev.c | 2 +\n drivers/net/octeontx2/otx2_ethdev.h | 4 +\n drivers/net/octeontx2/otx2_ethdev_ops.c | 111 ++++++++++++++++++++++++\n 4 files changed, 118 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini\nindex 7c59b4383..c2a3f47b0 100644\n--- a/doc/guides/nics/features/octeontx2.ini\n+++ b/doc/guides/nics/features/octeontx2.ini\n@@ -13,6 +13,7 @@ Link status = Y\n Link status event = Y\n Runtime Rx queue setup = Y\n Runtime Tx queue setup = Y\n+Burst mode info = Y\n Fast mbuf free = Y\n Free Tx mbuf on demand = Y\n Queue start/stop = Y\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex 62291c698..37b674bcb 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -1978,6 +1978,8 @@ static const struct eth_dev_ops otx2_eth_dev_ops = {\n \t.xstats_get_names_by_id = otx2_nix_xstats_get_names_by_id,\n \t.rxq_info_get = otx2_nix_rxq_info_get,\n \t.txq_info_get = otx2_nix_txq_info_get,\n+\t.rx_burst_mode_get = otx2_rx_burst_mode_get,\n+\t.tx_burst_mode_get = otx2_tx_burst_mode_get,\n \t.rx_queue_count = otx2_nix_rx_queue_count,\n \t.rx_descriptor_done = otx2_nix_rx_descriptor_done,\n \t.rx_descriptor_status = otx2_nix_rx_descriptor_status,\ndiff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h\nindex 4d9ed4870..fd43789fe 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.h\n+++ b/drivers/net/octeontx2/otx2_ethdev.h\n@@ -388,6 +388,10 @@ void otx2_nix_rxq_info_get(struct rte_eth_dev *eth_dev, uint16_t queue_id,\n \t\t\t struct rte_eth_rxq_info *qinfo);\n void otx2_nix_txq_info_get(struct rte_eth_dev *eth_dev, uint16_t queue_id,\n \t\t\t struct rte_eth_txq_info *qinfo);\n+int otx2_rx_burst_mode_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t\t struct rte_eth_burst_mode *mode);\n+int otx2_tx_burst_mode_get(struct rte_eth_dev *dev, uint16_t queue_id,\n+\t\t\t struct rte_eth_burst_mode *mode);\n uint32_t otx2_nix_rx_queue_count(struct rte_eth_dev *eth_dev, uint16_t qidx);\n int otx2_nix_tx_done_cleanup(void *txq, uint32_t free_cnt);\n int otx2_nix_rx_descriptor_done(void *rxq, uint16_t offset);\ndiff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c b/drivers/net/octeontx2/otx2_ethdev_ops.c\nindex fc0fbd9f2..114239338 100644\n--- a/drivers/net/octeontx2/otx2_ethdev_ops.c\n+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c\n@@ -2,6 +2,7 @@\n * Copyright(C) 2019 Marvell International Ltd.\n */\n \n+#include <rte_ethdev.h>\n #include <rte_mbuf_pool_ops.h>\n \n #include \"otx2_ethdev.h\"\n@@ -221,6 +222,116 @@ otx2_nix_txq_info_get(struct rte_eth_dev *eth_dev, uint16_t queue_id,\n \tqinfo->conf.tx_deferred_start = 0;\n }\n \n+int\n+otx2_rx_burst_mode_get(struct rte_eth_dev *eth_dev,\n+\t\t __rte_unused uint16_t queue_id,\n+\t\t struct rte_eth_burst_mode *mode)\n+{\n+#define STRING_SIZE 64\n+\tssize_t bytes = 0, str_size = RTE_ETH_BURST_MODE_INFO_SIZE, rc;\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tconst struct burst_info {\n+\t\tuint16_t flags;\n+\t\tchar output[STRING_SIZE];\n+\t} rx_offload_map[] = {\n+\t\t\t{NIX_RX_OFFLOAD_RSS_F, \"RSS,\"},\n+\t\t\t{NIX_RX_OFFLOAD_PTYPE_F, \" Ptype,\"},\n+\t\t\t{NIX_RX_OFFLOAD_CHECKSUM_F, \" Checksum,\"},\n+\t\t\t{NIX_RX_OFFLOAD_VLAN_STRIP_F, \" VLAN Strip,\"},\n+\t\t\t{NIX_RX_OFFLOAD_MARK_UPDATE_F, \" Mark Update,\"},\n+\t\t\t{NIX_RX_OFFLOAD_TSTAMP_F, \" Timestamp,\"},\n+\t\t\t{NIX_RX_MULTI_SEG_F, \" Scattered,\"}\n+\t};\n+\tstatic const char *const burst_mode[] = {\"Vector Neon\", \"Scalar\"};\n+\tuint32_t i;\n+\n+\t/* Update burst mode info */\n+\trc = rte_strscpy(mode->info + bytes, burst_mode[dev->scalar_ena],\n+\t\t\t str_size - bytes);\n+\tif (rc < 0)\n+\t\tgoto done;\n+\n+\tbytes += rc;\n+\n+\trc = rte_strscpy(mode->info + bytes, \", Rx Offloads:\",\n+\t\t\t str_size - bytes);\n+\tif (rc < 0)\n+\t\tgoto done;\n+\n+\tbytes += rc;\n+\n+\t/* Update Rx offload info */\n+\tfor (i = 0; i < RTE_DIM(rx_offload_map); i++) {\n+\t\tif (dev->rx_offload_flags & rx_offload_map[i].flags) {\n+\t\t\trc = rte_strscpy(mode->info + bytes,\n+\t\t\t\t\t rx_offload_map[i].output,\n+\t\t\t\t\t str_size - bytes);\n+\t\t\tif (rc < 0)\n+\t\t\t\tgoto done;\n+\n+\t\t\tbytes += rc;\n+\t\t}\n+\t}\n+\n+done:\n+\treturn 0;\n+}\n+\n+int\n+otx2_tx_burst_mode_get(struct rte_eth_dev *eth_dev,\n+\t\t __rte_unused uint16_t queue_id,\n+\t\t struct rte_eth_burst_mode *mode)\n+{\n+#define STRING_SIZE 64\n+\tssize_t bytes = 0, str_size = RTE_ETH_BURST_MODE_INFO_SIZE, rc;\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tconst struct burst_info {\n+\t\tuint16_t flags;\n+\t\tchar output[STRING_SIZE];\n+\t} tx_offload_map[] = {\n+\t\t\t{NIX_TX_OFFLOAD_L3_L4_CSUM_F, \" Inner L3/L4 csum,\"},\n+\t\t\t{NIX_TX_OFFLOAD_OL3_OL4_CSUM_F, \" Outer L3/L4 csum,\"},\n+\t\t\t{NIX_TX_OFFLOAD_VLAN_QINQ_F, \" VLAN Insertion,\"},\n+\t\t\t{NIX_TX_OFFLOAD_MBUF_NOFF_F, \" MBUF free disable,\"},\n+\t\t\t{NIX_TX_OFFLOAD_TSTAMP_F, \" Timestamp,\"},\n+\t\t\t{NIX_TX_OFFLOAD_TSO_F, \" TSO,\"},\n+\t\t\t{NIX_TX_MULTI_SEG_F, \" Scattered,\"}\n+\t};\n+\tstatic const char *const burst_mode[] = {\"Vector Neon\", \"Scalar\"};\n+\tuint32_t i;\n+\n+\t/* Update burst mode info */\n+\trc = rte_strscpy(mode->info + bytes, burst_mode[dev->scalar_ena],\n+\t\t\t str_size - bytes);\n+\tif (rc < 0)\n+\t\tgoto done;\n+\n+\tbytes += rc;\n+\n+\trc = rte_strscpy(mode->info + bytes, \", Tx Offloads:\",\n+\t\t\t str_size - bytes);\n+\tif (rc < 0)\n+\t\tgoto done;\n+\n+\tbytes += rc;\n+\n+\t/* Update Tx offload info */\n+\tfor (i = 0; i < RTE_DIM(tx_offload_map); i++) {\n+\t\tif (dev->tx_offload_flags & tx_offload_map[i].flags) {\n+\t\t\trc = rte_strscpy(mode->info + bytes,\n+\t\t\t\t\t tx_offload_map[i].output,\n+\t\t\t\t\t str_size - bytes);\n+\t\t\tif (rc < 0)\n+\t\t\t\tgoto done;\n+\n+\t\t\tbytes += rc;\n+\t\t}\n+\t}\n+\n+done:\n+\treturn 0;\n+}\n+\n static void\n nix_rx_head_tail_get(struct otx2_eth_dev *dev,\n \t\t uint32_t *head, uint32_t *tail, uint16_t queue_idx)\n", "prefixes": [ "v5", "1/1" ] }{ "id": 62832, "url": "