Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62423/?format=api
{ "id": 62423, "url": "http://patches.dpdk.org/api/patches/62423/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1572940915-29416-6-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1572940915-29416-6-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1572940915-29416-6-git-send-email-viacheslavo@mellanox.com", "date": "2019-11-05T08:01:40", "name": "[05/20] net/mlx5: update flow functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7fbe319875d0515c18e7c110c977f55fd6a5e109", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1572940915-29416-6-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 7242, "url": "http://patches.dpdk.org/api/series/7242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7242", "date": "2019-11-05T08:01:35", "name": "net/mlx5: implement extensive metadata feature", "version": 1, "mbox": "http://patches.dpdk.org/series/7242/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62423/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6A7F3A0352;\n\tTue, 5 Nov 2019 09:02:40 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C5D598F96;\n\tTue, 5 Nov 2019 09:02:11 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 5E5C444C7\n for <dev@dpdk.org>; Tue, 5 Nov 2019 09:02:09 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 5 Nov 2019 10:02:06 +0200", "from pegasus11.mtr.labs.mlnx (pegasus11.mtr.labs.mlnx\n [10.210.16.104])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xA5826CA026469;\n Tue, 5 Nov 2019 10:02:06 +0200", "from pegasus11.mtr.labs.mlnx (localhost [127.0.0.1])\n by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id xA58262A030761;\n Tue, 5 Nov 2019 08:02:06 GMT", "(from viacheslavo@localhost)\n by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id xA5826e0030760;\n Tue, 5 Nov 2019 08:02:06 GMT" ], "X-Authentication-Warning": "pegasus11.mtr.labs.mlnx: viacheslavo set sender to\n viacheslavo@mellanox.com using -f", "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "matan@mellanox.com, rasland@mellanox.com, thomas@monjalon.net,\n orika@mellanox.com, Yongseok Koh <yskoh@mellanox.com>", "Date": "Tue, 5 Nov 2019 08:01:40 +0000", "Message-Id": "<1572940915-29416-6-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1572940915-29416-1-git-send-email-viacheslavo@mellanox.com>", "References": "<1572940915-29416-1-git-send-email-viacheslavo@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 05/20] net/mlx5: update flow functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update flow creation/destroy functions for future reuse.\nList operations can be skipped inside functions and done\nseparately out of flow creation.\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex d1661f2..6e6c845 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -2736,7 +2736,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n * @param dev\n * Pointer to Ethernet device.\n * @param list\n- * Pointer to a TAILQ flow list.\n+ * Pointer to a TAILQ flow list. If this parameter NULL,\n+ * no list insertion occurred, flow is just created,\n+ * this is caller's responsibility to track the\n+ * created flow.\n * @param[in] attr\n * Flow rule attributes.\n * @param[in] items\n@@ -2881,7 +2884,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n \t\tif (ret < 0)\n \t\t\tgoto error;\n \t}\n-\tTAILQ_INSERT_TAIL(list, flow, next);\n+\tif (list)\n+\t\tTAILQ_INSERT_TAIL(list, flow, next);\n \tflow_rxq_flags_set(dev, flow);\n \treturn flow;\n error_before_flow:\n@@ -2975,7 +2979,8 @@ struct rte_flow *\n * @param dev\n * Pointer to Ethernet device.\n * @param list\n- * Pointer to a TAILQ flow list.\n+ * Pointer to a TAILQ flow list. If this parameter NULL,\n+ * there is no flow removal from the list.\n * @param[in] flow\n * Flow to destroy.\n */\n@@ -2995,7 +3000,8 @@ struct rte_flow *\n \t\tmlx5_flow_id_release(priv->sh->flow_id_pool,\n \t\t\t\t flow->hairpin_flow_id);\n \tflow_drv_destroy(dev, flow);\n-\tTAILQ_REMOVE(list, flow, next);\n+\tif (list)\n+\t\tTAILQ_REMOVE(list, flow, next);\n \trte_free(flow->fdir);\n \trte_free(flow);\n }\n", "prefixes": [ "05/20" ] }