Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62422/?format=api
{ "id": 62422, "url": "http://patches.dpdk.org/api/patches/62422/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1572940915-29416-4-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1572940915-29416-4-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1572940915-29416-4-git-send-email-viacheslavo@mellanox.com", "date": "2019-11-05T08:01:38", "name": "[03/20] net/mlx5: add metadata register copy", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fea5df0becc4929a86376b99f5cb495a1c1e1042", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1572940915-29416-4-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 7242, "url": "http://patches.dpdk.org/api/series/7242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7242", "date": "2019-11-05T08:01:35", "name": "net/mlx5: implement extensive metadata feature", "version": 1, "mbox": "http://patches.dpdk.org/series/7242/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62422/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62422/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B715A0352;\n\tTue, 5 Nov 2019 09:02:29 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55A6C44C7;\n\tTue, 5 Nov 2019 09:02:10 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 4CD2C37B0\n for <dev@dpdk.org>; Tue, 5 Nov 2019 09:02:09 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n viacheslavo@mellanox.com)\n with ESMTPS (AES256-SHA encrypted); 5 Nov 2019 10:02:03 +0200", "from pegasus11.mtr.labs.mlnx (pegasus11.mtr.labs.mlnx\n [10.210.16.104])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xA5823oj026456;\n Tue, 5 Nov 2019 10:02:03 +0200", "from pegasus11.mtr.labs.mlnx (localhost [127.0.0.1])\n by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7) with ESMTP id xA5823ON030757;\n Tue, 5 Nov 2019 08:02:03 GMT", "(from viacheslavo@localhost)\n by pegasus11.mtr.labs.mlnx (8.14.7/8.14.7/Submit) id xA5823VK030756;\n Tue, 5 Nov 2019 08:02:03 GMT" ], "X-Authentication-Warning": "pegasus11.mtr.labs.mlnx: viacheslavo set sender to\n viacheslavo@mellanox.com using -f", "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "matan@mellanox.com, rasland@mellanox.com, thomas@monjalon.net,\n orika@mellanox.com, Yongseok Koh <yskoh@mellanox.com>", "Date": "Tue, 5 Nov 2019 08:01:38 +0000", "Message-Id": "<1572940915-29416-4-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1572940915-29416-1-git-send-email-viacheslavo@mellanox.com>", "References": "<1572940915-29416-1-git-send-email-viacheslavo@mellanox.com>", "Subject": "[dpdk-dev] [PATCH 03/20] net/mlx5: add metadata register copy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add flow metadata register copy action which is supported through modify\nheader command. As it is an internal action, not exposed to users, item\ntype (MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG) is negative value. This can be\nused when creating PMD internal subflows.\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\nAcked-by: Matan Azrad <matan@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow.h | 13 +++++++----\n drivers/net/mlx5/mlx5_flow_dv.c | 50 ++++++++++++++++++++++++++++++++++++++++-\n 2 files changed, 58 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 8cc6c47..170192d 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -47,24 +47,30 @@ enum mlx5_rte_flow_item_type {\n \tMLX5_RTE_FLOW_ITEM_TYPE_TX_QUEUE,\n };\n \n-/* Private rte flow actions. */\n+/* Private (internal) rte flow actions. */\n enum mlx5_rte_flow_action_type {\n \tMLX5_RTE_FLOW_ACTION_TYPE_END = INT_MIN,\n \tMLX5_RTE_FLOW_ACTION_TYPE_TAG,\n+\tMLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG,\n };\n \n /* Matches on selected register. */\n struct mlx5_rte_flow_item_tag {\n-\tuint16_t id;\n+\tenum modify_reg id;\n \tuint32_t data;\n };\n \n /* Modify selected register. */\n struct mlx5_rte_flow_action_set_tag {\n-\tuint16_t id;\n+\tenum modify_reg id;\n \tuint32_t data;\n };\n \n+struct mlx5_flow_action_copy_mreg {\n+\tenum modify_reg dst;\n+\tenum modify_reg src;\n+};\n+\n /* Matches on source queue. */\n struct mlx5_rte_flow_item_tx_queue {\n \tuint32_t queue;\n@@ -227,7 +233,6 @@ struct mlx5_rte_flow_item_tx_queue {\n \n #define MLX5_FLOW_VLAN_ACTIONS (MLX5_FLOW_ACTION_OF_POP_VLAN | \\\n \t\t\t\tMLX5_FLOW_ACTION_OF_PUSH_VLAN)\n-\n #ifndef IPPROTO_MPLS\n #define IPPROTO_MPLS 137\n #endif\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 3df2609..930f088 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -861,7 +861,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t const struct rte_flow_action *action,\n \t\t\t struct rte_flow_error *error)\n {\n-\tconst struct mlx5_rte_flow_action_set_tag *conf = (action->conf);\n+\tconst struct mlx5_rte_flow_action_set_tag *conf = action->conf;\n \tstruct mlx5_modification_cmd *actions = resource->actions;\n \tuint32_t i = resource->actions_num;\n \n@@ -883,6 +883,47 @@ struct field_modify_info modify_tcp[] = {\n }\n \n /**\n+ * Convert internal COPY_REG action to DV specification.\n+ *\n+ * @param[in] dev\n+ * Pointer to the rte_eth_dev structure.\n+ * @param[in,out] res\n+ * Pointer to the modify-header resource.\n+ * @param[in] action\n+ * Pointer to action specification.\n+ * @param[out] error\n+ * Pointer to the error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+flow_dv_convert_action_copy_mreg(struct rte_eth_dev *dev __rte_unused,\n+\t\t\t\t struct mlx5_flow_dv_modify_hdr_resource *res,\n+\t\t\t\t const struct rte_flow_action *action,\n+\t\t\t\t struct rte_flow_error *error)\n+{\n+\tconst struct mlx5_flow_action_copy_mreg *conf = action->conf;\n+\tuint32_t mask = RTE_BE32(UINT32_MAX);\n+\tstruct rte_flow_item item = {\n+\t\t.spec = NULL,\n+\t\t.mask = &mask,\n+\t};\n+\tstruct field_modify_info reg_src[] = {\n+\t\t{4, 0, reg_to_field[conf->src]},\n+\t\t{0, 0, 0},\n+\t};\n+\tstruct field_modify_info reg_dst = {\n+\t\t.offset = (uint32_t)-1, /* Same as src. */\n+\t\t.id = reg_to_field[conf->dst],\n+\t};\n+\treturn flow_dv_convert_modify_action(&item,\n+\t\t\t\t\t reg_src, ®_dst, res,\n+\t\t\t\t\t MLX5_MODIFICATION_TYPE_COPY,\n+\t\t\t\t\t error);\n+}\n+\n+/**\n * Validate META item.\n *\n * @param[in] dev\n@@ -3949,6 +3990,7 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t\t\t\tMLX5_FLOW_ACTION_DEC_TCP_ACK;\n \t\t\tbreak;\n \t\tcase MLX5_RTE_FLOW_ACTION_TYPE_TAG:\n+\t\tcase MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG:\n \t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n@@ -5945,6 +5987,12 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t\treturn -rte_errno;\n \t\t\taction_flags |= MLX5_FLOW_ACTION_SET_TAG;\n \t\t\tbreak;\n+\t\tcase MLX5_RTE_FLOW_ACTION_TYPE_COPY_MREG:\n+\t\t\tif (flow_dv_convert_action_copy_mreg(dev, &res,\n+\t\t\t\t\t\t\t actions, error))\n+\t\t\t\treturn -rte_errno;\n+\t\t\taction_flags |= MLX5_FLOW_ACTION_SET_TAG;\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_END:\n \t\t\tactions_end = true;\n \t\t\tif (action_flags & MLX5_FLOW_MODIFY_HDR_ACTIONS) {\n", "prefixes": [ "03/20" ] }