Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62234/?format=api
{ "id": 62234, "url": "http://patches.dpdk.org/api/patches/62234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191030162651.3001-3-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191030162651.3001-3-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191030162651.3001-3-pbhagavatula@marvell.com", "date": "2019-10-30T16:26:43", "name": "[v8,02/10] examples/l2fwd-event: add infra for eventdev", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8863b5704b85343646e79ccc048a7bb6beb176e7", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191030162651.3001-3-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 7162, "url": "http://patches.dpdk.org/api/series/7162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7162", "date": "2019-10-30T16:26:41", "name": "example/l2fwd-event: introduce l2fwd-event example", "version": 8, "mbox": "http://patches.dpdk.org/series/7162/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62234/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62234/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 937D9A00BE;\n\tWed, 30 Oct 2019 17:27:19 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D79941C0C1;\n\tWed, 30 Oct 2019 17:27:06 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 1FD921C0B7\n for <dev@dpdk.org>; Wed, 30 Oct 2019 17:27:04 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n x9UGEd8F018526; Wed, 30 Oct 2019 09:27:04 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 2vxwjm3gdd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 30 Oct 2019 09:27:04 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 30 Oct\n 2019 09:27:02 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n Transport; Wed, 30 Oct 2019 09:27:03 -0700", "from BG-LT7430.marvell.com (unknown [10.28.17.33])\n by maili.marvell.com (Postfix) with ESMTP id C60B33F703F;\n Wed, 30 Oct 2019 09:26:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0818;\n bh=aOhSVzFqj9q/QTbhPFZfj9mqaUrbx16OV7W7BXXDcmw=;\n b=cZDEhYUp+4PtpWGDtHviGzMCXfeGzYn+kQHqbwnl58bvcpIAiCSkX5ytOp8Y/Ru5CfTg\n Za9zQdx0y/XvHq7xo0ku1C5Dkqmxuc3d/rxdYXvXS5R3+MmxF9++dJ9X6K7ZwtQ07Vj0\n r6a+FgFwK2hcX8VORaCxb0Rb0RzsOMaWqukfU7VP2vJVDMaE0//cPHk7kWGe/qvsVzPD\n 23YiAYT8aW0V5eRHbwk6G9+yR6lQFtCV0creWG5aQQWWubcXhMeOsR7KwuCRHu7zRZG2\n 5lzeCCf3Oyl09Vx7tOij0HHFOUbQ8tC5qmpeOsT4TxIwgUycAk/mSuPZ3Nn1W9qpKRT1 lA==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam\n <orika@mellanox.com>, Bruce Richardson <bruce.richardson@intel.com>, \"Radu\n Nicolau\" <radu.nicolau@intel.com>, Akhil Goyal <akhil.goyal@nxp.com>,\n \"Tomasz Kantecki\" <tomasz.kantecki@intel.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>", "CC": "<dev@dpdk.org>", "Date": "Wed, 30 Oct 2019 21:56:43 +0530", "Message-ID": "<20191030162651.3001-3-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191030162651.3001-1-pbhagavatula@marvell.com>", "References": "<20191030162651.3001-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n definitions=2019-10-30_07:2019-10-30,2019-10-30 signatures=0", "Subject": "[dpdk-dev] [PATCH v8 02/10] examples/l2fwd-event: add infra for\n\teventdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd infra to select event device as a mode to process packets through\ncommand line arguments. Also, allow the user to select the schedule type\nto be RTE_SCHED_TYPE_ORDERED, RTE_SCHED_TYPE_ATOMIC or\nRTE_SCHED_TYPE_PARALLEL.\n\nUsage:\n\n`--mode=\"eventdev\"` or `--mode=\"poll\"`\n`--eventq-sched=\"ordered\"`, `--eventq-sched=\"atomic\"` or\n`--event-sched=parallel`\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n examples/l2fwd-event/Makefile | 1 +\n examples/l2fwd-event/l2fwd_common.h | 4 +++\n examples/l2fwd-event/l2fwd_event.c | 34 +++++++++++++++++++\n examples/l2fwd-event/l2fwd_event.h | 21 ++++++++++++\n examples/l2fwd-event/main.c | 52 +++++++++++++++++++++++++++--\n examples/l2fwd-event/meson.build | 1 +\n 6 files changed, 111 insertions(+), 2 deletions(-)\n create mode 100644 examples/l2fwd-event/l2fwd_event.c\n create mode 100644 examples/l2fwd-event/l2fwd_event.h", "diff": "diff --git a/examples/l2fwd-event/Makefile b/examples/l2fwd-event/Makefile\nindex 73f02dd3b..08ba1835d 100644\n--- a/examples/l2fwd-event/Makefile\n+++ b/examples/l2fwd-event/Makefile\n@@ -8,6 +8,7 @@ APP = l2fwd-event\n # all source are stored in SRCS-y\n SRCS-y := main.c\n SRCS-y += l2fwd_poll.c\n+SRCS-y += l2fwd_event.c\n SRCS-y += l2fwd_common.c\n \n # Build using pkg-config variables if possible\ndiff --git a/examples/l2fwd-event/l2fwd_common.h b/examples/l2fwd-event/l2fwd_common.h\nindex 7b74f92b3..a4e17ab97 100644\n--- a/examples/l2fwd-event/l2fwd_common.h\n+++ b/examples/l2fwd-event/l2fwd_common.h\n@@ -65,6 +65,8 @@ struct l2fwd_port_statistics {\n \n struct l2fwd_resources {\n \tvolatile uint8_t force_quit;\n+\tuint8_t event_mode;\n+\tuint8_t sched_type;\n \tuint8_t mac_updating;\n \tuint8_t rx_queue_per_lcore;\n \tuint16_t nb_rxd;\n@@ -75,6 +77,7 @@ struct l2fwd_resources {\n \tuint32_t dst_ports[RTE_MAX_ETHPORTS];\n \tstruct rte_ether_addr eth_addr[RTE_MAX_ETHPORTS];\n \tstruct l2fwd_port_statistics port_stats[RTE_MAX_ETHPORTS];\n+\tvoid *evt_rsrc;\n \tvoid *poll_rsrc;\n } __rte_cache_aligned;\n \n@@ -112,6 +115,7 @@ l2fwd_get_rsrc(void)\n \t\tmemset(rsrc, 0, sizeof(struct l2fwd_resources));\n \t\trsrc->mac_updating = true;\n \t\trsrc->rx_queue_per_lcore = 1;\n+\t\trsrc->sched_type = RTE_SCHED_TYPE_ATOMIC;\n \t\trsrc->timer_period = 10 * rte_get_timer_hz();\n \n \t\treturn mz->addr;\ndiff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c\nnew file mode 100644\nindex 000000000..48d32d718\n--- /dev/null\n+++ b/examples/l2fwd-event/l2fwd_event.c\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#include <stdbool.h>\n+#include <getopt.h>\n+\n+#include <rte_atomic.h>\n+#include <rte_cycles.h>\n+#include <rte_ethdev.h>\n+#include <rte_eventdev.h>\n+#include <rte_event_eth_rx_adapter.h>\n+#include <rte_event_eth_tx_adapter.h>\n+#include <rte_lcore.h>\n+#include <rte_malloc.h>\n+#include <rte_spinlock.h>\n+\n+#include \"l2fwd_event.h\"\n+\n+void\n+l2fwd_event_resource_setup(struct l2fwd_resources *rsrc)\n+{\n+\tstruct l2fwd_event_resources *evt_rsrc;\n+\n+\tif (!rte_event_dev_count())\n+\t\trte_panic(\"No Eventdev found\\n\");\n+\n+\tevt_rsrc = rte_zmalloc(\"l2fwd_event\",\n+\t\t\t\t sizeof(struct l2fwd_event_resources), 0);\n+\tif (evt_rsrc == NULL)\n+\t\trte_panic(\"Failed to allocate memory\\n\");\n+\n+\trsrc->evt_rsrc = evt_rsrc;\n+}\ndiff --git a/examples/l2fwd-event/l2fwd_event.h b/examples/l2fwd-event/l2fwd_event.h\nnew file mode 100644\nindex 000000000..9a1bb1612\n--- /dev/null\n+++ b/examples/l2fwd-event/l2fwd_event.h\n@@ -0,0 +1,21 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(C) 2019 Marvell International Ltd.\n+ */\n+\n+#ifndef __L2FWD_EVENT_H__\n+#define __L2FWD_EVENT_H__\n+\n+#include <rte_common.h>\n+#include <rte_event_eth_rx_adapter.h>\n+#include <rte_event_eth_tx_adapter.h>\n+#include <rte_mbuf.h>\n+#include <rte_spinlock.h>\n+\n+#include \"l2fwd_common.h\"\n+\n+struct l2fwd_event_resources {\n+};\n+\n+void l2fwd_event_resource_setup(struct l2fwd_resources *rsrc);\n+\n+#endif /* __L2FWD_EVENT_H__ */\ndiff --git a/examples/l2fwd-event/main.c b/examples/l2fwd-event/main.c\nindex a4e41ddb4..2a1fe4e11 100644\n--- a/examples/l2fwd-event/main.c\n+++ b/examples/l2fwd-event/main.c\n@@ -2,6 +2,7 @@\n * Copyright(C) 2019 Marvell International Ltd.\n */\n \n+#include \"l2fwd_event.h\"\n #include \"l2fwd_poll.h\"\n \n /* display usage */\n@@ -16,7 +17,12 @@ l2fwd_event_usage(const char *prgname)\n \t \" --[no-]mac-updating: Enable or disable MAC addresses updating (enabled by default)\\n\"\n \t \" When enabled:\\n\"\n \t \" - The source MAC address is replaced by the TX port MAC address\\n\"\n-\t \" - The destination MAC address is replaced by 02:00:00:00:00:TX_PORT_ID\\n\",\n+\t \" - The destination MAC address is replaced by 02:00:00:00:00:TX_PORT_ID\\n\"\n+\t \" --mode: Packet transfer mode for I/O, poll or eventdev\\n\"\n+\t \" Default mode = eventdev\\n\"\n+\t \" --eventq-sched: Event queue schedule type, ordered, atomic or parallel.\\n\"\n+\t \" Default: atomic\\n\"\n+\t \" Valid only if --mode=eventdev\\n\\n\",\n \t prgname);\n }\n \n@@ -71,6 +77,28 @@ l2fwd_event_parse_timer_period(const char *q_arg)\n \treturn n;\n }\n \n+static void\n+l2fwd_event_parse_mode(const char *optarg,\n+\t\t struct l2fwd_resources *rsrc)\n+{\n+\tif (!strncmp(optarg, \"poll\", 4))\n+\t\trsrc->event_mode = false;\n+\telse if (!strncmp(optarg, \"eventdev\", 8))\n+\t\trsrc->event_mode = true;\n+}\n+\n+static void\n+l2fwd_event_parse_eventq_sched(const char *optarg,\n+\t\t\t struct l2fwd_resources *rsrc)\n+{\n+\tif (!strncmp(optarg, \"ordered\", 7))\n+\t\trsrc->sched_type = RTE_SCHED_TYPE_ORDERED;\n+\telse if (!strncmp(optarg, \"atomic\", 6))\n+\t\trsrc->sched_type = RTE_SCHED_TYPE_ATOMIC;\n+\telse if (!strncmp(optarg, \"parallel\", 8))\n+\t\trsrc->sched_type = RTE_SCHED_TYPE_PARALLEL;\n+}\n+\n static const char short_options[] =\n \t\"p:\" /* portmask */\n \t\"q:\" /* number of queues */\n@@ -79,6 +107,8 @@ static const char short_options[] =\n \n #define CMD_LINE_OPT_MAC_UPDATING \"mac-updating\"\n #define CMD_LINE_OPT_NO_MAC_UPDATING \"no-mac-updating\"\n+#define CMD_LINE_OPT_MODE \"mode\"\n+#define CMD_LINE_OPT_EVENTQ_SCHED \"eventq-sched\"\n \n enum {\n \t/* long options mapped to a short option */\n@@ -87,6 +117,8 @@ enum {\n \t * conflict with short options\n \t */\n \tCMD_LINE_OPT_MIN_NUM = 256,\n+\tCMD_LINE_OPT_MODE_NUM,\n+\tCMD_LINE_OPT_EVENTQ_SCHED_NUM,\n };\n \n /* Parse the argument given in the command line of the application */\n@@ -98,6 +130,10 @@ l2fwd_event_parse_args(int argc, char **argv,\n \tstruct option lgopts[] = {\n \t\t{ CMD_LINE_OPT_MAC_UPDATING, no_argument, &mac_updating, 1},\n \t\t{ CMD_LINE_OPT_NO_MAC_UPDATING, no_argument, &mac_updating, 0},\n+\t\t{ CMD_LINE_OPT_MODE, required_argument, NULL,\n+\t\t\t\t\t\t\tCMD_LINE_OPT_MODE_NUM},\n+\t\t{ CMD_LINE_OPT_EVENTQ_SCHED, required_argument, NULL,\n+\t\t\t\t\t\tCMD_LINE_OPT_EVENTQ_SCHED_NUM},\n \t\t{NULL, 0, 0, 0}\n \t};\n \tint opt, ret, timer_secs;\n@@ -145,6 +181,14 @@ l2fwd_event_parse_args(int argc, char **argv,\n \t\t\trsrc->timer_period *= rte_get_timer_hz();\n \t\t\tbreak;\n \n+\t\tcase CMD_LINE_OPT_MODE_NUM:\n+\t\t\tl2fwd_event_parse_mode(optarg, rsrc);\n+\t\t\tbreak;\n+\n+\t\tcase CMD_LINE_OPT_EVENTQ_SCHED_NUM:\n+\t\t\tl2fwd_event_parse_eventq_sched(optarg, rsrc);\n+\t\t\tbreak;\n+\n \t\t/* long options */\n \t\tcase 0:\n \t\t\tbreak;\n@@ -404,7 +448,11 @@ main(int argc, char **argv)\n \tif (!nb_ports_available)\n \t\trte_panic(\"All available ports are disabled. Please set portmask.\\n\");\n \n-\tl2fwd_poll_resource_setup(rsrc);\n+\t/* Configure eventdev parameters if required */\n+\tif (rsrc->event_mode)\n+\t\tl2fwd_event_resource_setup(rsrc);\n+\telse\n+\t\tl2fwd_poll_resource_setup(rsrc);\n \n \t/* initialize port stats */\n \tmemset(&rsrc->port_stats, 0,\ndiff --git a/examples/l2fwd-event/meson.build b/examples/l2fwd-event/meson.build\nindex c936aa72e..c1ae2037c 100644\n--- a/examples/l2fwd-event/meson.build\n+++ b/examples/l2fwd-event/meson.build\n@@ -12,4 +12,5 @@ sources = files(\n \t'main.c',\n \t'l2fwd_poll.c',\n \t'l2fwd_common.c',\n+\t'l2fwd_event.c',\n )\n", "prefixes": [ "v8", "02/10" ] }