Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62222/?format=api
{ "id": 62222, "url": "http://patches.dpdk.org/api/patches/62222/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191030120955.26904-10-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191030120955.26904-10-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191030120955.26904-10-nipun.gupta@nxp.com", "date": "2019-10-30T12:09:55", "name": "[9/9,v3] bus/fslmc: sanitize device name parsing for clarity", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "181433fe85bc8a2f1d6de0b80fe05c2d2adb42c2", "submitter": { "id": 471, "url": "http://patches.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191030120955.26904-10-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 7158, "url": "http://patches.dpdk.org/api/series/7158/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7158", "date": "2019-10-30T12:09:46", "name": "DPAA and FSLMC driver fixes and cleanup", "version": 3, "mbox": "http://patches.dpdk.org/series/7158/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62222/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 50DE2A00BE;\n\tWed, 30 Oct 2019 13:27:32 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 906711C10E;\n\tWed, 30 Oct 2019 13:26:54 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by dpdk.org (Postfix) with ESMTP id 226641C06A\n for <dev@dpdk.org>; Wed, 30 Oct 2019 13:26:14 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D68C22007C1;\n Wed, 30 Oct 2019 13:26:13 +0100 (CET)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n [165.114.16.14])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DF2682007EA;\n Wed, 30 Oct 2019 13:26:10 +0100 (CET)", "from GDB1.ap.freescale.net (gdb1.ap.freescale.net [10.232.132.179])\n by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 3A63C40309;\n Wed, 30 Oct 2019 20:26:07 +0800 (SGT)" ], "From": "Nipun Gupta <nipun.gupta@nxp.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n sachin.saxena@nxp.com, Shreyansh Jain <shreyansh.jain@nxp.com>", "Date": "Wed, 30 Oct 2019 17:39:55 +0530", "Message-Id": "<20191030120955.26904-10-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191030120955.26904-1-nipun.gupta@nxp.com>", "References": "<20191011054657.21931-1-nipun.gupta@nxp.com>\n <20191030120955.26904-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 9/9 v3] bus/fslmc: sanitize device name parsing\n\tfor clarity", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shreyansh Jain <shreyansh.jain@nxp.com>\n\nremove unnecessary dup and free\n\nSigned-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>\nReviewed-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/fslmc/fslmc_bus.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex 4116552c6..b3e964aa9 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -235,8 +235,9 @@ rte_fslmc_parse(const char *name, void *addr)\n {\n \tuint16_t dev_id;\n \tchar *t_ptr;\n-\tchar *sep = NULL;\n+\tconst char *sep;\n \tuint8_t sep_exists = 0;\n+\tint ret = -1;\n \n \tDPAA2_BUS_DEBUG(\"Parsing dev=(%s)\", name);\n \n@@ -266,10 +267,11 @@ rte_fslmc_parse(const char *name, void *addr)\n \t\t} else {\n \t\t\tDPAA2_BUS_DEBUG(\"Invalid device for matching (%s).\",\n \t\t\t\t\tname);\n+\t\t\tret = -EINVAL;\n \t\t\tgoto err_out;\n \t\t}\n \t} else\n-\t\tsep = strdup(name);\n+\t\tsep = name;\n \n jump_out:\n \t/* Validate device name */\n@@ -283,23 +285,23 @@ rte_fslmc_parse(const char *name, void *addr)\n \t strncmp(\"dpdmai\", sep, 6) &&\n \t strncmp(\"dpdmux\", sep, 6)) {\n \t\tDPAA2_BUS_DEBUG(\"Unknown or unsupported device (%s)\", sep);\n+\t\tret = -EINVAL;\n \t\tgoto err_out;\n \t}\n \n \tt_ptr = strchr(sep, '.');\n \tif (!t_ptr || sscanf(t_ptr + 1, \"%hu\", &dev_id) != 1) {\n \t\tDPAA2_BUS_ERR(\"Missing device id in device name (%s)\", sep);\n+\t\tret = -EINVAL;\n \t\tgoto err_out;\n \t}\n \n \tif (addr)\n \t\tstrcpy(addr, sep);\n \n-\treturn 0;\n+\tret = 0;\n err_out:\n-\tif (!sep_exists && sep)\n-\t\tfree(sep);\n-\treturn -EINVAL;\n+\treturn ret;\n }\n \n static int\n", "prefixes": [ "9/9", "v3" ] }