Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62178/?format=api
{ "id": 62178, "url": "http://patches.dpdk.org/api/patches/62178/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191029185051.32203-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191029185051.32203-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20191029185051.32203-4-thomas@monjalon.net", "date": "2019-10-29T18:50:51", "name": "[v2,3/3] net/mlx5: set VF MAC address from host", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "ebcbede4e100f2415b411b45671cb9d19801ac2b", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191029185051.32203-4-thomas@monjalon.net/mbox/", "series": [ { "id": 7132, "url": "http://patches.dpdk.org/api/series/7132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7132", "date": "2019-10-29T18:50:48", "name": "ethdev: configure SR-IOV VF from host", "version": 2, "mbox": "http://patches.dpdk.org/series/7132/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62178/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC741A00BE;\n\tTue, 29 Oct 2019 19:51:28 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0B351BFB8;\n\tTue, 29 Oct 2019 19:51:15 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 15E491BFB5\n for <dev@dpdk.org>; Tue, 29 Oct 2019 19:51:14 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.nyi.internal (Postfix) with ESMTP id B049D20D2B;\n Tue, 29 Oct 2019 14:51:13 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute1.internal (MEProxy); Tue, 29 Oct 2019 14:51:13 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id DD7B3D6006B;\n Tue, 29 Oct 2019 14:51:12 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=mesmtp; bh=tT5rfB5Lod\n IUP3znJmWrUJxUFMWSINKfc2yZApapFDI=; b=Q5tY8Tf2nFSB1ajv0PNGS1+svN\n 2vGP91ekFrzEUOVm+eLeY7PcjCdQSKCFiurUTNG1M3cEpRtNfZFqueY1liyLih0T\n IhTFH1tV9UElUXJEcioA+ZVi6/P8H9kU3zH0gE5aReEo8WWynev15OEF+DmprQFj\n e3RY7ISMDtkmqg6eo=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm1; bh=tT5rfB5LodIUP3znJmWrUJxUFMWSINKfc2yZApapFDI=; b=qRFN4ftC\n aZCI+jjcFSiVbRQwKNQ53GYdwMSKNDQfPpgLldl5wjBRoOewlXLJrDXTVZ87+Xgu\n j5DvaxVDmw31ZiGmOdPoCpJcCBSB5nPanh7Y6x6gwU7G23RpFO/DPke0LqidHbAB\n YIeSd7vrHQSil9VR9HnIEZiPpNj4lokiC4mOkwemRDcFc/VqzQIvA2PfJzT34+Jh\n vR+cc1hW3F8Uf8fCJkZQMx2lMb0dg9Ms3E0CsaHJrQLp/WHcMNw0xcbzF0QK8Q+s\n D5eUFXARxcFc4GJw2FS6QvIqWIeGERUYJUo7JXO7vrmvjjYEUVsHIYuRoeG63+h+\n xtREH54cbzxZDQ==" ], "X-ME-Sender": "<xms:IYq4XfTVSP9HX1V_4h1U7_tfpRaxh6CzSPSp7q4K5jUwunlDsydhgA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedufedruddtuddgudduiecutefuodetggdotefrod\n ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh\n necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht\n hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgepfe", "X-ME-Proxy": "<xmx:IYq4XYbJ4-6vOhVH1CLhkB_3TKwV2bXSlH6IE_4ECovbnvujq5M_Hg>\n <xmx:IYq4XVA5XG9u6t24BC3dbRR668KsMIEqgy89m4wO5hd7m5sZd3IYzA>\n <xmx:IYq4XXAsROLu57vSWtd0JUgk_q2pX0PX5Z4vdJQQIqLhPpUkY3y3bA>\n <xmx:IYq4XfpschAGKAKDF4DAufd7ynoluvQIQQVi6oi5DlA8vQvYYO19PQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Matan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "Cc": "dev@dpdk.org", "Date": "Tue, 29 Oct 2019 19:50:51 +0100", "Message-Id": "<20191029185051.32203-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191029185051.32203-1-thomas@monjalon.net>", "References": "<4165509.5enYigmRGf@xps>\n <20191029185051.32203-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/3] net/mlx5: set VF MAC address from host", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Allow to configure the default MAC address of a VF\nvia its representor port in the host.\n\nThis patch is a stub to demonstrate how to implement a VF operation.\nThe real code is not implemented.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/mlx5/mlx5.c | 6 ++++++\n drivers/net/mlx5/mlx5.h | 1 +\n drivers/net/mlx5/mlx5_mac.c | 19 +++++++++++++++++++\n 3 files changed, 26 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex fac510507d..b679b5e299 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -1073,6 +1073,11 @@ const struct eth_dev_ops mlx5_dev_ops_isolate = {\n \t.get_module_eeprom = mlx5_get_module_eeprom,\n };\n \n+/* Available operations for VF connected to a representor. */\n+const struct eth_dev_ops mlx5_remote_vf_ops = {\n+\t.mac_addr_set = mlx5_vf_mac_addr_set,\n+};\n+\n /**\n * Verify and store value for device argument.\n *\n@@ -2130,6 +2135,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,\n \teth_dev->rx_pkt_burst = removed_rx_burst;\n \teth_dev->tx_pkt_burst = removed_tx_burst;\n \teth_dev->dev_ops = &mlx5_dev_ops;\n+\teth_dev->vf_ops = &mlx5_remote_vf_ops;\n \t/* Register MAC address. */\n \tclaim_zero(mlx5_mac_addr_add(eth_dev, &mac, 0, 0));\n \tif (config.vf && config.vf_nl_en)\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex b6a51b2b4d..e34a24ee7c 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -754,6 +754,7 @@ void mlx5_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index);\n int mlx5_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac,\n \t\t uint32_t index, uint32_t vmdq);\n int mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr);\n+int mlx5_vf_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac);\n int mlx5_set_mc_addr_list(struct rte_eth_dev *dev,\n \t\t\tstruct rte_ether_addr *mc_addr_set,\n \t\t\tuint32_t nb_mc_addr);\ndiff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c\nindex 0ffef5c5db..4c4dd55b86 100644\n--- a/drivers/net/mlx5/mlx5_mac.c\n+++ b/drivers/net/mlx5/mlx5_mac.c\n@@ -202,6 +202,25 @@ mlx5_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)\n \treturn mlx5_mac_addr_add(dev, mac_addr, 0, 0);\n }\n \n+/**\n+ * DPDK callback to set primary MAC address of the remote VF.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device structure of a representor.\n+ * @param mac_addr\n+ * MAC address to register in the remote VF.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int mlx5_vf_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac)\n+{\n+\tDRV_LOG(DEBUG, \"VF represented by port %u setting primary MAC address\",\n+\t\tdev->data->port_id);\n+\t/* TODO: should not be this dev but its VF */\n+\treturn mlx5_nl_mac_addr_add(dev, mac, 0);\n+}\n+\n /**\n * DPDK callback to set multicast addresses list.\n *\n", "prefixes": [ "v2", "3/3" ] }