Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62140/?format=api
{ "id": 62140, "url": "http://patches.dpdk.org/api/patches/62140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1572327203-32298-1-git-send-email-xiao.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1572327203-32298-1-git-send-email-xiao.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1572327203-32298-1-git-send-email-xiao.zhang@intel.com", "date": "2019-10-29T05:33:23", "name": "[v2] net/ixgbe:fix wrong link status", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1ac0a94d656aad7c184aae2a518cc4f4061bbd85", "submitter": { "id": 1352, "url": "http://patches.dpdk.org/api/people/1352/?format=api", "name": "Xiao Zhang", "email": "xiao.zhang@intel.com" }, "delegate": { "id": 31221, "url": "http://patches.dpdk.org/api/users/31221/?format=api", "username": "yexl", "first_name": "xiaolong", "last_name": "ye", "email": "xiaolong.ye@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1572327203-32298-1-git-send-email-xiao.zhang@intel.com/mbox/", "series": [ { "id": 7118, "url": "http://patches.dpdk.org/api/series/7118/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7118", "date": "2019-10-29T05:33:23", "name": "[v2] net/ixgbe:fix wrong link status", "version": 2, "mbox": "http://patches.dpdk.org/series/7118/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62140/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/62140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F7DAA00BE;\n\tTue, 29 Oct 2019 06:36:09 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4BE6D1BEE6;\n\tTue, 29 Oct 2019 06:36:07 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id A5B731BED7;\n Tue, 29 Oct 2019 06:36:04 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n 28 Oct 2019 22:36:03 -0700", "from npg-dpdk-zhangxiao.sh.intel.com ([10.67.110.203])\n by fmsmga005.fm.intel.com with ESMTP; 28 Oct 2019 22:36:02 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,242,1569308400\"; d=\"scan'208\";a=\"399675182\"", "From": "Xiao Zhang <xiao.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "wei.zhao1@intel.com, xiaolong.ye@intel.com,\n Xiao Zhang <xiao.zhang@intel.com>, stable@dpdk.org", "Date": "Tue, 29 Oct 2019 13:33:23 +0800", "Message-Id": "<1572327203-32298-1-git-send-email-xiao.zhang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1567425132-59486-1-git-send-email-xiao.zhang@intel.com>", "References": "<1567425132-59486-1-git-send-email-xiao.zhang@intel.com>", "Subject": "[dpdk-dev] [v2] net/ixgbe:fix wrong link status", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The link status for 82599eb got from link status register was not correct,\ncheck the enable/disable flag of tx laser when getting the link status,\nset the link status down if tx laser disabled since the tx laser flag\ncould be set correctly when up/down the link status.\n\nFixes: dc66e5fd01b9 (\"net/ixgbe: improve link state check on VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiao Zhang <xiao.zhang@intel.com>\nReviewed-by: Wei Zhao <wei.zhao1@intel.com>\n---\nv2\nRebase the patch to latest master code.\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex dbce7a8..3202c28 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2904,6 +2904,7 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev)\n \t} else {\n \t\t/* Turn on the laser */\n \t\tixgbe_enable_tx_laser(hw);\n+\t\tixgbe_dev_link_update(dev, 0);\n \t}\n \n \treturn 0;\n@@ -2934,6 +2935,7 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev)\n \t} else {\n \t\t/* Turn off the laser */\n \t\tixgbe_disable_tx_laser(hw);\n+\t\tixgbe_dev_link_update(dev, 0);\n \t}\n \n \treturn 0;\n@@ -4108,6 +4110,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tint link_up;\n \tint diag;\n \tint wait = 1;\n+\tu32 esdp_reg;\n \n \tmemset(&link, 0, sizeof(link));\n \tlink.link_status = ETH_LINK_DOWN;\n@@ -4135,6 +4138,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n+\tesdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);\n+\tif ((esdp_reg & IXGBE_ESDP_SDP3))\n+\t\tlink_up = 0;\n+\n \tif (link_up == 0) {\n \t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n \t\t\tintr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;\n", "prefixes": [ "v2" ] }