Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/62005/?format=api
{ "id": 62005, "url": "http://patches.dpdk.org/api/patches/62005/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191025152142.12887-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191025152142.12887-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191025152142.12887-1-pbhagavatula@marvell.com", "date": "2019-10-25T15:21:40", "name": "[1/2] ethdev: add flow action type update as an offload", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "4d200b0ffd4bb1f48506b459cf6f042000a97b73", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191025152142.12887-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 7076, "url": "http://patches.dpdk.org/api/series/7076/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7076", "date": "2019-10-25T15:21:40", "name": "[1/2] ethdev: add flow action type update as an offload", "version": 1, "mbox": "http://patches.dpdk.org/series/7076/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/62005/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/62005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 83F541C241;\n\tFri, 25 Oct 2019 17:21:52 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 46A621C226\n\tfor <dev@dpdk.org>; Fri, 25 Oct 2019 17:21:50 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx9PFBLhx024615; Fri, 25 Oct 2019 08:21:49 -0700", "from sc-exch04.marvell.com ([199.233.58.184])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2vt9ujvbhp-2\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tFri, 25 Oct 2019 08:21:49 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com\n\t(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tFri, 25 Oct 2019 08:21:47 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Fri, 25 Oct 2019 08:21:47 -0700", "from BG-LT7430.marvell.com (unknown [10.28.17.85])\n\tby maili.marvell.com (Postfix) with ESMTP id 10B883F703F;\n\tFri, 25 Oct 2019 08:21:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : mime-version :\n\tcontent-transfer-encoding : content-type; s=pfpt0818;\n\tbh=EfeQUEWsOg35r+NQ0P/nCBrebPbqcM4zFGT8bvZx3iM=; \n\tb=OHFFQtQBo/WtEomMhb5GnOvcZK+zSuaTYV1l5R1+na+wayXFg81x0Is/fHxZZYXpvNoS\n\tlXLNHILFRNu06zVj2gDasswpTWOSVbmgtTVwsyn6Q+7wXKsPEh+NsRHcaVDL3JilXcEQ\n\tAAEuf8RQaSDyDWm0owqkX6lcU9KyLBXEVu0lL6+6j5SsaH0B0K91V4q6iSv7Pl6q+6Bg\n\tzPNKZLzZ9jIByy5wDb4PeBitbAVOcH6M8lLczct0J4vpEL1757ZO3mw61dGHmtMp6ms5\n\tFQz5ikEOWn+eMUPlxWcMvTNYYKQlEy1XEk3VvjSylQUAuZFa+nbqQ3zhZ+rz0kfjJfb/\n\tyg== ", "From": "<pbhagavatula@marvell.com>", "To": "<ferruh.yigit@intel.com>, <arybchenko@solarflare.com>,\n\t<jerinj@marvell.com>, John McNamara <john.mcnamara@intel.com>, \"Marko\n\tKovacevic\" <marko.kovacevic@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Adrien Mazarguil <adrien.mazarguil@6wind.com>", "CC": "<dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>", "Date": "Fri, 25 Oct 2019 20:51:40 +0530", "Message-ID": "<20191025152142.12887-1-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n\tdefinitions=2019-10-25_08:2019-10-25,2019-10-25 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an\n\toffload", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nAdd new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to\nenable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and\n`rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and\n`RTE_FLOW_ACTION_FLAG` are enabled.\n\nPMDs notify the validity of `rte_mbuf::hash:fdir::hi` to the applcation\nby enabling `PKT_RX_FDIR_ID` flag in `rte_mbuf::ol_flags`.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features.rst | 12 ++++++++++++\n doc/guides/rel_notes/release_19_11.rst | 9 +++++++++\n lib/librte_ethdev/rte_ethdev.c | 1 +\n lib/librte_ethdev/rte_ethdev.h | 1 +\n lib/librte_ethdev/rte_flow.h | 6 ++++--\n 5 files changed, 27 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst\nindex d96696801..0d8d08c18 100644\n--- a/doc/guides/nics/features.rst\n+++ b/doc/guides/nics/features.rst\n@@ -588,6 +588,18 @@ Supports packet type parsing and returns a list of supported types.\n * **[related] API**: ``rte_eth_dev_get_supported_ptypes()``.\n \n \n+.. _nic_features_flow_flag_mark:\n+\n+Flow flag/mark update\n+---------------------\n+\n+Supports flow action type update to ``mbuf.ol_flags`` and ``mbuf.hash.fdir.hi``.\n+\n+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_FLOW_MARK``.\n+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_FDIR``, ``mbuf.ol_flags:PKT_RX_FDIR_ID;``,\n+ ``mbuf.hash.fdir.hi``\n+\n+\n .. _nic_features_timesync:\n \n Timesync\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex faf69b0d9..8593fea0e 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -185,6 +185,15 @@ New Features\n * Added a console command to testpmd app, ``show port (port_id) ptypes`` which\n gives ability to print port supported ptypes in different protocol layers.\n \n+* **Added Rx offload flag to enable or disable flow action type update**\n+\n+ * Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to\n+ enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and\n+ `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and\n+ `RTE_FLOW_ACTION_FLAG` are enabled.\n+ * PMDs notify the validity of `rte_mbuf::hash:fdir::hi` to the application\n+ by enabling `PKT_RX_FDIR_ID` flag in `rte_mbuf::ol_flags`.\n+\n \n Removed Items\n -------------\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 7743205d3..f70065043 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -129,6 +129,7 @@ static const struct {\n \tRTE_RX_OFFLOAD_BIT2STR(KEEP_CRC),\n \tRTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),\n \tRTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),\n+\tRTE_RX_OFFLOAD_BIT2STR(FLOW_MARK),\n };\n \n #undef RTE_RX_OFFLOAD_BIT2STR\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex c36c1b631..c4e626da7 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -1048,6 +1048,7 @@ struct rte_eth_conf {\n #define DEV_RX_OFFLOAD_KEEP_CRC\t\t0x00010000\n #define DEV_RX_OFFLOAD_SCTP_CKSUM\t0x00020000\n #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000\n+#define DEV_RX_OFFLOAD_FLOW_MARK\t0x00100000\n \n #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n \t\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\ndiff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex 4fee10559..6698640fb 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -1538,7 +1538,8 @@ enum rte_flow_action_type {\n \n \t/**\n \t * Attaches an integer value to packets and sets PKT_RX_FDIR and\n-\t * PKT_RX_FDIR_ID mbuf flags.\n+\t * PKT_RX_FDIR_ID mbuf flags when\n+\t * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is enabled.\n \t *\n \t * See struct rte_flow_action_mark.\n \t */\n@@ -1546,7 +1547,8 @@ enum rte_flow_action_type {\n \n \t/**\n \t * Flags packets. Similar to MARK without a specific value; only\n-\t * sets the PKT_RX_FDIR mbuf flag.\n+\t * sets the PKT_RX_FDIR mbuf flag when\n+\t * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is enabled.\n \t *\n \t * No associated configuration structure.\n \t */\n", "prefixes": [ "1/2" ] }