Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61989/?format=api
{ "id": 61989, "url": "http://patches.dpdk.org/api/patches/61989/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1572011772-23271-10-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1572011772-23271-10-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1572011772-23271-10-git-send-email-david.marchand@redhat.com", "date": "2019-10-25T13:56:08", "name": "[v3,09/12] eal: deinline lcore APIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7d205bda4b1261f529137aad92a8065c34c01442", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1572011772-23271-10-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 7072, "url": "http://patches.dpdk.org/api/series/7072/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7072", "date": "2019-10-25T13:55:59", "name": "EAL and PCI ABI changes for 19.11", "version": 3, "mbox": "http://patches.dpdk.org/series/7072/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61989/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/61989/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A55C51C2A3;\n\tFri, 25 Oct 2019 15:57:11 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n\t[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 57AA91C25E\n\tfor <dev@dpdk.org>; Fri, 25 Oct 2019 15:57:04 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-253-84ZdfKyrOhSGYl4WLNodHg-1; Fri, 25 Oct 2019 09:57:02 -0400", "from smtp.corp.redhat.com\n\t(int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B2201005509;\n\tFri, 25 Oct 2019 13:57:01 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1411E10013A1;\n\tFri, 25 Oct 2019 13:56:58 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1572011823;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=KnY2Y51SevAsP+9NEJ90fDewZjRPOJvtI+2I5mhre2c=;\n\tb=OzgR1r+FHUONC3Kp3q0m7EKhslm7AX6XkCnBATopmMeY6lVv4NJdIXlO8Jubx0kLwv1xwF\n\tM4Wi5pNF/kkwBJ3Hov6gvEJhF40Tx91p5i2gkibEgEX+J+Nrkkp3wsgBI9whz4JJqYlUOX\n\tXcMa8m8CUKT/k7EiSm0Jp+7dm0HtobE=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, ktraynor@redhat.com", "Date": "Fri, 25 Oct 2019 15:56:08 +0200", "Message-Id": "<1572011772-23271-10-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1572011772-23271-1-git-send-email-david.marchand@redhat.com>", "References": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>\n\t<1572011772-23271-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "X-MC-Unique": "84ZdfKyrOhSGYl4WLNodHg-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=WINDOWS-1252", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v3 09/12] eal: deinline lcore APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Those functions are used to setup or take control decisions.\nMove them into the EAL common code and put them directly in the stable\nABI.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_eal/common/eal_common_lcore.c | 38 ++++++++++++++++++++++++++++\n lib/librte_eal/common/include/rte_lcore.h | 41 +++----------------------------\n lib/librte_eal/rte_eal_version.map | 10 ++++++++\n 3 files changed, 52 insertions(+), 37 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/librte_eal/common/eal_common_lcore.c\nindex 59a2fd1..b01a210 100644\n--- a/lib/librte_eal/common/eal_common_lcore.c\n+++ b/lib/librte_eal/common/eal_common_lcore.c\n@@ -16,6 +16,16 @@\n #include \"eal_private.h\"\n #include \"eal_thread.h\"\n \n+unsigned int rte_get_master_lcore(void)\n+{\n+\treturn rte_eal_get_configuration()->master_lcore;\n+}\n+\n+unsigned int rte_lcore_count(void)\n+{\n+\treturn rte_eal_get_configuration()->lcore_count;\n+}\n+\n int rte_lcore_index(int lcore_id)\n {\n \tif (unlikely(lcore_id >= RTE_MAX_LCORE))\n@@ -43,6 +53,34 @@ rte_cpuset_t rte_lcore_cpuset(unsigned int lcore_id)\n \treturn lcore_config[lcore_id].cpuset;\n }\n \n+int rte_lcore_is_enabled(unsigned int lcore_id)\n+{\n+\tstruct rte_config *cfg = rte_eal_get_configuration();\n+\n+\tif (lcore_id >= RTE_MAX_LCORE)\n+\t\treturn 0;\n+\treturn cfg->lcore_role[lcore_id] == ROLE_RTE;\n+}\n+\n+unsigned int rte_get_next_lcore(unsigned int i, int skip_master, int wrap)\n+{\n+\ti++;\n+\tif (wrap)\n+\t\ti %= RTE_MAX_LCORE;\n+\n+\twhile (i < RTE_MAX_LCORE) {\n+\t\tif (!rte_lcore_is_enabled(i) ||\n+\t\t (skip_master && (i == rte_get_master_lcore()))) {\n+\t\t\ti++;\n+\t\t\tif (wrap)\n+\t\t\t\ti %= RTE_MAX_LCORE;\n+\t\t\tcontinue;\n+\t\t}\n+\t\tbreak;\n+\t}\n+\treturn i;\n+}\n+\n unsigned int\n rte_lcore_to_socket_id(unsigned int lcore_id)\n {\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex 0c68391..ea40c25 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -93,11 +93,7 @@ rte_lcore_id(void)\n * @return\n * the id of the master lcore\n */\n-static inline unsigned\n-rte_get_master_lcore(void)\n-{\n-\treturn rte_eal_get_configuration()->master_lcore;\n-}\n+unsigned int rte_get_master_lcore(void);\n \n /**\n * Return the number of execution units (lcores) on the system.\n@@ -105,12 +101,7 @@ rte_get_master_lcore(void)\n * @return\n * the number of execution units (lcores) on the system.\n */\n-static inline unsigned\n-rte_lcore_count(void)\n-{\n-\tconst struct rte_config *cfg = rte_eal_get_configuration();\n-\treturn cfg->lcore_count;\n-}\n+unsigned int rte_lcore_count(void);\n \n /**\n * Return the index of the lcore starting from zero.\n@@ -215,14 +206,7 @@ rte_lcore_cpuset(unsigned int lcore_id);\n * @return\n * True if the given lcore is enabled; false otherwise.\n */\n-static inline int\n-rte_lcore_is_enabled(unsigned int lcore_id)\n-{\n-\tstruct rte_config *cfg = rte_eal_get_configuration();\n-\tif (lcore_id >= RTE_MAX_LCORE)\n-\t\treturn 0;\n-\treturn cfg->lcore_role[lcore_id] == ROLE_RTE;\n-}\n+int rte_lcore_is_enabled(unsigned int lcore_id);\n \n /**\n * Get the next enabled lcore ID.\n@@ -237,25 +221,8 @@ rte_lcore_is_enabled(unsigned int lcore_id)\n * @return\n * The next lcore_id or RTE_MAX_LCORE if not found.\n */\n-static inline unsigned int\n-rte_get_next_lcore(unsigned int i, int skip_master, int wrap)\n-{\n-\ti++;\n-\tif (wrap)\n-\t\ti %= RTE_MAX_LCORE;\n+unsigned int rte_get_next_lcore(unsigned int i, int skip_master, int wrap);\n \n-\twhile (i < RTE_MAX_LCORE) {\n-\t\tif (!rte_lcore_is_enabled(i) ||\n-\t\t (skip_master && (i == rte_get_master_lcore()))) {\n-\t\t\ti++;\n-\t\t\tif (wrap)\n-\t\t\t\ti %= RTE_MAX_LCORE;\n-\t\t\tcontinue;\n-\t\t}\n-\t\tbreak;\n-\t}\n-\treturn i;\n-}\n /**\n * Macro to browse all running lcores.\n */\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 6d7e0e4..d88649e 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -310,6 +310,16 @@ DPDK_19.08 {\n \n } DPDK_19.05;\n \n+DPDK_19.11 {\n+\tglobal:\n+\n+\trte_get_master_lcore;\n+\trte_get_next_lcore;\n+\trte_lcore_count;\n+\trte_lcore_is_enabled;\n+\n+} DPDK_19.08;\n+\n EXPERIMENTAL {\n \tglobal:\n \n", "prefixes": [ "v3", "09/12" ] }