Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61915/?format=api
{ "id": 61915, "url": "http://patches.dpdk.org/api/patches/61915/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com", "date": "2019-10-24T15:17:57", "name": "[v2,2/2] eal: use define instead of raw flag name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ed9cf691915d76fa0f564b4ff184898e9281b0bd", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 7053, "url": "http://patches.dpdk.org/api/series/7053/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7053", "date": "2019-10-24T15:17:56", "name": "[v2,1/2] eal/freebsd: add support for base virtaddr option", "version": 2, "mbox": "http://patches.dpdk.org/series/7053/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61915/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/61915/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E06FD1EB5B;\n\tThu, 24 Oct 2019 17:18:05 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 213C51EB49\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 17:18:01 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Oct 2019 08:18:01 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Oct 2019 08:18:00 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,225,1569308400\"; d=\"scan'208\";a=\"228550976\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net,\n\tdavid.marchand@redhat.com", "Date": "Thu, 24 Oct 2019 16:17:57 +0100", "Message-Id": "<41c41b7a73cea7f574bc709e1fb1cd4eed4c72e3.1571930271.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<c484c4f62e188f0f2524d26faabe8558b3ad3816.1571930271.git.anatoly.burakov@intel.com>", "<26384fad6f9afcba9d3311d1bf73e76f4577225d.1563276298.git.anatoly.burakov@intel.com>" ], "References": [ "<c484c4f62e188f0f2524d26faabe8558b3ad3816.1571930271.git.anatoly.burakov@intel.com>", "<26384fad6f9afcba9d3311d1bf73e76f4577225d.1563276298.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 2/2] eal: use define instead of raw flag name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are using '--base-virtaddr' in a few places. We have a define for that,\nso use it instead.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/freebsd/eal/eal.c | 3 ++-\n lib/librte_eal/freebsd/eal/eal_memory.c | 5 ++++-\n lib/librte_eal/linux/eal/eal.c | 4 ++--\n lib/librte_eal/linux/eal/eal_memory.c | 3 ++-\n 4 files changed, 10 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex c7e1264205..14e1713294 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -345,7 +345,8 @@ rte_eal_config_reattach(void)\n \t\tif (mem_config != MAP_FAILED) {\n \t\t\t/* errno is stale, don't use */\n \t\t\tRTE_LOG(ERR, EAL, \"Cannot mmap memory for rte_config at [%p], got [%p]\"\n-\t\t\t\t\t \" - please use '--base-virtaddr' option\\n\",\n+\t\t\t\t\t \" - please use '--\" OPT_BASE_VIRTADDR\n+\t\t\t\t\t \"' option\\n\",\n \t\t\t\trte_mem_cfg_addr, mem_config);\n \t\t\tmunmap(mem_config, sizeof(struct rte_mem_config));\n \t\t\treturn -1;\ndiff --git a/lib/librte_eal/freebsd/eal/eal_memory.c b/lib/librte_eal/freebsd/eal/eal_memory.c\nindex cd31827c2b..a637127d5e 100644\n--- a/lib/librte_eal/freebsd/eal/eal_memory.c\n+++ b/lib/librte_eal/freebsd/eal/eal_memory.c\n@@ -14,6 +14,8 @@\n #include <rte_errno.h>\n #include <rte_log.h>\n #include <rte_string_fns.h>\n+\n+#include \"eal_options.h\"\n #include \"eal_private.h\"\n #include \"eal_internal_cfg.h\"\n #include \"eal_filesystem.h\"\n@@ -367,7 +369,8 @@ alloc_va_space(struct rte_memseg_list *msl)\n \taddr = eal_get_virtual_area(msl->base_va, &mem_sz, page_sz, 0, flags);\n \tif (addr == NULL) {\n \t\tif (rte_errno == EADDRNOTAVAIL)\n-\t\t\tRTE_LOG(ERR, EAL, \"Could not mmap %llu bytes at [%p] - please use '--base-virtaddr' option\\n\",\n+\t\t\tRTE_LOG(ERR, EAL, \"Could not mmap %llu bytes at [%p] - \"\n+\t\t\t\t\"please use '--\" OPT_BASE_VIRTADDR \"' option\\n\",\n \t\t\t\t(unsigned long long)mem_sz, msl->base_va);\n \t\telse\n \t\t\tRTE_LOG(ERR, EAL, \"Cannot reserve memory\\n\");\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex ef5dafa94f..13ffabd470 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -435,8 +435,8 @@ rte_eal_config_reattach(void)\n \t\tif (mem_config != MAP_FAILED) {\n \t\t\t/* errno is stale, don't use */\n \t\t\tRTE_LOG(ERR, EAL, \"Cannot mmap memory for rte_config at [%p], got [%p]\"\n-\t\t\t\t\" - please use '--base-virtaddr' option\\n\",\n-\t\t\t\trte_mem_cfg_addr, mem_config);\n+\t\t\t\t\" - please use '--\" OPT_BASE_VIRTADDR\n+\t\t\t\t\"' option\\n\", rte_mem_cfg_addr, mem_config);\n \t\t\tmunmap(mem_config, sizeof(struct rte_mem_config));\n \t\t\treturn -1;\n \t\t}\ndiff --git a/lib/librte_eal/linux/eal/eal_memory.c b/lib/librte_eal/linux/eal/eal_memory.c\nindex 8f62c343d6..197c67ac4b 100644\n--- a/lib/librte_eal/linux/eal/eal_memory.c\n+++ b/lib/librte_eal/linux/eal/eal_memory.c\n@@ -832,7 +832,8 @@ alloc_va_space(struct rte_memseg_list *msl)\n \taddr = eal_get_virtual_area(msl->base_va, &mem_sz, page_sz, 0, flags);\n \tif (addr == NULL) {\n \t\tif (rte_errno == EADDRNOTAVAIL)\n-\t\t\tRTE_LOG(ERR, EAL, \"Could not mmap %llu bytes at [%p] - please use '--base-virtaddr' option\\n\",\n+\t\t\tRTE_LOG(ERR, EAL, \"Could not mmap %llu bytes at [%p] - \"\n+\t\t\t\t\"please use '--\" OPT_BASE_VIRTADDR \"' option\\n\",\n \t\t\t\t(unsigned long long)mem_sz, msl->base_va);\n \t\telse\n \t\t\tRTE_LOG(ERR, EAL, \"Cannot reserve memory\\n\");\n", "prefixes": [ "v2", "2/2" ] }