Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61896/?format=api
{ "id": 61896, "url": "http://patches.dpdk.org/api/patches/61896/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/d75ca1b5a948fbaf548162a075ba2836f4990792.1571919488.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d75ca1b5a948fbaf548162a075ba2836f4990792.1571919488.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d75ca1b5a948fbaf548162a075ba2836f4990792.1571919488.git.anatoly.burakov@intel.com", "date": "2019-10-24T12:18:24", "name": "vfio: remove deprecated DMA mapping functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0195d1761812588edd6026f0833f3dfc62459a6c", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/d75ca1b5a948fbaf548162a075ba2836f4990792.1571919488.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 7042, "url": "http://patches.dpdk.org/api/series/7042/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=7042", "date": "2019-10-24T12:18:24", "name": "vfio: remove deprecated DMA mapping functions", "version": 1, "mbox": "http://patches.dpdk.org/series/7042/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61896/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/61896/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1CBD21DFE7;\n\tThu, 24 Oct 2019 14:18:29 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id A36C51D44E\n\tfor <dev@dpdk.org>; Thu, 24 Oct 2019 14:18:27 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Oct 2019 05:18:27 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.151])\n\tby orsmga007.jf.intel.com with ESMTP; 24 Oct 2019 05:18:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,224,1569308400\"; d=\"scan'208\";a=\"188572272\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tBruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net", "Date": "Thu, 24 Oct 2019 13:18:24 +0100", "Message-Id": "<d75ca1b5a948fbaf548162a075ba2836f4990792.1571919488.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The rte_vfio_dma_map/unmap API's have been marked as deprecated in\nrelease 19.05. Remove them.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n Although `rte_vfio_dma_map` et al. was marked as deprecated in our documentation,\n it wasn't marked as __rte_deprecated in code. Should we still remove it?\n\n doc/guides/rel_notes/deprecation.rst | 4 ---\n doc/guides/rel_notes/release_19_11.rst | 3 ++\n lib/librte_eal/common/include/rte_vfio.h | 44 ------------------------\n lib/librte_eal/freebsd/eal/eal.c | 14 --------\n lib/librte_eal/linux/eal/eal_vfio.c | 36 -------------------\n lib/librte_eal/rte_eal_version.map | 2 --\n 6 files changed, 3 insertions(+), 100 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 237813b647..f044a0e436 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -44,10 +44,6 @@ Deprecation Notices\n * eal: The ``rte_malloc_virt2phy`` function has been deprecated and replaced\n by ``rte_malloc_virt2iova`` since v17.11 and will be removed.\n \n-* vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs which\n- have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap``\n- functions. The due date for the removal targets DPDK 20.02.\n-\n * pci: Several exposed functions are misnamed.\n The following functions are deprecated starting from v17.11 and are replaced:\n \ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 856088c5c7..c43d6b29ef 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -137,6 +137,9 @@ Removed Items\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+ * Removed `rte_vfio_dma_map` and `rte_vfio_dma_unmap` API's that have been\n+ marked as deprecated in release 19.05.\n+\n * Removed duplicated set of commands for RX offloading configuration from app/testpmd:\n “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-vlan|hw-vlan-filter|\n hw-vlan-strip|hw-vlan-extend on|off”.\ndiff --git a/lib/librte_eal/common/include/rte_vfio.h b/lib/librte_eal/common/include/rte_vfio.h\nindex b360485fad..20ed8c45a9 100644\n--- a/lib/librte_eal/common/include/rte_vfio.h\n+++ b/lib/librte_eal/common/include/rte_vfio.h\n@@ -189,50 +189,6 @@ int rte_vfio_noiommu_is_enabled(void);\n int\n rte_vfio_clear_group(int vfio_group_fd);\n \n-/**\n- * Map memory region for use with VFIO.\n- *\n- * @note Require at least one device to be attached at the time of\n- * mapping. DMA maps done via this API will only apply to default\n- * container and will not apply to any of the containers created\n- * via rte_vfio_container_create().\n- *\n- * @param vaddr\n- * Starting virtual address of memory to be mapped.\n- *\n- * @param iova\n- * Starting IOVA address of memory to be mapped.\n- *\n- * @param len\n- * Length of memory segment being mapped.\n- *\n- * @return\n- * 0 if success.\n- * -1 on error.\n- */\n-int\n-rte_vfio_dma_map(uint64_t vaddr, uint64_t iova, uint64_t len);\n-\n-\n-/**\n- * Unmap memory region from VFIO.\n- *\n- * @param vaddr\n- * Starting virtual address of memory to be unmapped.\n- *\n- * @param iova\n- * Starting IOVA address of memory to be unmapped.\n- *\n- * @param len\n- * Length of memory segment being unmapped.\n- *\n- * @return\n- * 0 if success.\n- * -1 on error.\n- */\n-\n-int\n-rte_vfio_dma_unmap(uint64_t vaddr, uint64_t iova, uint64_t len);\n /**\n * Parse IOMMU group number for a device\n *\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex f86e9aa318..3a62e2faf7 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -1007,20 +1007,6 @@ int rte_vfio_clear_group(__rte_unused int vfio_group_fd)\n \treturn 0;\n }\n \n-int\n-rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t iova,\n-\t\t __rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused iova,\n-\t\t __rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n int\n rte_vfio_get_group_num(__rte_unused const char *sysfs_base,\n \t\t __rte_unused const char *dev_addr,\ndiff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c\nindex d9541b1220..0af1fafa68 100644\n--- a/lib/librte_eal/linux/eal/eal_vfio.c\n+++ b/lib/librte_eal/linux/eal/eal_vfio.c\n@@ -1829,28 +1829,6 @@ container_dma_unmap(struct vfio_config *vfio_cfg, uint64_t vaddr, uint64_t iova,\n \treturn ret;\n }\n \n-int\n-rte_vfio_dma_map(uint64_t vaddr, uint64_t iova, uint64_t len)\n-{\n-\tif (len == 0) {\n-\t\trte_errno = EINVAL;\n-\t\treturn -1;\n-\t}\n-\n-\treturn container_dma_map(default_vfio_cfg, vaddr, iova, len);\n-}\n-\n-int\n-rte_vfio_dma_unmap(uint64_t vaddr, uint64_t iova, uint64_t len)\n-{\n-\tif (len == 0) {\n-\t\trte_errno = EINVAL;\n-\t\treturn -1;\n-\t}\n-\n-\treturn container_dma_unmap(default_vfio_cfg, vaddr, iova, len);\n-}\n-\n int\n rte_vfio_noiommu_is_enabled(void)\n {\n@@ -2028,20 +2006,6 @@ rte_vfio_container_dma_unmap(int container_fd, uint64_t vaddr, uint64_t iova,\n \n #else\n \n-int\n-rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t iova,\n-\t\t __rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused iova,\n-\t\t __rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n int\n rte_vfio_setup_device(__rte_unused const char *sysfs_base,\n \t\t__rte_unused const char *dev_addr,\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 7cbf82d37b..33601e8e67 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -248,8 +248,6 @@ DPDK_18.08 {\n \trte_vfio_container_dma_unmap;\n \trte_vfio_container_group_bind;\n \trte_vfio_container_group_unbind;\n-\trte_vfio_dma_map;\n-\trte_vfio_dma_unmap;\n \trte_vfio_get_container_fd;\n \trte_vfio_get_group_fd;\n \trte_vfio_get_group_num;\n", "prefixes": [] }