Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61650/?format=api
{ "id": 61650, "url": "http://patches.dpdk.org/api/patches/61650/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191022115412.8837-10-aostruszka@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191022115412.8837-10-aostruszka@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191022115412.8837-10-aostruszka@marvell.com", "date": "2019-10-22T11:54:11", "name": "[v4,09/10] net/ifc: clean LTO build warnings (maybe-uninitialized)", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ef728d7a5f0ed27b977e648f094bca3195ac6d52", "submitter": { "id": 1429, "url": "http://patches.dpdk.org/api/people/1429/?format=api", "name": "Andrzej Ostruszka [C]", "email": "aostruszka@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191022115412.8837-10-aostruszka@marvell.com/mbox/", "series": [ { "id": 6983, "url": "http://patches.dpdk.org/api/series/6983/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6983", "date": "2019-10-22T11:54:02", "name": "Add an option to use LTO for DPDK build", "version": 4, "mbox": "http://patches.dpdk.org/series/6983/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61650/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61650/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DAB451BF21;\n\tTue, 22 Oct 2019 13:54:46 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 564C71BEC5\n\tfor <dev@dpdk.org>; Tue, 22 Oct 2019 13:54:36 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx9MBe7Br013847; Tue, 22 Oct 2019 04:54:35 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2vsyjh8ad1-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tTue, 22 Oct 2019 04:54:35 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tTue, 22 Oct 2019 04:54:34 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Tue, 22 Oct 2019 04:54:34 -0700", "from amok.marvell.com (unknown [10.95.130.40])\n\tby maili.marvell.com (Postfix) with ESMTP id 325A03F703F;\n\tTue, 22 Oct 2019 04:54:33 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type : content-transfer-encoding; s=pfpt0818;\n\tbh=njxDrBYvdUWUj+eG7Fs23O3TqZSfquraKwmr3l7cD04=;\n\tb=ynemGUYWf3ZUFCQjbuWf6MU0JqqusjqMl3tF+pF0S38frpS/3635R9q+K3RkAvcqqD2U\n\tFfHwnOEOV9mmhZ96V5qrZQj5lYCDB9xzVqfDJQR/GPlDbaRypcYozPZtNKROt8yehYUX\n\tE+gLSHMu6MaC6XepQue1RzChOzbU+6rl3qx2pBv+J4upsx+ozt9TxyzjqhAwf2ez74ly\n\tIqWK7ORvW/hyunR43KdHkwdxDm8VwFgmhSnjlLC5qHuSaBmQbpn5LgUHyYd6TFtGndsM\n\t8W9rDCO9FgAbzaSiE21lq578v4Cz4Grff+hsHwJJrPV4dCf6p5Cnw3puOn8r97OcZSHY\n\tLA== ", "From": "Andrzej Ostruszka <aostruszka@marvell.com>", "To": "<dev@dpdk.org>, Xiao Wang <xiao.w.wang@intel.com>", "CC": "<mattias.ronnblom@ericsson.com>, <stephen@networkplumber.org>", "Date": "Tue, 22 Oct 2019 13:54:11 +0200", "Message-ID": "<20191022115412.8837-10-aostruszka@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191022115412.8837-1-aostruszka@marvell.com>", "References": "<20190917075754.8310-1-amo@semihalf.com>\n\t<20191022115412.8837-1-aostruszka@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n\tdefinitions=2019-10-22_03:2019-10-22,2019-10-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 09/10] net/ifc: clean LTO build warnings\n\t(maybe-uninitialized)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "During LTO build compiler reports some 'false positive' warnings about\nvariables being possibly used uninitialized. This patch silences these\nwarnings.\n\nExemplary compiler warning to suppress (with LTO enabled):\nerror: ‘features’ may be used uninitialized in this function\n[-Werror=maybe-uninitialized]\n if (RTE_VHOST_NEED_LOG(features)) {\n\nSigned-off-by: Andrzej Ostruszka <aostruszka@marvell.com>\n---\n drivers/net/ifc/ifcvf_vdpa.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c\nindex 8de9ef199..4cdff8712 100644\n--- a/drivers/net/ifc/ifcvf_vdpa.c\n+++ b/drivers/net/ifc/ifcvf_vdpa.c\n@@ -304,8 +304,8 @@ vdpa_ifcvf_stop(struct ifcvf_internal *internal)\n \tstruct ifcvf_hw *hw = &internal->hw;\n \tuint32_t i;\n \tint vid;\n-\tuint64_t features;\n-\tuint64_t log_base, log_size;\n+\tuint64_t features = 0;\n+\tuint64_t log_base = 0, log_size = 0;\n \tuint64_t len;\n \n \tvid = internal->vid;\n@@ -348,6 +348,8 @@ vdpa_enable_vfio_intr(struct ifcvf_internal *internal, bool m_rx)\n \tstruct rte_vhost_vring vring;\n \tint fd;\n \n+\tvring.callfd = -1;\n+\n \tnr_vring = rte_vhost_get_vring_num(internal->vid);\n \n \tirq_set = (struct vfio_irq_set *)irq_set_buf;\n@@ -442,6 +444,7 @@ notify_relay(void *arg)\n \t}\n \tinternal->epfd = epfd;\n \n+\tvring.kickfd = -1;\n \tfor (qid = 0; qid < q_num; qid++) {\n \t\tev.events = EPOLLIN | EPOLLPRI;\n \t\trte_vhost_get_vhost_vring(internal->vid, qid, &vring);\n@@ -577,7 +580,7 @@ m_ifcvf_start(struct ifcvf_internal *internal)\n \tstruct ifcvf_hw *hw = &internal->hw;\n \tuint32_t i, nr_vring;\n \tint vid, ret;\n-\tstruct rte_vhost_vring vq;\n+\tstruct rte_vhost_vring vq = { 0 };\n \tvoid *vring_buf;\n \tuint64_t m_vring_iova = IFCVF_MEDIATED_VRING;\n \tuint64_t size;\n@@ -721,6 +724,7 @@ vring_relay(void *arg)\n \t}\n \tinternal->epfd = epfd;\n \n+\tvring.kickfd = -1;\n \tfor (qid = 0; qid < q_num; qid++) {\n \t\tev.events = EPOLLIN | EPOLLPRI;\n \t\trte_vhost_get_vhost_vring(vid, qid, &vring);\n@@ -930,11 +934,11 @@ ifcvf_dev_close(int vid)\n static int\n ifcvf_set_features(int vid)\n {\n-\tuint64_t features;\n+\tuint64_t features = 0;\n \tint did;\n \tstruct internal_list *list;\n \tstruct ifcvf_internal *internal;\n-\tuint64_t log_base, log_size;\n+\tuint64_t log_base = 0, log_size = 0;\n \n \tdid = rte_vhost_get_vdpa_device_id(vid);\n \tlist = find_internal_resource_by_did(did);\n", "prefixes": [ "v4", "09/10" ] }