Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61647/?format=api
{ "id": 61647, "url": "http://patches.dpdk.org/api/patches/61647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20191022115412.8837-7-aostruszka@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191022115412.8837-7-aostruszka@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191022115412.8837-7-aostruszka@marvell.com", "date": "2019-10-22T11:54:08", "name": "[v4,06/10] net/dpaa2: fix possible use of uninitialized vars", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d3f49597d01259cde6b58b9033fe98e13b52ca57", "submitter": { "id": 1429, "url": "http://patches.dpdk.org/api/people/1429/?format=api", "name": "Andrzej Ostruszka [C]", "email": "aostruszka@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20191022115412.8837-7-aostruszka@marvell.com/mbox/", "series": [ { "id": 6983, "url": "http://patches.dpdk.org/api/series/6983/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6983", "date": "2019-10-22T11:54:02", "name": "Add an option to use LTO for DPDK build", "version": 4, "mbox": "http://patches.dpdk.org/series/6983/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61647/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/61647/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CB6E61BEF8;\n\tTue, 22 Oct 2019 13:54:35 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 2A26F1BEE3\n\tfor <dev@dpdk.org>; Tue, 22 Oct 2019 13:54:31 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id\n\tx9MBdiM2006241; Tue, 22 Oct 2019 04:54:30 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2vsw610su1-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tTue, 22 Oct 2019 04:54:30 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com\n\t(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tTue, 22 Oct 2019 04:54:29 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Tue, 22 Oct 2019 04:54:29 -0700", "from amok.marvell.com (unknown [10.95.130.40])\n\tby maili.marvell.com (Postfix) with ESMTP id 8E9BB3F7040;\n\tTue, 22 Oct 2019 04:54:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type : content-transfer-encoding; s=pfpt0818;\n\tbh=gqXBXTjSiHItbzkOwXLgvY5f5DYoFZdXLldApmsQoso=;\n\tb=wLyAY0Y2SvL4OodfhvbODYjXsU4rFjeUl2CiiRVLLUfaaJLlJmCIiVEnTGWWMxhZnQXd\n\tVVVVQOu70Yr0+YIzSC56PzHTbIcVnENu0gmXm2VQuh0+IHDDs3tYf0qePK/bxhY3Aa97\n\tKQAReybZh/NEEjxJDRVFRpYg3jGHO8xG1j1WbxpW8HQsLU+Qh3B79clHr7dsz0TzRUas\n\tiXNfExdxIaAuz66E/F1o3tvTmY6iJ0cjzqQcO/KHKWHbZdOP/Vit72JuBKCj8oTgPrZA\n\tQ7ok0oqPSniD5XBo6XVLHObHAB/WToV7xTounQizi46AS++OQ7MHEKuVqWn+kmNpADIF\n\tJg== ", "From": "Andrzej Ostruszka <aostruszka@marvell.com>", "To": "<dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena\n\t<sachin.saxena@nxp.com>", "CC": "<mattias.ronnblom@ericsson.com>, <stephen@networkplumber.org>", "Date": "Tue, 22 Oct 2019 13:54:08 +0200", "Message-ID": "<20191022115412.8837-7-aostruszka@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191022115412.8837-1-aostruszka@marvell.com>", "References": "<20190917075754.8310-1-amo@semihalf.com>\n\t<20191022115412.8837-1-aostruszka@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.95,1.0.8\n\tdefinitions=2019-10-22_03:2019-10-22,2019-10-22 signatures=0", "Subject": "[dpdk-dev] [PATCH v4 06/10] net/dpaa2: fix possible use of\n\tuninitialized vars", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes 'maybe-uninitialized' warnings reported by compiler\nwhen using LTO.\n\nCompiler warning pointing to this error (with LTO enabled):\nerror: ‘kg_cfg.extracts[0].masks[0].mask’ may be used uninitialized in\nthis function [-Werror=maybe-uninitialized]\n extr->masks[j].mask = cfg->extracts[i].masks[j].mask;\n\nFixes: 16bbc98a3e63 (\"bus/fslmc: update MC to 10.3.x\")\nSigned-off-by: Andrzej Ostruszka <aostruszka@marvell.com>\n---\n drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 +\n drivers/net/dpaa2/mc/dpkg.c | 2 +-\n drivers/net/dpaa2/mc/dpni.c | 9 ++++++---\n 3 files changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\nindex 56e2e56a3..2f6534a31 100644\n--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n@@ -51,6 +51,7 @@ rte_pmd_dpaa2_set_custom_hash(uint16_t port_id,\n \tkg_cfg.extracts[0].type = DPKG_EXTRACT_FROM_DATA;\n \tkg_cfg.extracts[0].extract.from_data.offset = offset;\n \tkg_cfg.extracts[0].extract.from_data.size = size;\n+\tkg_cfg.extracts[0].num_of_byte_masks = 0;\n \tkg_cfg.num_extracts = 1;\n \n \tret = dpkg_prepare_key_cfg(&kg_cfg, p_params);\ndiff --git a/drivers/net/dpaa2/mc/dpkg.c b/drivers/net/dpaa2/mc/dpkg.c\nindex 80f94f40e..7aa63ea12 100644\n--- a/drivers/net/dpaa2/mc/dpkg.c\n+++ b/drivers/net/dpaa2/mc/dpkg.c\n@@ -63,7 +63,7 @@ dpkg_prepare_key_cfg(const struct dpkg_profile_cfg *cfg, uint8_t *key_cfg_buf)\n \t\tdpkg_set_field(extr->extract_type, EXTRACT_TYPE,\n \t\t\t cfg->extracts[i].type);\n \n-\t\tfor (j = 0; j < DPKG_NUM_OF_MASKS; j++) {\n+\t\tfor (j = 0; j < extr->num_of_byte_masks; j++) {\n \t\t\textr->masks[j].mask = cfg->extracts[i].masks[j].mask;\n \t\t\textr->masks[j].offset =\n \t\t\t\tcfg->extracts[i].masks[j].offset;\ndiff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c\nindex 362cd476f..b74a1a317 100644\n--- a/drivers/net/dpaa2/mc/dpni.c\n+++ b/drivers/net/dpaa2/mc/dpni.c\n@@ -1803,10 +1803,13 @@ int dpni_set_congestion_notification(struct fsl_mc_io *mc_io,\n \tcmd_params->qtype = qtype;\n \tcmd_params->tc = tc_id;\n \tcmd_params->congestion_point = cfg->cg_point;\n-\tcmd_params->cgid = (uint8_t)cfg->cgid;\n-\tcmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);\n+\tif (cfg->cg_point == DPNI_CP_CONGESTION_GROUP)\n+\t\tcmd_params->cgid = (uint8_t)cfg->cgid;\n+\tif (cfg->dest_cfg.dest_type != DPNI_DEST_NONE) {\n+\t\tcmd_params->dest_id = cpu_to_le32(cfg->dest_cfg.dest_id);\n+\t\tcmd_params->dest_priority = cfg->dest_cfg.priority;\n+\t}\n \tcmd_params->notification_mode = cpu_to_le16(cfg->notification_mode);\n-\tcmd_params->dest_priority = cfg->dest_cfg.priority;\n \tcmd_params->message_iova = cpu_to_le64(cfg->message_iova);\n \tcmd_params->message_ctx = cpu_to_le64(cfg->message_ctx);\n \tcmd_params->threshold_entry = cpu_to_le32(cfg->threshold_entry);\n", "prefixes": [ "v4", "06/10" ] }