Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/61632/?format=api
{ "id": 61632, "url": "http://patches.dpdk.org/api/patches/61632/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1571736761-32134-2-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1571736761-32134-2-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1571736761-32134-2-git-send-email-david.marchand@redhat.com", "date": "2019-10-22T09:32:34", "name": "[1/8] eal: make lcore config private", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6c4c237a91619e8e54ce8e715173e6d361cf3731", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1571736761-32134-2-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 6981, "url": "http://patches.dpdk.org/api/series/6981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=6981", "date": "2019-10-22T09:32:33", "name": "EAL and PCI ABI changes for 19.11", "version": 1, "mbox": "http://patches.dpdk.org/series/6981/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/61632/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/61632/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6B8311BEB3;\n\tTue, 22 Oct 2019 11:33:09 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n\t[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 02CA61BEA7\n\tfor <dev@dpdk.org>; Tue, 22 Oct 2019 11:33:07 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-161-EHPYyWBgOUy4xG1u1wt-Gg-1; Tue, 22 Oct 2019 05:33:05 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id 766A05E4;\n\tTue, 22 Oct 2019 09:33:03 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com\n\t[10.40.204.129])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A0649601AF;\n\tTue, 22 Oct 2019 09:32:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1571736787;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=X4lgP4l7RmDxVSI61jHQZTAnXfhwGWuH7O4KR3MOg6I=;\n\tb=RWffS7+M1W/1tgVe+Jy/AM3l6WDtfg1MseqgM9sTVtfXnx1tA8Go+vg4wb8gG0ni1sLEpe\n\tSJ309Us0PJgWI+VJ3qH9/C1s8DtrQGTgaqGWqezUCvp0/sBgHGHaIZkZOL4GCXjhHkDy+n\n\tYluErT3CTHF23m0G7PfMN8+kJucdwjc=", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tHarry van Haaren <harry.van.haaren@intel.com>,\n\tHarini Ramakrishnan <harini.ramakrishnan@microsoft.com>,\n\tOmar Cardona <ocardona@microsoft.com>,\n\tAnand Rawat <anand.rawat@intel.com>, \n\tRanjit Menon <ranjit.menon@intel.com>", "Date": "Tue, 22 Oct 2019 11:32:34 +0200", "Message-Id": "<1571736761-32134-2-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>", "References": "<1571736761-32134-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-MC-Unique": "EHPYyWBgOUy4xG1u1wt-Gg-1", "X-Mimecast-Spam-Score": "0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH 1/8] eal: make lcore config private", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nThe internal structure of lcore_config does not need to be part of\nvisible API/ABI. Make it private to EAL.\n\nRearrange the structure so it takes less memory (and cache footprint).\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nBased on Stephen v8: http://patchwork.dpdk.org/patch/60443/\n\nChanges since Stephen v8:\n- do not change core_id, socket_id and core_index types,\n\n---\n doc/guides/rel_notes/deprecation.rst | 4 ----\n doc/guides/rel_notes/release_19_11.rst | 2 ++\n lib/librte_eal/common/eal_common_launch.c | 2 ++\n lib/librte_eal/common/eal_private.h | 25 +++++++++++++++++++++++++\n lib/librte_eal/common/include/rte_lcore.h | 24 ------------------------\n lib/librte_eal/common/rte_service.c | 2 ++\n lib/librte_eal/rte_eal_version.map | 1 -\n lib/librte_eal/windows/eal/eal_thread.c | 1 +\n 8 files changed, 32 insertions(+), 29 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 237813b..e4a33e0 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -23,10 +23,6 @@ Deprecation Notices\n * eal: The function ``rte_eal_remote_launch`` will return new error codes\n after read or write error on the pipe, instead of calling ``rte_panic``.\n \n-* eal: The ``lcore_config`` struct and global symbol will be made private to\n- remove it from the externally visible ABI and allow it to be updated in the\n- future.\n-\n * eal: both declaring and identifying devices will be streamlined in v18.11.\n New functions will appear to query a specific port from buses, classes of\n device and device drivers. Device declaration will be made coherent with the\ndiff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst\nindex 40121b9..d7e14b4 100644\n--- a/doc/guides/rel_notes/release_19_11.rst\n+++ b/doc/guides/rel_notes/release_19_11.rst\n@@ -202,6 +202,8 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* eal: made the ``lcore_config`` struct and global symbol private.\n+\n \n Shared Library Versions\n -----------------------\ndiff --git a/lib/librte_eal/common/eal_common_launch.c b/lib/librte_eal/common/eal_common_launch.c\nindex fe0ba3f..cf52d71 100644\n--- a/lib/librte_eal/common/eal_common_launch.c\n+++ b/lib/librte_eal/common/eal_common_launch.c\n@@ -15,6 +15,8 @@\n #include <rte_per_lcore.h>\n #include <rte_lcore.h>\n \n+#include \"eal_private.h\"\n+\n /*\n * Wait until a lcore finished its job.\n */\ndiff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 798ede5..0e4b033 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -10,6 +10,31 @@\n #include <stdio.h>\n \n #include <rte_dev.h>\n+#include <rte_lcore.h>\n+\n+/**\n+ * Structure storing internal configuration (per-lcore)\n+ */\n+struct lcore_config {\n+\tpthread_t thread_id; /**< pthread identifier */\n+\tint pipe_master2slave[2]; /**< communication pipe with master */\n+\tint pipe_slave2master[2]; /**< communication pipe with master */\n+\n+\tlcore_function_t * volatile f; /**< function to call */\n+\tvoid * volatile arg; /**< argument of function */\n+\tvolatile int ret; /**< return value of function */\n+\n+\tvolatile enum rte_lcore_state_t state; /**< lcore state */\n+\tunsigned int socket_id; /**< physical socket id for this lcore */\n+\tunsigned int core_id; /**< core number on socket for this lcore */\n+\tint core_index; /**< relative index, starting from 0 */\n+\tuint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */\n+\tuint8_t detected; /**< true if lcore was detected */\n+\n+\trte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */\n+};\n+\n+extern struct lcore_config lcore_config[RTE_MAX_LCORE];\n \n /**\n * Initialize the memzone subsystem (private to eal).\ndiff --git a/lib/librte_eal/common/include/rte_lcore.h b/lib/librte_eal/common/include/rte_lcore.h\nindex c86f72e..0c68391 100644\n--- a/lib/librte_eal/common/include/rte_lcore.h\n+++ b/lib/librte_eal/common/include/rte_lcore.h\n@@ -66,30 +66,6 @@ typedef cpuset_t rte_cpuset_t;\n } while (0)\n #endif\n \n-/**\n- * Structure storing internal configuration (per-lcore)\n- */\n-struct lcore_config {\n-\tunsigned detected; /**< true if lcore was detected */\n-\tpthread_t thread_id; /**< pthread identifier */\n-\tint pipe_master2slave[2]; /**< communication pipe with master */\n-\tint pipe_slave2master[2]; /**< communication pipe with master */\n-\tlcore_function_t * volatile f; /**< function to call */\n-\tvoid * volatile arg; /**< argument of function */\n-\tvolatile int ret; /**< return value of function */\n-\tvolatile enum rte_lcore_state_t state; /**< lcore state */\n-\tunsigned socket_id; /**< physical socket id for this lcore */\n-\tunsigned core_id; /**< core number on socket for this lcore */\n-\tint core_index; /**< relative index, starting from 0 */\n-\trte_cpuset_t cpuset; /**< cpu set which the lcore affinity to */\n-\tuint8_t core_role; /**< role of core eg: OFF, RTE, SERVICE */\n-};\n-\n-/**\n- * Internal configuration (per-lcore)\n- */\n-extern struct lcore_config lcore_config[RTE_MAX_LCORE];\n-\n RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread \"lcore id\". */\n RTE_DECLARE_PER_LCORE(rte_cpuset_t, _cpuset); /**< Per thread \"cpuset\". */\n \ndiff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c\nindex beb9691..79235c0 100644\n--- a/lib/librte_eal/common/rte_service.c\n+++ b/lib/librte_eal/common/rte_service.c\n@@ -21,6 +21,8 @@\n #include <rte_memory.h>\n #include <rte_malloc.h>\n \n+#include \"eal_private.h\"\n+\n #define RTE_SERVICE_NUM_MAX 64\n \n #define SERVICE_F_REGISTERED (1 << 0)\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 7cbf82d..aeedf39 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -4,7 +4,6 @@ DPDK_2.0 {\n \t__rte_panic;\n \teal_parse_sysfs_value;\n \teal_timer_source;\n-\tlcore_config;\n \tper_lcore__lcore_id;\n \tper_lcore__rte_errno;\n \trte_calloc;\ndiff --git a/lib/librte_eal/windows/eal/eal_thread.c b/lib/librte_eal/windows/eal/eal_thread.c\nindex 906502f..0591d4c 100644\n--- a/lib/librte_eal/windows/eal/eal_thread.c\n+++ b/lib/librte_eal/windows/eal/eal_thread.c\n@@ -12,6 +12,7 @@\n #include <rte_common.h>\n #include <eal_thread.h>\n \n+#include \"eal_private.h\"\n \n RTE_DEFINE_PER_LCORE(unsigned int, _lcore_id) = LCORE_ID_ANY;\n \n", "prefixes": [ "1/8" ] }