Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6148,
    "url": "http://patches.dpdk.org/api/patches/6148/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1436259634-7077-4-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1436259634-7077-4-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1436259634-7077-4-git-send-email-david.marchand@6wind.com",
    "date": "2015-07-07T09:00:31",
    "name": "[dpdk-dev,3/6] eal/linux: cosmetic change",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "b3fa0a93df644fb2943dbabe2f0c5cb4004dccdd",
    "submitter": {
        "id": 3,
        "url": "http://patches.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1436259634-7077-4-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/6148/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/6148/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2F0EC5A63;\n\tTue,  7 Jul 2015 11:00:54 +0200 (CEST)",
            "from mail-wi0-f182.google.com (mail-wi0-f182.google.com\n\t[209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 01C7F5A52\n\tfor <dev@dpdk.org>; Tue,  7 Jul 2015 11:00:51 +0200 (CEST)",
            "by wiwl6 with SMTP id l6so307751638wiw.0\n\tfor <dev@dpdk.org>; Tue, 07 Jul 2015 02:00:50 -0700 (PDT)",
            "from alcyon.dev.6wind.com (6wind.net2.nerim.net. [213.41.151.210])\n\tby mx.google.com with ESMTPSA id\n\ty19sm32737674wia.15.2015.07.07.02.00.49 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 07 Jul 2015 02:00:49 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=SUpR7tHOsL5i1Ahx+09tZJ4TW+FIFIkveAvqgYTtC18=;\n\tb=SgI+t8S7aTFAgt+F2xd/H3QAs4o6+/tw1Wf7XHWCYxmOnI7SGDhTusLcR3l7AWNgNW\n\tetlMsGy0+Q43C7LBTcQY4MNpLu+heYbVinAVdS/1W0I2WVdPxpypcdiwSzm043ILay8o\n\tJj/2ba0rnHvkeb0eoVbiOFT/gVq6zpevDo6VIYd4a+En0yjyHQBF3ThTamkyTsHB1c4h\n\tC9Tvg5osHL2NxO50/oQE+YNy3tKhJBshyDwtHtruTfofux7+nTFONlRuW0rSXfIiZitZ\n\tYqTj7D18h0ooJ0UFr4t6jukb07ZMDtKvqtxUMuxGWu846BhMMn/8Fflm8DhtvaGO5nkp\n\tkrhg==",
        "X-Gm-Message-State": "ALoCoQlE98XsDtOJ56QjV48DHrdThvi4BJEcX5AGx2DIIFq6akmxTJsKY12Rg+/T0e1+p3BnefaU",
        "X-Received": "by 10.194.108.5 with SMTP id hg5mr6655906wjb.25.1436259650849;\n\tTue, 07 Jul 2015 02:00:50 -0700 (PDT)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  7 Jul 2015 11:00:31 +0200",
        "Message-Id": "<1436259634-7077-4-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 1.7.10.4",
        "In-Reply-To": "<1436259634-7077-1-git-send-email-david.marchand@6wind.com>",
        "References": "<1436259634-7077-1-git-send-email-david.marchand@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH 3/6] eal/linux: cosmetic change",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Prepare for checkpatch compliance.\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_eal/linuxapp/eal/eal_hugepage_info.c |   28 +++++++++++++----------\n 1 file changed, 16 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\nindex 0b6ece7..b474159 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c\n@@ -274,22 +274,26 @@ eal_hugepage_info_init(void)\n \tconst char dirent_start_text[] = \"hugepages-\";\n \tconst size_t dirent_start_len = sizeof(dirent_start_text) - 1;\n \tunsigned i, num_sizes = 0;\n+\tDIR *dir;\n+\tstruct dirent *dirent;\n \n-\tDIR *dir = opendir(sys_dir_path);\n+\tdir = opendir(sys_dir_path);\n \tif (dir == NULL)\n-\t\trte_panic(\"Cannot open directory %s to read system hugepage info\\n\",\n-\t\t\t\tsys_dir_path);\n+\t\trte_panic(\"Cannot open directory %s to read system hugepage \"\n+\t\t\t  \"info\\n\", sys_dir_path);\n \n-\tstruct dirent *dirent = readdir(dir);\n-\twhile(dirent != NULL){\n-\t\tif (strncmp(dirent->d_name, dirent_start_text, dirent_start_len) == 0){\n-\t\t\tstruct hugepage_info *hpi = \\\n-\t\t\t\t\t&internal_config.hugepage_info[num_sizes];\n+\tdirent = readdir(dir);\n+\twhile (dirent != NULL) {\n+\t\tstruct hugepage_info *hpi;\n+\n+\t\tif (strncmp(dirent->d_name, dirent_start_text,\n+\t\t\t    dirent_start_len) == 0) {\n+\t\t\thpi = &internal_config.hugepage_info[num_sizes];\n \t\t\thpi->hugepage_sz = rte_str_to_size(&dirent->d_name[dirent_start_len]);\n \t\t\thpi->hugedir = get_hugepage_dir(hpi->hugepage_sz);\n \n \t\t\t/* first, check if we have a mountpoint */\n-\t\t\tif (hpi->hugedir == NULL){\n+\t\t\tif (hpi->hugedir == NULL) {\n \t\t\t\tunsigned long num_pages;\n \n \t\t\t\tnum_pages = get_num_hugepages(dirent->d_name);\n@@ -332,10 +336,10 @@ eal_hugepage_info_init(void)\n \tinternal_config.num_hugepage_sizes = num_sizes;\n \n \t/* sort the page directory entries by size, largest to smallest */\n-\tfor (i = 0; i < num_sizes; i++){\n+\tfor (i = 0; i < num_sizes; i++) {\n \t\tunsigned j;\n \t\tfor (j = i+1; j < num_sizes; j++)\n-\t\t\tif (internal_config.hugepage_info[j-1].hugepage_sz < \\\n+\t\t\tif (internal_config.hugepage_info[j-1].hugepage_sz <\n \t\t\t\t\tinternal_config.hugepage_info[j].hugepage_sz)\n \t\t\t\tswap_hpi(&internal_config.hugepage_info[j-1],\n \t\t\t\t\t\t&internal_config.hugepage_info[j]);\n@@ -344,7 +348,7 @@ eal_hugepage_info_init(void)\n \t/* now we have all info, check we have at least one valid size */\n \tfor (i = 0; i < num_sizes; i++)\n \t\tif (internal_config.hugepage_info[i].hugedir != NULL &&\n-\t\t\t\tinternal_config.hugepage_info[i].num_pages[0] > 0)\n+\t\t    internal_config.hugepage_info[i].num_pages[0] > 0)\n \t\t\treturn 0;\n \n \t/* no valid hugepage mounts available, return error */\n",
    "prefixes": [
        "dpdk-dev",
        "3/6"
    ]
}