Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 612,
    "url": "http://patches.dpdk.org/api/patches/612/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/82107A2E-6373-4A8E-9CDA-10FE18EDEFB6@windriver.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<82107A2E-6373-4A8E-9CDA-10FE18EDEFB6@windriver.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/82107A2E-6373-4A8E-9CDA-10FE18EDEFB6@windriver.com",
    "date": "2014-09-27T18:41:41",
    "name": "[dpdk-dev] Function __mempool_get_bulk() returns wrong count.",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "88c90a4fe21881f60bc75bf2d83e97ab7339df55",
    "submitter": {
        "id": 75,
        "url": "http://patches.dpdk.org/api/people/75/?format=api",
        "name": "Wiles, Roger Keith",
        "email": "keith.wiles@windriver.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/82107A2E-6373-4A8E-9CDA-10FE18EDEFB6@windriver.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/612/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/612/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 38DAC683E;\n\tSat, 27 Sep 2014 20:35:17 +0200 (CEST)",
            "from mail.windriver.com (mail.windriver.com [147.11.1.11])\n\tby dpdk.org (Postfix) with ESMTP id 59B71678C\n\tfor <dev@dpdk.org>; Sat, 27 Sep 2014 20:35:15 +0200 (CEST)",
            "from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8RIfgP0013715\n\t(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL)\n\tfor <dev@dpdk.org>; Sat, 27 Sep 2014 11:41:42 -0700 (PDT)",
            "from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by\n\tALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0174.001;\n\tSat, 27 Sep 2014 11:41:41 -0700"
        ],
        "From": "\"Wiles, Roger Keith\" <keith.wiles@windriver.com>",
        "To": "\"<dev@dpdk.org>\" <dev@dpdk.org>",
        "Thread-Topic": "[PATCH] Function __mempool_get_bulk() returns wrong count.",
        "Thread-Index": "AQHP2oKtLICv7vWhf0Wg0zJjkh9qrQ==",
        "Date": "Sat, 27 Sep 2014 18:41:41 +0000",
        "Message-ID": "<82107A2E-6373-4A8E-9CDA-10FE18EDEFB6@windriver.com>",
        "Accept-Language": "en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-originating-ip": "[172.25.40.166]",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-ID": "<ED6285EF86CCAE4A9AEE036B3F3BC93F@local>",
        "Content-Transfer-Encoding": "quoted-printable",
        "MIME-Version": "1.0",
        "Subject": "[dpdk-dev] [PATCH] Function __mempool_get_bulk() returns wrong\n\tcount.",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When __mempool_get_bulk() grabs entries from the cache it\nreturns zero instead of the number of entries obtained. Plus\nthe stats were increased by the wrong count of objects.\n\nSigned-off-by: Keith Wiles <keith.wiles@windriver.com>\n---\n lib/librte_mempool/rte_mempool.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h\nindex 299d4d7..6750e78 100644\n--- a/lib/librte_mempool/rte_mempool.h\n+++ b/lib/librte_mempool/rte_mempool.h\n@@ -988,9 +988,9 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,\n \n        cache->len -= n;\n \n-       __MEMPOOL_STAT_ADD(mp, get_success, n_orig);\n+       __MEMPOOL_STAT_ADD(mp, get_success, n);\n \n-       return 0;\n+       return n;\n \n ring_dequeue:\n #endif /* RTE_MEMPOOL_CACHE_MAX_SIZE > 0 */\n@@ -1004,7 +1004,7 @@ ring_dequeue:\n        if (ret < 0)\n                __MEMPOOL_STAT_ADD(mp, get_fail, n_orig);\n        else\n-               __MEMPOOL_STAT_ADD(mp, get_success, n_orig);\n+               __MEMPOOL_STAT_ADD(mp, get_success, ret);\n \n        return ret;\n }\n",
    "prefixes": [
        "dpdk-dev"
    ]
}