Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/6084/?format=api
{ "id": 6084, "url": "http://patches.dpdk.org/api/patches/6084/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-5-git-send-email-maryam.tahhan@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1436118000-132275-5-git-send-email-maryam.tahhan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1436118000-132275-5-git-send-email-maryam.tahhan@intel.com", "date": "2015-07-05T17:39:56", "name": "[dpdk-dev,v4,4/8] ethdev: remove HW specific stats in stats structs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b19cd6c5c49dae53a3a02d5f91cd19f8b07303ed", "submitter": { "id": 259, "url": "http://patches.dpdk.org/api/people/259/?format=api", "name": "Tahhan, Maryam", "email": "maryam.tahhan@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-5-git-send-email-maryam.tahhan@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/6084/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/6084/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EF81AC3B0;\n\tSun, 5 Jul 2015 19:40:14 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 00F1BC3A8\n\tfor <dev@dpdk.org>; Sun, 5 Jul 2015 19:40:12 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Jul 2015 10:40:13 -0700", "from sie-lab-212-170.ir.intel.com (HELO\n\tsilpixa00378251.ir.intel.com) ([10.237.212.170])\n\tby orsmga002.jf.intel.com with ESMTP; 05 Jul 2015 10:40:11 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.15,410,1432623600\"; d=\"scan'208\";a=\"758773024\"", "From": "Maryam Tahhan <maryam.tahhan@intel.com>", "To": "dev@dpdk.org", "Date": "Sun, 5 Jul 2015 18:39:56 +0100", "Message-Id": "<1436118000-132275-5-git-send-email-maryam.tahhan@intel.com>", "X-Mailer": "git-send-email 1.9.3", "In-Reply-To": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>", "References": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 4/8] ethdev: remove HW specific stats in stats\n\tstructs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove non generic stats in rte_stats_strings and mark the relevant\nfields in struct rte_eth_stats as deprecated.\n\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>\n---\n doc/guides/rel_notes/abi.rst | 11 +++++++++++\n lib/librte_ether/rte_ethdev.c | 9 ---------\n lib/librte_ether/rte_ethdev.h | 30 ++++++++++++++++++++----------\n 3 files changed, 31 insertions(+), 19 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/abi.rst b/doc/guides/rel_notes/abi.rst\nindex 110c486..90fe7fa 100644\n--- a/doc/guides/rel_notes/abi.rst\n+++ b/doc/guides/rel_notes/abi.rst\n@@ -12,3 +12,14 @@ Examples of Deprecation Notices\n \n Deprecation Notices\n -------------------\n+* The following fields have been deprecated in rte_eth_stats:\n+ * uint64_t imissed\n+ * uint64_t ibadcrc\n+ * uint64_t ibadlen\n+ * uint64_t imcasts\n+ * uint64_t fdirmatch\n+ * uint64_t fdirmiss\n+ * uint64_t tx_pause_xon\n+ * uint64_t rx_pause_xon\n+ * uint64_t tx_pause_xoff\n+ * uint64_t rx_pause_xoff\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex e392f60..003c548 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -142,17 +142,8 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {\n \t{\"rx_bytes\", offsetof(struct rte_eth_stats, ibytes)},\n \t{\"tx_bytes\", offsetof(struct rte_eth_stats, obytes)},\n \t{\"tx_errors\", offsetof(struct rte_eth_stats, oerrors)},\n-\t{\"rx_missed_errors\", offsetof(struct rte_eth_stats, imissed)},\n-\t{\"rx_crc_errors\", offsetof(struct rte_eth_stats, ibadcrc)},\n-\t{\"rx_bad_length_errors\", offsetof(struct rte_eth_stats, ibadlen)},\n \t{\"rx_errors\", offsetof(struct rte_eth_stats, ierrors)},\n \t{\"alloc_rx_buff_failed\", offsetof(struct rte_eth_stats, rx_nombuf)},\n-\t{\"fdir_match\", offsetof(struct rte_eth_stats, fdirmatch)},\n-\t{\"fdir_miss\", offsetof(struct rte_eth_stats, fdirmiss)},\n-\t{\"tx_flow_control_xon\", offsetof(struct rte_eth_stats, tx_pause_xon)},\n-\t{\"rx_flow_control_xon\", offsetof(struct rte_eth_stats, rx_pause_xon)},\n-\t{\"tx_flow_control_xoff\", offsetof(struct rte_eth_stats, tx_pause_xoff)},\n-\t{\"rx_flow_control_xoff\", offsetof(struct rte_eth_stats, rx_pause_xoff)},\n };\n #define RTE_NB_STATS (sizeof(rte_stats_strings) / sizeof(rte_stats_strings[0]))\n \ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex f1219ac..a38d49a 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -193,19 +193,29 @@ struct rte_eth_stats {\n \tuint64_t opackets; /**< Total number of successfully transmitted packets.*/\n \tuint64_t ibytes; /**< Total number of successfully received bytes. */\n \tuint64_t obytes; /**< Total number of successfully transmitted bytes. */\n-\tuint64_t imissed; /**< Total of RX missed packets (e.g full FIFO). */\n-\tuint64_t ibadcrc; /**< Total of RX packets with CRC error. */\n-\tuint64_t ibadlen; /**< Total of RX packets with bad length. */\n+\t/**< Deprecated; Total of RX missed packets (e.g full FIFO). */\n+\tuint64_t imissed;\n+\t/**< Deprecated; Total of RX packets with CRC error. */\n+\tuint64_t ibadcrc;\n+\t/**< Deprecated; Total of RX packets with bad length. */\n+\tuint64_t ibadlen;\n \tuint64_t ierrors; /**< Total number of erroneous received packets. */\n \tuint64_t oerrors; /**< Total number of failed transmitted packets. */\n-\tuint64_t imcasts; /**< Total number of multicast received packets. */\n+\tuint64_t imcasts;\n+\t/**< Deprecated; Total number of multicast received packets. */\n \tuint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */\n-\tuint64_t fdirmatch; /**< Total number of RX packets matching a filter. */\n-\tuint64_t fdirmiss; /**< Total number of RX packets not matching any filter. */\n-\tuint64_t tx_pause_xon; /**< Total nb. of XON pause frame sent. */\n-\tuint64_t rx_pause_xon; /**< Total nb. of XON pause frame received. */\n-\tuint64_t tx_pause_xoff; /**< Total nb. of XOFF pause frame sent. */\n-\tuint64_t rx_pause_xoff; /**< Total nb. of XOFF pause frame received. */\n+\tuint64_t fdirmatch;\n+\t/**< Deprecated; Total number of RX packets matching a filter. */\n+\tuint64_t fdirmiss;\n+\t/**< Deprecated; Total number of RX packets not matching any filter. */\n+\tuint64_t tx_pause_xon;\n+\t /**< Deprecated; Total nb. of XON pause frame sent. */\n+\tuint64_t rx_pause_xon;\n+\t/**< Deprecated; Total nb. of XON pause frame received. */\n+\tuint64_t tx_pause_xoff;\n+\t/**< Deprecated; Total nb. of XOFF pause frame sent. */\n+\tuint64_t rx_pause_xoff;\n+\t/**< Deprecated; Total nb. of XOFF pause frame received. */\n \tuint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n \t/**< Total number of queue RX packets. */\n \tuint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];\n", "prefixes": [ "dpdk-dev", "v4", "4/8" ] }