Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 6083,
    "url": "http://patches.dpdk.org/api/patches/6083/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-4-git-send-email-maryam.tahhan@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1436118000-132275-4-git-send-email-maryam.tahhan@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1436118000-132275-4-git-send-email-maryam.tahhan@intel.com",
    "date": "2015-07-05T17:39:55",
    "name": "[dpdk-dev,v4,3/8] ethdev: expose extended error stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "8befd1978fc58b6a0e58a7eeee8ec1b3f3d20941",
    "submitter": {
        "id": 259,
        "url": "http://patches.dpdk.org/api/people/259/?format=api",
        "name": "Tahhan, Maryam",
        "email": "maryam.tahhan@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1436118000-132275-4-git-send-email-maryam.tahhan@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/6083/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/6083/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B8A4EC3A4;\n\tSun,  5 Jul 2015 19:40:12 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 045D5C39E\n\tfor <dev@dpdk.org>; Sun,  5 Jul 2015 19:40:10 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 05 Jul 2015 10:40:11 -0700",
            "from sie-lab-212-170.ir.intel.com (HELO\n\tsilpixa00378251.ir.intel.com) ([10.237.212.170])\n\tby orsmga002.jf.intel.com with ESMTP; 05 Jul 2015 10:40:09 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.15,410,1432623600\"; d=\"scan'208\";a=\"758773013\"",
        "From": "Maryam Tahhan <maryam.tahhan@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Sun,  5 Jul 2015 18:39:55 +0100",
        "Message-Id": "<1436118000-132275-4-git-send-email-maryam.tahhan@intel.com>",
        "X-Mailer": "git-send-email 1.9.3",
        "In-Reply-To": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>",
        "References": "<1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 3/8] ethdev: expose extended error stats",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Extend rte_eth_xstats_get to retrieve additional stats from the device\ndriver as well the ethdev generic stats.\n\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c |  7 ++++---\n lib/librte_ether/rte_ethdev.c    | 25 ++++++++++++++++---------\n 2 files changed, 20 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 7feb03c..5971d41 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2035,6 +2035,7 @@ ixgbe_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \ttotal_qprdc = 0;\n \trxnfgpc = 0;\n \ttxdgpc = 0;\n+\tcount = n - IXGBE_NB_XSTATS;\n \n \tixgbe_read_stats_registers(hw, hw_stats, &total_missed_rx, &total_qbrc,\n \t\t\t\t\t\t\t   &total_qprc, &rxnfgpc, &txdgpc, &total_qprdc);\n@@ -2047,13 +2048,13 @@ ixgbe_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstats *xstats,\n \n \t/* Extended stats */\n \tfor (i = 0; i < IXGBE_NB_XSTATS; i++) {\n-\t\tsnprintf(xstats[i].name, sizeof(xstats[i].name),\n+\t\tsnprintf(xstats[count].name, sizeof(xstats[i].name),\n \t\t\t\t\"%s\", rte_ixgbe_stats_strings[i].name);\n-\t\txstats[i].value = *(uint64_t *)(((char *)hw_stats) +\n+\t\txstats[count++].value = *(uint64_t *)(((char *)hw_stats) +\n \t\t\t\t\t\t\trte_ixgbe_stats_strings[i].offset);\n \t}\n \n-\treturn count;\n+\treturn IXGBE_NB_XSTATS;\n }\n \n static void\ndiff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex da915db..e392f60 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -1681,26 +1681,33 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n {\n \tstruct rte_eth_stats eth_stats;\n \tstruct rte_eth_dev *dev;\n-\tunsigned count, i, q;\n+\tunsigned count = 0, i, q;\n+\tsigned xcount = 0;\n \tuint64_t val, *stats_ptr;\n \n \tVALID_PORTID_OR_ERR_RET(port_id, -EINVAL);\n \n \tdev = &rte_eth_devices[port_id];\n \n-\t/* implemented by the driver */\n-\tif (dev->dev_ops->xstats_get != NULL)\n-\t\treturn (*dev->dev_ops->xstats_get)(dev, xstats, n);\n-\n-\t/* else, return generic statistics */\n+\t/* Return generic statistics */\n \tcount = RTE_NB_STATS;\n \tcount += dev->data->nb_rx_queues * RTE_NB_RXQ_STATS;\n \tcount += dev->data->nb_tx_queues * RTE_NB_TXQ_STATS;\n+\n+\t/* implemented by the driver */\n+\tif (dev->dev_ops->xstats_get != NULL) {\n+\t\t/* Retrieve the xstats from the driver at the end of the\n+\t\t * xstats struct.\n+\t\t */\n+\t\txcount = (*dev->dev_ops->xstats_get)(dev, xstats, n);\n+\t\tif (xcount < 0)\n+\t\t\treturn xcount;\n+\t}\n+\n \tif (n < count)\n-\t\treturn count;\n+\t\treturn count + xcount;\n \n \t/* now fill the xstats structure */\n-\n \tcount = 0;\n \trte_eth_stats_get(port_id, &eth_stats);\n \n@@ -1742,7 +1749,7 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,\n \t\t}\n \t}\n \n-\treturn count;\n+\treturn count + xcount;\n }\n \n /* reset ethdev extended statistics */\n",
    "prefixes": [
        "dpdk-dev",
        "v4",
        "3/8"
    ]
}